diff options
author | Revanshu Paliwal <revanshu.paliwal@sonarsource.com> | 2022-09-20 17:13:08 +0200 |
---|---|---|
committer | sonartech <sonartech@sonarsource.com> | 2022-09-22 20:03:32 +0000 |
commit | b986abff6dc9b2d435efa02d5f2a8b6600254060 (patch) | |
tree | 93971de7c1fd981396d303e3748890aa55944041 /server | |
parent | 5ba57c845f334af670b42de856d3a06ca969c82d (diff) | |
download | sonarqube-b986abff6dc9b2d435efa02d5f2a8b6600254060.tar.gz sonarqube-b986abff6dc9b2d435efa02d5f2a8b6600254060.zip |
SONAR-16906 Elements must only use allowed ARIA attributes
Diffstat (limited to 'server')
-rw-r--r-- | server/sonar-web/src/main/js/components/SourceViewer/components/LineCoverage.tsx | 44 |
1 files changed, 20 insertions, 24 deletions
diff --git a/server/sonar-web/src/main/js/components/SourceViewer/components/LineCoverage.tsx b/server/sonar-web/src/main/js/components/SourceViewer/components/LineCoverage.tsx index ee151802289..c5d69b53b40 100644 --- a/server/sonar-web/src/main/js/components/SourceViewer/components/LineCoverage.tsx +++ b/server/sonar-web/src/main/js/components/SourceViewer/components/LineCoverage.tsx @@ -47,37 +47,33 @@ export function LineCoverage({ line, scrollToUncoveredLine }: LineCoverageProps) return ( <td className={className} data-line-number={line.line} ref={coverageMarker}> <Tooltip overlay={status} placement="bottom"> - <div aria-label={status} className="source-line-bar" /> + <div aria-label={status} role="img" className="source-line-bar" /> </Tooltip> </td> ); } function getStatusTooltip(line: SourceLine) { - if (line.coverageStatus === 'uncovered') { - if (line.conditions) { - return translateWithParameters('source_viewer.tooltip.uncovered.conditions', line.conditions); - } else { - return translate('source_viewer.tooltip.uncovered'); - } - } else if (line.coverageStatus === 'covered') { - if (line.conditions) { - return translateWithParameters('source_viewer.tooltip.covered.conditions', line.conditions); - } else { - return translate('source_viewer.tooltip.covered'); - } - } else if (line.coverageStatus === 'partially-covered') { - if (line.conditions) { - return translateWithParameters( - 'source_viewer.tooltip.partially-covered.conditions', - line.coveredConditions || 0, - line.conditions - ); - } else { - return translate('source_viewer.tooltip.partially-covered'); - } + switch (line.coverageStatus) { + case 'uncovered': + return line.conditions + ? translateWithParameters('source_viewer.tooltip.uncovered.conditions', line.conditions) + : translate('source_viewer.tooltip.uncovered'); + case 'covered': + return line.conditions + ? translateWithParameters('source_viewer.tooltip.covered.conditions', line.conditions) + : translate('source_viewer.tooltip.covered'); + case 'partially-covered': + return line.conditions + ? translateWithParameters( + 'source_viewer.tooltip.partially-covered.conditions', + line.coveredConditions || 0, + line.conditions + ) + : translate('source_viewer.tooltip.partially-covered'); + default: + return undefined; } - return undefined; } export default React.memo(LineCoverage); |