diff options
author | Duarte Meneses <duarte.meneses@sonarsource.com> | 2017-10-31 16:00:27 +0100 |
---|---|---|
committer | Duarte Meneses <duarte.meneses@sonarsource.com> | 2017-11-06 15:28:51 +0100 |
commit | f0971e50be1c27fa9f8b45e8274dc7fbde55be39 (patch) | |
tree | a2ebba00dc1139a0a49d611d4abd229496b3a662 /server | |
parent | f740cb5fde92c4c77aab732390cc2b7a2b39e813 (diff) | |
download | sonarqube-f0971e50be1c27fa9f8b45e8274dc7fbde55be39.tar.gz sonarqube-f0971e50be1c27fa9f8b45e8274dc7fbde55be39.zip |
SONAR-10026 Avoid submitting callback tasks to the executor
Diffstat (limited to 'server')
2 files changed, 3 insertions, 3 deletions
diff --git a/server/sonar-ce/src/main/java/org/sonar/ce/taskprocessor/CeProcessingSchedulerImpl.java b/server/sonar-ce/src/main/java/org/sonar/ce/taskprocessor/CeProcessingSchedulerImpl.java index 6dec30bfdc8..12b376398fc 100644 --- a/server/sonar-ce/src/main/java/org/sonar/ce/taskprocessor/CeProcessingSchedulerImpl.java +++ b/server/sonar-ce/src/main/java/org/sonar/ce/taskprocessor/CeProcessingSchedulerImpl.java @@ -65,7 +65,7 @@ public class CeProcessingSchedulerImpl implements CeProcessingScheduler { public void startScheduling() { for (ChainingCallback chainingCallback : chainingCallbacks) { ListenableScheduledFuture<CeWorker.Result> future = executorService.schedule(chainingCallback.worker, delayBetweenEnabledTasks, timeUnit); - addCallback(future, chainingCallback, executorService); + addCallback(future, chainingCallback); } } @@ -165,7 +165,7 @@ public class CeProcessingSchedulerImpl implements CeProcessingScheduler { private void addCallback() { if (workerFuture != null && keepRunning()) { - Futures.addCallback(workerFuture, this, executorService); + Futures.addCallback(workerFuture, this); } } diff --git a/server/sonar-ce/src/test/java/org/sonar/ce/taskprocessor/CeProcessingSchedulerImplTest.java b/server/sonar-ce/src/test/java/org/sonar/ce/taskprocessor/CeProcessingSchedulerImplTest.java index e98fa826962..710ec5b0e87 100644 --- a/server/sonar-ce/src/test/java/org/sonar/ce/taskprocessor/CeProcessingSchedulerImplTest.java +++ b/server/sonar-ce/src/test/java/org/sonar/ce/taskprocessor/CeProcessingSchedulerImplTest.java @@ -230,7 +230,7 @@ public class CeProcessingSchedulerImplTest { for (int i = 0; i < workerCount; i++) { verify(processingExecutorService).schedule(workers[i], ceConfiguration.getQueuePollingDelay(), MILLISECONDS); } - verify(listenableScheduledFuture, times(workerCount)).addListener(any(Runnable.class), eq(processingExecutorService)); + verify(listenableScheduledFuture, times(workerCount)).addListener(any(Runnable.class), eq(MoreExecutors.directExecutor())); for (int i = 0; i < workerCount; i++) { verify(ceWorkerFactory).create(i); } |