SONAR-1800: Fix issue with ClassLoader for Maven 3.x and Java 1.5

* Restore context ClassLoader after execution of Maven plugin.

* Add abstract implementation of MavenPluginExecutor to reduce duplications
  in concrete implementations for different Maven versions.

1 files changed, 43 insertions, 0 deletions

diff --git a/sonar-batch/src/test/java/org/sonar/batch/AbstractMavenPluginExecutorTest.java b/sonar-batch/src/test/java/org/sonar/batch/AbstractMavenPluginExecutorTest.java
new file mode 100644
index 00000000000..e86516f0284
--- /dev/null
+++ b/sonar-batch/src/test/java/org/sonar/batch/AbstractMavenPluginExecutorTest.java
@@ -0,0 +1,43 @@
+package org.sonar.batch;
+
+import org.junit.Test;
+import org.sonar.api.batch.maven.MavenPlugin;
+import org.sonar.api.batch.maven.MavenPluginHandler;
+import org.sonar.api.resources.Project;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+public class AbstractMavenPluginExecutorTest {
+
+  @Test
+  public void pluginVersionIsOptional() {
+    assertThat(AbstractMavenPluginExecutor.getGoal("group", "artifact", null, "goal"), is("group:artifact::goal"));
+  }
+
+  static class FakeCheckstyleMavenPluginHandler implements MavenPluginHandler {
+    public String getGroupId() {
+      return "org.apache.maven.plugins";
+    }
+
+    public String getArtifactId() {
+      return "maven-checkstyle-plugin";
+    }
+
+    public String getVersion() {
+      return "2.2";
+    }
+
+    public boolean isFixedVersion() {
+      return false;
+    }
+
+    public String[] getGoals() {
+      return new String[] { "checkstyle" };
+    }
+
+    public void configure(Project project, MavenPlugin plugin) {
+    }
+  }
+
+}