aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-batch/src
diff options
context:
space:
mode:
authorJean-Baptiste Lievremont <jean-baptiste.lievremont@sonarsource.com>2013-10-02 11:32:00 +0200
committerJean-Baptiste Lievremont <jean-baptiste.lievremont@sonarsource.com>2013-10-02 11:32:00 +0200
commit7a8f6c251214670b5bdfba3ac94bf8c866af1933 (patch)
tree8f327acc67b0b3f56238454ecb694f0d53450cbe /sonar-batch/src
parent59afc718cbc197ed4f67f80af9ca40df4edbf51b (diff)
downloadsonarqube-7a8f6c251214670b5bdfba3ac94bf8c866af1933.tar.gz
sonarqube-7a8f6c251214670b5bdfba3ac94bf8c866af1933.zip
Move project key validation to core
Diffstat (limited to 'sonar-batch/src')
-rw-r--r--sonar-batch/src/main/java/org/sonar/batch/scan/ProjectReactorValidator.java11
1 files changed, 4 insertions, 7 deletions
diff --git a/sonar-batch/src/main/java/org/sonar/batch/scan/ProjectReactorValidator.java b/sonar-batch/src/main/java/org/sonar/batch/scan/ProjectReactorValidator.java
index 927976cf0f1..df55d881387 100644
--- a/sonar-batch/src/main/java/org/sonar/batch/scan/ProjectReactorValidator.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/scan/ProjectReactorValidator.java
@@ -19,6 +19,8 @@
*/
package org.sonar.batch.scan;
+import org.sonar.core.component.ComponentKeys;
+
import com.google.common.base.Joiner;
import org.codehaus.plexus.util.StringUtils;
import org.sonar.api.CoreProperties;
@@ -37,11 +39,6 @@ import java.util.List;
*/
public class ProjectReactorValidator {
- /*
- * Allowed characters are alphanumeric, dash '-', underscore '_', period '.' and colon ':',
- * with at least one non-digit
- */
- private static final String VALID_MODULE_KEY_REGEXP = "[\\p{Alnum}\\-_.:]*[\\p{Alpha}\\-_.:]+[\\p{Alnum}\\-_.:]*";
private final Settings settings;
private final ResourceDao resourceDao;
@@ -75,14 +72,14 @@ public class ProjectReactorValidator {
}
private void validateKey(ProjectDefinition def, List<String> validationMessages) {
- if (!def.getKey().matches(VALID_MODULE_KEY_REGEXP)) {
+ if (!ComponentKeys.isValidModuleKey(def.getKey())) {
validationMessages.add(String.format("%s is not a valid project or module key", def.getKey()));
}
}
private void validateBranch(List<String> validationMessages) {
String branch = settings.getString(CoreProperties.PROJECT_BRANCH_PROPERTY);
- if (StringUtils.isNotEmpty(branch) && !branch.matches(VALID_MODULE_KEY_REGEXP)) {
+ if (StringUtils.isNotEmpty(branch) && !ComponentKeys.isValidModuleKey(branch)) {
validationMessages.add(String.format("%s is not a valid branch name", branch));
}
}