diff options
author | Simon Brandhof <simon.brandhof@gmail.com> | 2014-04-04 16:56:26 +0200 |
---|---|---|
committer | Simon Brandhof <simon.brandhof@gmail.com> | 2014-04-04 16:56:26 +0200 |
commit | 3bfcfa0de67e7f00d7cd0dc74649fef7e5772298 (patch) | |
tree | 195c87fdb3789550232ee3a157afbb6aa97d9b7a /sonar-batch | |
parent | 0e1aeeb98b0458804682531ea27fe2afdf02ebfc (diff) | |
download | sonarqube-3bfcfa0de67e7f00d7cd0dc74649fef7e5772298.tar.gz sonarqube-3bfcfa0de67e7f00d7cd0dc74649fef7e5772298.zip |
Fix some quality flaws
Diffstat (limited to 'sonar-batch')
-rw-r--r-- | sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java | 4 | ||||
-rw-r--r-- | sonar-batch/src/test/java/org/sonar/batch/rule/RulesProviderTest.java | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java b/sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java index 49b4cf95986..3f1a487700d 100644 --- a/sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java +++ b/sonar-batch/src/main/java/org/sonar/batch/rule/RulesProvider.java @@ -77,8 +77,8 @@ public class RulesProvider extends ProviderAdapter { .setName(ruleDto.getName()) .setSeverity(ruleDto.getSeverityString()) .setDescription(ruleDto.getDescription()) - .setStatus(RuleStatus.valueOf(ruleDto.getStatus())); - // TODO should we set metadata ? + .setStatus(RuleStatus.valueOf(ruleDto.getStatus())) + .setInternalKey(ruleDto.getConfigKey()); if (hasCharacteristic(ruleDto)) { newRule.setDebtSubCharacteristic(effectiveCharacteristic(ruleDto, ruleKey, debtModel).key()); diff --git a/sonar-batch/src/test/java/org/sonar/batch/rule/RulesProviderTest.java b/sonar-batch/src/test/java/org/sonar/batch/rule/RulesProviderTest.java index 3bf623aab5a..42ab22fed38 100644 --- a/sonar-batch/src/test/java/org/sonar/batch/rule/RulesProviderTest.java +++ b/sonar-batch/src/test/java/org/sonar/batch/rule/RulesProviderTest.java @@ -101,7 +101,7 @@ public class RulesProviderTest extends AbstractDaoTestCase { assertThat(rule.name()).isEqualTo("Avoid Null"); assertThat(rule.description()).isEqualTo("Should avoid NULL"); assertThat(rule.severity()).isEqualTo(Severity.MINOR); - assertThat(rule.metadata()).isNull(); + assertThat(rule.internalKey()).isNull(); assertThat(rule.params()).hasSize(1); RuleParam param = rule.param("myParameter"); |