diff options
| author | Julien Lancelot <julien.lancelot@gmail.com> | 2013-06-13 16:31:36 +0200 |
|---|---|---|
| committer | Julien Lancelot <julien.lancelot@gmail.com> | 2013-06-13 16:32:41 +0200 |
| commit | 27576858612f0d5a141ce71b2862ff6c906dabfb (patch) | |
| tree | e3a7f20b3b56ea5d017ed6f13d192b224bc1e154 /sonar-core/src | |
| parent | a06137eb1111b48e20ccc2f0ac5989e35bd83c55 (diff) | |
| download | sonarqube-27576858612f0d5a141ce71b2862ff6c906dabfb.tar.gz sonarqube-27576858612f0d5a141ce71b2862ff6c906dabfb.zip | |
SONAR-4301 Remove order by id desc because it generates an important overhead
Diffstat (limited to 'sonar-core/src')
| -rw-r--r-- | sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml | 2 | ||||
| -rw-r--r-- | sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java | 24 |
2 files changed, 0 insertions, 26 deletions
diff --git a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml index 1495d7bf359..aff84d57572 100644 --- a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml +++ b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml @@ -199,7 +199,6 @@ </foreach> </foreach> </where> - order by i.id desc </select> <select id="selectIssues" parameterType="map" resultType="Issue" fetchSize="100000"> @@ -307,7 +306,6 @@ and i.issue_creation_date < #{query.createdBefore} </if> </where> - order by i.id desc </sql> </mapper> diff --git a/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java b/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java index 504e475cdc3..a792176d525 100644 --- a/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java +++ b/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java @@ -91,18 +91,6 @@ public class IssueDaoTest extends AbstractDaoTestCase { } @Test - public void should_select_issues_sort_results_by_id_desc() { - setupData("shared", "should_select_all"); - - IssueQuery query = IssueQuery.builder().requiredRole("user").build(); - - List<IssueDto> results = dao.selectIssues(query); - assertThat(results.get(0).getId()).isEqualTo(102); - assertThat(results.get(1).getId()).isEqualTo(101); - assertThat(results.get(2).getId()).isEqualTo(100); - } - - @Test public void should_select_by_rules() { setupData("shared", "should_select_by_rules"); @@ -317,18 +305,6 @@ public class IssueDaoTest extends AbstractDaoTestCase { assertThat(results).hasSize(3); } - @Test - public void should_select_by_ids_sort_results_by_id_desc() { - setupData("shared", "should_select_by_ids"); - - List<IssueDto> results = newArrayList(dao.selectByIds(newArrayList(100l, 101l, 102l))); - - assertThat(results.get(0).getId()).isEqualTo(102); - assertThat(results.get(1).getId()).isEqualTo(101); - assertThat(results.get(2).getId()).isEqualTo(100); - } - - private List<Long> getIssueIds(List<IssueDto> issues) { return newArrayList(Iterables.transform(issues, new Function<IssueDto, Long>() { @Override |