summaryrefslogtreecommitdiffstats
path: root/sonar-core
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@sonarsource.com>2015-07-03 15:19:22 +0200
committerSimon Brandhof <simon.brandhof@sonarsource.com>2015-07-03 15:19:32 +0200
commit1a3fdbc0d14cf4d72142496df7ae8a7f14df1109 (patch)
treefe0552bd93a90eb4eb6ea29a33ecf22a3efb0c2a /sonar-core
parentf50592289c6253ef9465107447b8c2ed9eaf365a (diff)
downloadsonarqube-1a3fdbc0d14cf4d72142496df7ae8a7f14df1109.tar.gz
sonarqube-1a3fdbc0d14cf4d72142496df7ae8a7f14df1109.zip
Fix stability of issue tracking
Diffstat (limited to 'sonar-core')
-rw-r--r--sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java5
1 files changed, 2 insertions, 3 deletions
diff --git a/sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java b/sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java
index 9709ca8886e..4ec4f84220b 100644
--- a/sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java
+++ b/sonar-core/src/main/java/org/sonar/core/issue/tracking/Tracker.java
@@ -87,7 +87,6 @@ public class Tracker<RAW extends Trackable, BASE extends Trackable> {
}
private void relocateManualIssues(Input<RAW> rawInput, Input<BASE> baseInput, Tracking<RAW, BASE> tracking) {
- // FIXME copy of Set if required to avoid concurrent modifications (see tracking.associateManualIssueToLine())
Iterable<BASE> manualIssues = from(tracking.getUnmatchedBases()).filter(IsManual.INSTANCE);
for (BASE base : manualIssues) {
if (base.getLine() == null) {
@@ -107,7 +106,7 @@ public class Tracker<RAW extends Trackable, BASE extends Trackable> {
// issue is kept at the same location, even if code changes
tracking.keepManualIssueOpen(base, base.getLine());
}
- // TODO if hash found multiple times, , pick the closest line
+ // TODO if hash found multiple times, pick the closest line
}
}
}
@@ -254,7 +253,7 @@ public class Tracker<RAW extends Trackable, BASE extends Trackable> {
LineHashKey(Trackable trackable) {
this.ruleKey = trackable.getRuleKey();
- this.lineHash = trackable.getLineHash();
+ this.lineHash = StringUtils.defaultString(trackable.getLineHash(), "");
}
@Override