diff options
author | Simon Brandhof <simon.brandhof@sonarsource.com> | 2014-10-03 11:34:21 +0200 |
---|---|---|
committer | Simon Brandhof <simon.brandhof@sonarsource.com> | 2014-10-03 11:34:21 +0200 |
commit | 707fcb29d63c8cccd7d480a83deb5b8ac32414d8 (patch) | |
tree | 380755780a787500e592961cef906172d5e6cb3f /sonar-core | |
parent | e891e61a2fa7f0a171731d5a34091a239d2c39cc (diff) | |
download | sonarqube-707fcb29d63c8cccd7d480a83deb5b8ac32414d8.tar.gz sonarqube-707fcb29d63c8cccd7d480a83deb5b8ac32414d8.zip |
Fix some quality flaws
Diffstat (limited to 'sonar-core')
-rw-r--r-- | sonar-core/src/main/java/org/sonar/core/issue/db/IssueChangeDao.java | 8 | ||||
-rw-r--r-- | sonar-core/src/main/java/org/sonar/core/issue/workflow/Transition.java | 5 |
2 files changed, 7 insertions, 6 deletions
diff --git a/sonar-core/src/main/java/org/sonar/core/issue/db/IssueChangeDao.java b/sonar-core/src/main/java/org/sonar/core/issue/db/IssueChangeDao.java index 92e971323fc..b236a18b366 100644 --- a/sonar-core/src/main/java/org/sonar/core/issue/db/IssueChangeDao.java +++ b/sonar-core/src/main/java/org/sonar/core/issue/db/IssueChangeDao.java @@ -31,7 +31,11 @@ import org.sonar.core.persistence.MyBatis; import javax.annotation.CheckForNull; -import java.util.*; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Map; import static com.google.common.collect.Lists.newArrayList; import static com.google.common.collect.Maps.newHashMap; @@ -109,7 +113,7 @@ public class IssueChangeDao implements BatchComponent, ServerComponent { } public void insert(DbSession session, IssueChangeDto change) { - session.getMapper(IssueChangeMapper.class).insert(change); + session.getMapper(IssueChangeMapper.class).insert(change); } public boolean delete(String key) { diff --git a/sonar-core/src/main/java/org/sonar/core/issue/workflow/Transition.java b/sonar-core/src/main/java/org/sonar/core/issue/workflow/Transition.java index 2b18502b6a8..4afc317c75c 100644 --- a/sonar-core/src/main/java/org/sonar/core/issue/workflow/Transition.java +++ b/sonar-core/src/main/java/org/sonar/core/issue/workflow/Transition.java @@ -99,10 +99,7 @@ public class Transition { if (!key.equals(that.key)) { return false; } - if (!to.equals(that.to)) { - return false; - } - return true; + return to.equals(that.to); } @Override |