aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-core
diff options
context:
space:
mode:
authorJulien Lancelot <julien.lancelot@gmail.com>2013-10-02 09:24:13 +0200
committerJulien Lancelot <julien.lancelot@gmail.com>2013-10-02 09:24:43 +0200
commitd908112cc1fe908d8f8925706d3398a499386802 (patch)
treeb1d348c9cf21e1d10b6e01407348cc53aa8a839c /sonar-core
parent1aaeab7a4a611ec99565ad5a9095e464dd16e9dd (diff)
downloadsonarqube-d908112cc1fe908d8f8925706d3398a499386802.tar.gz
sonarqube-d908112cc1fe908d8f8925706d3398a499386802.zip
Fix some quality flaws
Diffstat (limited to 'sonar-core')
-rw-r--r--sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java6
1 files changed, 4 insertions, 2 deletions
diff --git a/sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java b/sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java
index cac450e9509..2453437ddff 100644
--- a/sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java
+++ b/sonar-core/src/main/java/org/sonar/core/technicaldebt/functions/LinearFunction.java
@@ -43,13 +43,15 @@ public class LinearFunction extends AbstractFunction {
public double costInHours(TechnicalDebtRequirement requirement, Collection<Violation> violations) {
double points = 0.0;
for (Violation violation : violations) {
- points += (violation.getCost() != null ? violation.getCost() : DEFAULT_VIOLATION_COST);
+ Double effortToFix = violation.getCost();
+ points += effortToFix != null ? effortToFix : DEFAULT_VIOLATION_COST;
}
return points * getConverter().toDays(requirement.getRemediationFactor());
}
public long costInMinutes(TechnicalDebtRequirement requirement, Issue issue) {
- double points = (issue.effortToFix() != null ? issue.effortToFix() : DEFAULT_VIOLATION_COST);
+ Double effortToFix = issue.effortToFix();
+ double points = effortToFix != null ? effortToFix : DEFAULT_VIOLATION_COST;
return Double.valueOf(points * factorInMinutes(requirement)).longValue();
}
}