aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-core
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@sonarsource.com>2015-06-19 22:58:26 +0200
committerSimon Brandhof <simon.brandhof@sonarsource.com>2015-06-19 22:58:43 +0200
commit44447ed6b69b1497ed60cc4d610742a5d9987873 (patch)
tree8fd855775d044924a42cfa2e8b87d8453538f69d /sonar-core
parent48a077eea19bbe6c0c83dac028e1026bba74a09a (diff)
downloadsonarqube-44447ed6b69b1497ed60cc4d610742a5d9987873.tar.gz
sonarqube-44447ed6b69b1497ed60cc4d610742a5d9987873.zip
Fix Q flaws
Diffstat (limited to 'sonar-core')
-rw-r--r--sonar-core/src/main/java/org/sonar/core/config/SecurityProperties.java4
-rw-r--r--sonar-core/src/main/java/org/sonar/core/issue/workflow/StateMachine.java9
-rw-r--r--sonar-core/src/main/java/org/sonar/core/util/HttpsTrust.java8
3 files changed, 15 insertions, 6 deletions
diff --git a/sonar-core/src/main/java/org/sonar/core/config/SecurityProperties.java b/sonar-core/src/main/java/org/sonar/core/config/SecurityProperties.java
index e4678e69bc2..ec10843e3e9 100644
--- a/sonar-core/src/main/java/org/sonar/core/config/SecurityProperties.java
+++ b/sonar-core/src/main/java/org/sonar/core/config/SecurityProperties.java
@@ -36,7 +36,7 @@ class SecurityProperties {
return ImmutableList.of(
PropertyDefinition.builder(CoreProperties.CORE_ALLOW_USERS_TO_SIGNUP_PROPERTY)
- .defaultValue("" + CoreProperties.CORE_ALLOW_USERS_TO_SIGNUP_DEAULT_VALUE)
+ .defaultValue(Boolean.toString(CoreProperties.CORE_ALLOW_USERS_TO_SIGNUP_DEAULT_VALUE))
.name("Allow users to sign up online")
.description("Users can sign up online.")
.type(PropertyType.BOOLEAN)
@@ -51,7 +51,7 @@ class SecurityProperties {
.build(),
PropertyDefinition.builder(CoreProperties.CORE_FORCE_AUTHENTICATION_PROPERTY)
- .defaultValue("" + CoreProperties.CORE_FORCE_AUTHENTICATION_DEFAULT_VALUE)
+ .defaultValue(Boolean.toString(CoreProperties.CORE_FORCE_AUTHENTICATION_DEFAULT_VALUE))
.name("Force user authentication")
.description("Forcing user authentication stops un-logged users to access SonarQube.")
.type(PropertyType.BOOLEAN)
diff --git a/sonar-core/src/main/java/org/sonar/core/issue/workflow/StateMachine.java b/sonar-core/src/main/java/org/sonar/core/issue/workflow/StateMachine.java
index 15d0a39ccca..25e3686a715 100644
--- a/sonar-core/src/main/java/org/sonar/core/issue/workflow/StateMachine.java
+++ b/sonar-core/src/main/java/org/sonar/core/issue/workflow/StateMachine.java
@@ -20,13 +20,16 @@
package org.sonar.core.issue.workflow;
import com.google.common.base.Preconditions;
-import com.google.common.collect.*;
-
-import javax.annotation.CheckForNull;
+import com.google.common.collect.ArrayListMultimap;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ListMultimap;
+import com.google.common.collect.Sets;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.Set;
+import javax.annotation.CheckForNull;
public class StateMachine {
diff --git a/sonar-core/src/main/java/org/sonar/core/util/HttpsTrust.java b/sonar-core/src/main/java/org/sonar/core/util/HttpsTrust.java
index aee97841880..6ef4df804f6 100644
--- a/sonar-core/src/main/java/org/sonar/core/util/HttpsTrust.java
+++ b/sonar-core/src/main/java/org/sonar/core/util/HttpsTrust.java
@@ -19,12 +19,18 @@
*/
package org.sonar.core.util;
-import javax.net.ssl.*;
import java.net.HttpURLConnection;
import java.security.KeyManagementException;
import java.security.NoSuchAlgorithmException;
import java.security.SecureRandom;
import java.security.cert.X509Certificate;
+import javax.net.ssl.HostnameVerifier;
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.SSLSession;
+import javax.net.ssl.SSLSocketFactory;
+import javax.net.ssl.TrustManager;
+import javax.net.ssl.X509TrustManager;
/**
* @since 4.0