diff options
author | David Gageot <david@gageot.net> | 2012-05-25 22:47:42 +0200 |
---|---|---|
committer | David Gageot <david@gageot.net> | 2012-05-25 22:47:42 +0200 |
commit | 2f66634a7ab0cff2eb20f7b32347a35174075334 (patch) | |
tree | dd65c0b4f73200446bca83e154124ccee722af71 /sonar-core | |
parent | 86c1e331b375f8e24ec479b2e6acb30235b5a84a (diff) | |
download | sonarqube-2f66634a7ab0cff2eb20f7b32347a35174075334.tar.gz sonarqube-2f66634a7ab0cff2eb20f7b32347a35174075334.zip |
Cleaner code and fix warnings
Diffstat (limited to 'sonar-core')
4 files changed, 1 insertions, 8 deletions
diff --git a/sonar-core/src/main/java/org/sonar/core/review/workflow/ReviewDatabaseStore.java b/sonar-core/src/main/java/org/sonar/core/review/workflow/ReviewDatabaseStore.java index b48ea94bf5f..9dd425e38bc 100644 --- a/sonar-core/src/main/java/org/sonar/core/review/workflow/ReviewDatabaseStore.java +++ b/sonar-core/src/main/java/org/sonar/core/review/workflow/ReviewDatabaseStore.java @@ -35,8 +35,6 @@ import org.sonar.core.review.ReviewDto; import org.sonar.core.review.ReviewMapper; import org.sonar.core.review.workflow.review.Comment; import org.sonar.core.review.workflow.review.DefaultReview; -import org.sonar.core.review.workflow.review.MutableReview; - import java.util.Date; import java.util.List; diff --git a/sonar-core/src/main/java/org/sonar/core/review/workflow/ReviewStore.java b/sonar-core/src/main/java/org/sonar/core/review/workflow/ReviewStore.java index 22a298e1ed1..36540973903 100644 --- a/sonar-core/src/main/java/org/sonar/core/review/workflow/ReviewStore.java +++ b/sonar-core/src/main/java/org/sonar/core/review/workflow/ReviewStore.java @@ -21,8 +21,6 @@ package org.sonar.core.review.workflow; import org.sonar.api.config.Settings; import org.sonar.core.review.workflow.review.DefaultReview; -import org.sonar.core.review.workflow.review.MutableReview; - import java.util.List; public interface ReviewStore { diff --git a/sonar-core/src/main/java/org/sonar/core/review/workflow/WorkflowEngine.java b/sonar-core/src/main/java/org/sonar/core/review/workflow/WorkflowEngine.java index 22e821cf508..a73d42cadf1 100644 --- a/sonar-core/src/main/java/org/sonar/core/review/workflow/WorkflowEngine.java +++ b/sonar-core/src/main/java/org/sonar/core/review/workflow/WorkflowEngine.java @@ -31,7 +31,6 @@ import org.sonar.core.review.workflow.condition.Condition; import org.sonar.core.review.workflow.function.Function; import org.sonar.core.review.workflow.review.DefaultReview; import org.sonar.core.review.workflow.review.DefaultWorkflowContext; -import org.sonar.core.review.workflow.review.MutableReview; import org.sonar.core.review.workflow.review.Review; import org.sonar.core.review.workflow.review.WorkflowContext; import org.sonar.core.review.workflow.screen.Screen; @@ -105,7 +104,7 @@ public class WorkflowEngine implements ServerComponent { Map<String, String> immutableParameters = ImmutableMap.copyOf(parameters); // TODO execute functions are change state before functions that consume state (like "create-jira-issue") - Review initialReview = ((DefaultReview) review).cloneImmutable(); + Review initialReview = review.cloneImmutable(); for (Function function : workflow.getFunctions(commandKey)) { function.doExecute(review, initialReview, context, immutableParameters); } diff --git a/sonar-core/src/test/java/org/sonar/core/review/workflow/ReviewDatabaseStoreTest.java b/sonar-core/src/test/java/org/sonar/core/review/workflow/ReviewDatabaseStoreTest.java index 99eae6f7330..0dbfa6a6d3b 100644 --- a/sonar-core/src/test/java/org/sonar/core/review/workflow/ReviewDatabaseStoreTest.java +++ b/sonar-core/src/test/java/org/sonar/core/review/workflow/ReviewDatabaseStoreTest.java @@ -24,8 +24,6 @@ import org.sonar.api.utils.DateUtils; import org.sonar.core.persistence.DaoTestCase; import org.sonar.core.review.workflow.review.Comment; import org.sonar.core.review.workflow.review.DefaultReview; -import org.sonar.core.review.workflow.review.MutableReview; - import java.util.Date; public class ReviewDatabaseStoreTest extends DaoTestCase { |