aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-db
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@sonarsource.com>2016-02-29 10:11:27 +0100
committerSimon Brandhof <simon.brandhof@sonarsource.com>2016-02-29 10:11:27 +0100
commit74e26bd277d246d91a08cd7d51f11bff916ee221 (patch)
treeaf7c712b02e2834f98a5d473b5eb8878019b1762 /sonar-db
parent6efaff4f7669025ba44d53974be4e301512c3098 (diff)
downloadsonarqube-74e26bd277d246d91a08cd7d51f11bff916ee221.tar.gz
sonarqube-74e26bd277d246d91a08cd7d51f11bff916ee221.zip
Fix quality flaws
Diffstat (limited to 'sonar-db')
-rw-r--r--sonar-db/src/main/java/org/sonar/db/ce/CeActivityDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/ce/CeQueueDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/dashboard/DashboardDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/dashboard/WidgetDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/issue/IssueChangeDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/issue/IssueDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/permission/PermissionDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/permission/PermissionTemplateDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/profiling/ProfilingConnectionHandler.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/purge/PurgeDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/qualitygate/ProjectQgateAssociationDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/user/GroupMembershipDao.java2
-rw-r--r--sonar-db/src/main/java/org/sonar/db/version/v52/MoveProjectProfileAssociation.java2
14 files changed, 14 insertions, 14 deletions
diff --git a/sonar-db/src/main/java/org/sonar/db/ce/CeActivityDao.java b/sonar-db/src/main/java/org/sonar/db/ce/CeActivityDao.java
index 6bb9b68aff0..050389c8858 100644
--- a/sonar-db/src/main/java/org/sonar/db/ce/CeActivityDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/ce/CeActivityDao.java
@@ -79,7 +79,7 @@ public class CeActivityDao implements Dao {
return mapper(dbSession).countByQuery(query);
}
- private CeActivityMapper mapper(DbSession dbSession) {
+ private static CeActivityMapper mapper(DbSession dbSession) {
return dbSession.getMapper(CeActivityMapper.class);
}
}
diff --git a/sonar-db/src/main/java/org/sonar/db/ce/CeQueueDao.java b/sonar-db/src/main/java/org/sonar/db/ce/CeQueueDao.java
index 543a8f4956d..c6749602493 100644
--- a/sonar-db/src/main/java/org/sonar/db/ce/CeQueueDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/ce/CeQueueDao.java
@@ -128,7 +128,7 @@ public class CeQueueDao implements Dao {
return Optional.of(result);
}
- private CeQueueMapper mapper(DbSession session) {
+ private static CeQueueMapper mapper(DbSession session) {
return session.getMapper(CeQueueMapper.class);
}
}
diff --git a/sonar-db/src/main/java/org/sonar/db/dashboard/DashboardDao.java b/sonar-db/src/main/java/org/sonar/db/dashboard/DashboardDao.java
index 7dc94a8ecdf..8e2a90ff2ce 100644
--- a/sonar-db/src/main/java/org/sonar/db/dashboard/DashboardDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/dashboard/DashboardDao.java
@@ -83,7 +83,7 @@ public class DashboardDao implements Dao {
return mapper(session).selectAllowedById(key, userId != null ? userId : -1L);
}
- private DashboardMapper mapper(DbSession session) {
+ private static DashboardMapper mapper(DbSession session) {
return session.getMapper(DashboardMapper.class);
}
}
diff --git a/sonar-db/src/main/java/org/sonar/db/dashboard/WidgetDao.java b/sonar-db/src/main/java/org/sonar/db/dashboard/WidgetDao.java
index a6a86b2bb73..0b39fccf929 100644
--- a/sonar-db/src/main/java/org/sonar/db/dashboard/WidgetDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/dashboard/WidgetDao.java
@@ -67,7 +67,7 @@ public class WidgetDao implements Dao {
return mapper(session).selectAll();
}
- private WidgetMapper mapper(DbSession session) {
+ private static WidgetMapper mapper(DbSession session) {
return session.getMapper(WidgetMapper.class);
}
diff --git a/sonar-db/src/main/java/org/sonar/db/issue/IssueChangeDao.java b/sonar-db/src/main/java/org/sonar/db/issue/IssueChangeDao.java
index 9ea8f81dfff..8b8b32a1534 100644
--- a/sonar-db/src/main/java/org/sonar/db/issue/IssueChangeDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/issue/IssueChangeDao.java
@@ -140,7 +140,7 @@ public class IssueChangeDao implements Dao {
}
}
- private IssueChangeMapper mapper(DbSession session) {
+ private static IssueChangeMapper mapper(DbSession session) {
return session.getMapper(IssueChangeMapper.class);
}
}
diff --git a/sonar-db/src/main/java/org/sonar/db/issue/IssueDao.java b/sonar-db/src/main/java/org/sonar/db/issue/IssueDao.java
index 7c8105f46c5..6e0f9665589 100644
--- a/sonar-db/src/main/java/org/sonar/db/issue/IssueDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/issue/IssueDao.java
@@ -143,7 +143,7 @@ public class IssueDao implements Dao {
mapper(session).update(dto);
}
- private IssueMapper mapper(DbSession session) {
+ private static IssueMapper mapper(DbSession session) {
return session.getMapper(IssueMapper.class);
}
diff --git a/sonar-db/src/main/java/org/sonar/db/permission/PermissionDao.java b/sonar-db/src/main/java/org/sonar/db/permission/PermissionDao.java
index b305a01b772..a347da0cf0a 100644
--- a/sonar-db/src/main/java/org/sonar/db/permission/PermissionDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/permission/PermissionDao.java
@@ -140,7 +140,7 @@ public class PermissionDao implements Dao {
return params;
}
- private PermissionMapper mapper(SqlSession session) {
+ private static PermissionMapper mapper(SqlSession session) {
return session.getMapper(PermissionMapper.class);
}
}
diff --git a/sonar-db/src/main/java/org/sonar/db/permission/PermissionTemplateDao.java b/sonar-db/src/main/java/org/sonar/db/permission/PermissionTemplateDao.java
index a5ab612198f..cb9c14a51d8 100644
--- a/sonar-db/src/main/java/org/sonar/db/permission/PermissionTemplateDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/permission/PermissionTemplateDao.java
@@ -419,7 +419,7 @@ public class PermissionTemplateDao implements Dao {
return new Date(system.now());
}
- private PermissionTemplateMapper mapper(SqlSession session) {
+ private static PermissionTemplateMapper mapper(SqlSession session) {
return session.getMapper(PermissionTemplateMapper.class);
}
}
diff --git a/sonar-db/src/main/java/org/sonar/db/profiling/ProfilingConnectionHandler.java b/sonar-db/src/main/java/org/sonar/db/profiling/ProfilingConnectionHandler.java
index 1f373c8d540..eb1d38327f0 100644
--- a/sonar-db/src/main/java/org/sonar/db/profiling/ProfilingConnectionHandler.java
+++ b/sonar-db/src/main/java/org/sonar/db/profiling/ProfilingConnectionHandler.java
@@ -49,7 +49,7 @@ class ProfilingConnectionHandler implements InvocationHandler {
return result;
}
- private Object buildStatementProxy(Class<? extends Statement> stmtClass, InvocationHandler handler) {
+ private static Object buildStatementProxy(Class<? extends Statement> stmtClass, InvocationHandler handler) {
return Proxy.newProxyInstance(ProfilingConnectionHandler.class.getClassLoader(), new Class[] {stmtClass}, handler);
}
diff --git a/sonar-db/src/main/java/org/sonar/db/purge/PurgeDao.java b/sonar-db/src/main/java/org/sonar/db/purge/PurgeDao.java
index a0d89235131..fb8c66be654 100644
--- a/sonar-db/src/main/java/org/sonar/db/purge/PurgeDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/purge/PurgeDao.java
@@ -206,7 +206,7 @@ public class PurgeDao implements Dao {
return resourceDao.selectWholeTreeForRootId(session, rootId, Scopes.PROJECT);
}
- private PurgeMapper mapper(DbSession session) {
+ private static PurgeMapper mapper(DbSession session) {
return session.getMapper(PurgeMapper.class);
}
}
diff --git a/sonar-db/src/main/java/org/sonar/db/qualitygate/ProjectQgateAssociationDao.java b/sonar-db/src/main/java/org/sonar/db/qualitygate/ProjectQgateAssociationDao.java
index aff52156a24..0d541008b5a 100644
--- a/sonar-db/src/main/java/org/sonar/db/qualitygate/ProjectQgateAssociationDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/qualitygate/ProjectQgateAssociationDao.java
@@ -51,7 +51,7 @@ public class ProjectQgateAssociationDao implements Dao {
return selectProjects(query, gateId, 0, Integer.MAX_VALUE);
}
- private ProjectQgateAssociationMapper mapper(SqlSession session) {
+ private static ProjectQgateAssociationMapper mapper(SqlSession session) {
return session.getMapper(ProjectQgateAssociationMapper.class);
}
diff --git a/sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java b/sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java
index 4cb73663198..92cabb76426 100644
--- a/sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java
@@ -105,7 +105,7 @@ public class RuleDao implements Dao {
mapper(session).insert(dto);
}
- private RuleMapper mapper(DbSession session) {
+ private static RuleMapper mapper(DbSession session) {
return session.getMapper(RuleMapper.class);
}
diff --git a/sonar-db/src/main/java/org/sonar/db/user/GroupMembershipDao.java b/sonar-db/src/main/java/org/sonar/db/user/GroupMembershipDao.java
index 11e2119c442..d7a9260565e 100644
--- a/sonar-db/src/main/java/org/sonar/db/user/GroupMembershipDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/user/GroupMembershipDao.java
@@ -111,7 +111,7 @@ public class GroupMembershipDao implements Dao {
return selectGroups(query, userId, 0, Integer.MAX_VALUE);
}
- private GroupMembershipMapper mapper(SqlSession session) {
+ private static GroupMembershipMapper mapper(SqlSession session) {
return session.getMapper(GroupMembershipMapper.class);
}
}
diff --git a/sonar-db/src/main/java/org/sonar/db/version/v52/MoveProjectProfileAssociation.java b/sonar-db/src/main/java/org/sonar/db/version/v52/MoveProjectProfileAssociation.java
index bbfdd267962..a34d319b1f4 100644
--- a/sonar-db/src/main/java/org/sonar/db/version/v52/MoveProjectProfileAssociation.java
+++ b/sonar-db/src/main/java/org/sonar/db/version/v52/MoveProjectProfileAssociation.java
@@ -116,7 +116,7 @@ public class MoveProjectProfileAssociation extends BaseDataChange {
}
}
- private Table<String, String, String> getProfileKeysByLanguageThenName(final Context context) throws SQLException {
+ private static Table<String, String, String> getProfileKeysByLanguageThenName(final Context context) throws SQLException {
final Table<String, String, String> profilesByLanguageAndName = HashBasedTable.create();
Select selectProfiles = context.prepareSelect("SELECT kee, name, language FROM rules_profiles");