Fix some quality flaws

2 files changed, 13 insertions, 0 deletions

diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/utils/ValidationMessagesTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/utils/ValidationMessagesTest.java
index 7a4e3468362..6217e6d4f1b 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/utils/ValidationMessagesTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/utils/ValidationMessagesTest.java
@@ -40,6 +40,12 @@ public class ValidationMessagesTest {
     verify(logger, never()).error(anyString());
     verify(logger, never()).warn(anyString());
     verify(logger, never()).info(anyString());
+
+    org.slf4j.Logger slf4j = mock(org.slf4j.Logger.class);
+    messages.log(slf4j);
+    verify(slf4j, never()).error(anyString());
+    verify(slf4j, never()).warn(anyString());
+    verify(slf4j, never()).info(anyString());
   }
 
   @Test
@@ -58,5 +64,11 @@ public class ValidationMessagesTest {
     verify(logger, times(1)).error("my error");
     verify(logger, never()).warn(anyString());
     verify(logger, never()).info(anyString());
+
+    org.slf4j.Logger slf4j = mock(org.slf4j.Logger.class);
+    messages.log(slf4j);
+    verify(slf4j, times(1)).error("my error");
+    verify(slf4j, never()).warn(anyString());
+    verify(slf4j, never()).info(anyString());
   }
 }
diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/utils/log/ConsoleFormatterTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/utils/log/ConsoleFormatterTest.java
index 4e2280fe775..834860d7a83 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/utils/log/ConsoleFormatterTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/utils/log/ConsoleFormatterTest.java
@@ -32,6 +32,7 @@ public class ConsoleFormatterTest {
     assertThat(ConsoleFormatter.format("arg: {}", "foo")).isEqualTo("arg: foo");
     assertThat(ConsoleFormatter.format("two args: {} and {}", "foo", 42)).isEqualTo("two args: foo and 42");
     assertThat(ConsoleFormatter.format("args: {}, {} and {}", true, 42, 2L)).isEqualTo("args: true, 42 and 2");
+    assertThat(ConsoleFormatter.format("args: {}, {} and {}", null, null, null)).isEqualTo("args: null, null and null");
   }
 
   @Test