aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-plugin-api
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@sonarsource.com>2016-03-02 10:33:41 +0100
committerSimon Brandhof <simon.brandhof@sonarsource.com>2016-03-02 10:33:57 +0100
commit902099c8dd84d1e3d845caf8a4b4a445b3903439 (patch)
treeb825483a8c3a9d7a43760085f0097dadf6a39397 /sonar-plugin-api
parent03c2d52498daee468d91dde23d079bee5faca375 (diff)
downloadsonarqube-902099c8dd84d1e3d845caf8a4b4a445b3903439.tar.gz
sonarqube-902099c8dd84d1e3d845caf8a4b4a445b3903439.zip
Fix quality flaws
Diffstat (limited to 'sonar-plugin-api')
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java2
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java2
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java2
3 files changed, 3 insertions, 3 deletions
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java
index 2778afe56e9..7f021639917 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java
@@ -171,7 +171,7 @@ public class Checks<C> {
throw new IllegalStateException(String.format("Fail to instantiate class %s for rule %s", checkClassOrInstance, activeRule.ruleKey()), e);
}
- private void configureFields(ActiveRule activeRule, Object check) {
+ private static void configureFields(ActiveRule activeRule, Object check) {
for (Map.Entry<String, String> param : activeRule.params().entrySet()) {
Field field = getField(check, param.getKey());
if (field == null) {
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java b/sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java
index 0bd6997a7dd..be86b62992e 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java
@@ -89,7 +89,7 @@ public final class AnnotationCheckFactory extends CheckFactory {
}
}
- private void configureFields(ActiveRule activeRule, Object check) {
+ private static void configureFields(ActiveRule activeRule, Object check) {
for (ActiveRuleParam param : activeRule.getActiveRuleParams()) {
Field field = getField(check, param.getKey());
if (field == null) {
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java b/sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java
index 404da38046e..fd0df622783 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java
@@ -64,7 +64,7 @@ public final class AnnotationRuleParser {
return null;
}
- private Rule toRule(String repositoryKey, Class clazz, org.sonar.check.Rule ruleAnnotation) {
+ private static Rule toRule(String repositoryKey, Class clazz, org.sonar.check.Rule ruleAnnotation) {
String ruleKey = StringUtils.defaultIfEmpty(ruleAnnotation.key(), clazz.getCanonicalName());
String ruleName = StringUtils.defaultIfEmpty(ruleAnnotation.name(), null);
String description = StringUtils.defaultIfEmpty(ruleAnnotation.description(), null);