summaryrefslogtreecommitdiffstats
path: root/sonar-plugin-api
diff options
context:
space:
mode:
authorJulien HENRY <julien.henry@sonarsource.com>2016-05-12 11:25:03 +0200
committerJulien HENRY <julien.henry@sonarsource.com>2016-05-13 13:46:31 +0200
commit03a0d8af47f6fb3acd5156b133ffbfea9d1d1586 (patch)
tree59229503ba50e379173c21c0c8dbbcef6308b2ae /sonar-plugin-api
parentcadc0c3e861eebce78bcdbf99c30c416ce9c42d2 (diff)
downloadsonarqube-03a0d8af47f6fb3acd5156b133ffbfea9d1d1586.tar.gz
sonarqube-03a0d8af47f6fb3acd5156b133ffbfea9d1d1586.zip
SONAR-7464 Optimize NCLOC_DATA and COMMENT_LINES_DATA
Diffstat (limited to 'sonar-plugin-api')
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/batch/sensor/measure/internal/DefaultMeasure.java2
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/measures/CoreMetrics.java16
2 files changed, 11 insertions, 7 deletions
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/batch/sensor/measure/internal/DefaultMeasure.java b/sonar-plugin-api/src/main/java/org/sonar/api/batch/sensor/measure/internal/DefaultMeasure.java
index a6af74db14c..8be35ac3c95 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/batch/sensor/measure/internal/DefaultMeasure.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/batch/sensor/measure/internal/DefaultMeasure.java
@@ -56,7 +56,7 @@ public class DefaultMeasure<G extends Serializable> extends DefaultStorable impl
@Override
public DefaultMeasure<G> forMetric(Metric<G> metric) {
- Preconditions.checkState(metric != null, "Metric already defined");
+ Preconditions.checkState(this.metric == null, "Metric already defined");
Preconditions.checkNotNull(metric, "metric should be non null");
this.metric = metric;
return this;
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/CoreMetrics.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/CoreMetrics.java
index cd3b57d20f5..dd975732b28 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/CoreMetrics.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/CoreMetrics.java
@@ -429,12 +429,13 @@ public final class CoreMetrics {
.create();
public static final String FILE_COMPLEXITY_DISTRIBUTION_KEY = "file_complexity_distribution";
- public static final Metric<String> FILE_COMPLEXITY_DISTRIBUTION = new Metric.Builder(FILE_COMPLEXITY_DISTRIBUTION_KEY, "Files Distribution / Complexity", Metric.ValueType.DISTRIB)
- .setDescription("Files distribution /complexity")
- .setDirection(Metric.DIRECTION_NONE)
- .setQualitative(true)
- .setDomain(DOMAIN_COMPLEXITY)
- .create();
+ public static final Metric<String> FILE_COMPLEXITY_DISTRIBUTION = new Metric.Builder(FILE_COMPLEXITY_DISTRIBUTION_KEY, "Files Distribution / Complexity",
+ Metric.ValueType.DISTRIB)
+ .setDescription("Files distribution /complexity")
+ .setDirection(Metric.DIRECTION_NONE)
+ .setQualitative(true)
+ .setDomain(DOMAIN_COMPLEXITY)
+ .create();
// --------------------------------------------------------------------------------------------------------------------
//
@@ -2449,6 +2450,7 @@ public final class CoreMetrics {
/**
* Information about lines of code in file.
* Key-value pairs, where key - is a number of line, and value - is an indicator of whether line contains code (1) or not (0).
+ * If a line number is missing in the map it is equivalent to the default value (0).
*
* @see org.sonar.api.measures.FileLinesContext
* @since 2.14
@@ -2466,6 +2468,7 @@ public final class CoreMetrics {
/**
* Information about comments in file.
* Key-value pairs, where key - is a number of line, and value - is an indicator of whether line contains comment (1) or not (0).
+ * If a line number is missing in the map it is equivalent to the default value (0).
*
* @see org.sonar.api.measures.FileLinesContext
* @since 2.14
@@ -2483,6 +2486,7 @@ public final class CoreMetrics {
/**
* Information about executable lines of code in file.
* Key-value pairs, where key - is a number of line, and value - is an indicator of whether line contains executable code (1) or not (0).
+ * If a line number is missing in the map it is equivalent to the default value (0).
*
* @see org.sonar.api.measures.FileLinesContext
* @since 5.5