aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-plugin-api
diff options
context:
space:
mode:
authorJulien HENRY <julien.henry@sonarsource.com>2014-12-17 13:48:56 +0100
committerJulien HENRY <julien.henry@sonarsource.com>2014-12-17 13:48:56 +0100
commit7eceefa3547e97ebcb202ec057c7d16626701bba (patch)
tree1a01cabb0aa639db9cdf305acc4ffb2a2e88f648 /sonar-plugin-api
parent789df9c9ba0ccdf72e5e5ab24de04b47798e4f72 (diff)
downloadsonarqube-7eceefa3547e97ebcb202ec057c7d16626701bba.tar.gz
sonarqube-7eceefa3547e97ebcb202ec057c7d16626701bba.zip
Fix some quality flaws
Diffstat (limited to 'sonar-plugin-api')
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/rules/Rule.java5
-rw-r--r--sonar-plugin-api/src/test/java/org/sonar/api/rules/RuleTest.java11
2 files changed, 11 insertions, 5 deletions
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rules/Rule.java b/sonar-plugin-api/src/main/java/org/sonar/api/rules/Rule.java
index e55f49f6528..6b7f1d79e01 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rules/Rule.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rules/Rule.java
@@ -85,11 +85,6 @@ public class Rule {
*/
private static final Set<String> STATUS_LIST = ImmutableSet.of(STATUS_READY, STATUS_BETA, STATUS_DEPRECATED, STATUS_REMOVED);
- /**
- * @since 4.2
- */
- private static final String[] DEFAULT_TAGS = new String[0];
-
@Id
@Column(name = "id")
@GeneratedValue
diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/rules/RuleTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/rules/RuleTest.java
index b646185d64e..4787c47f3ab 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/rules/RuleTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/rules/RuleTest.java
@@ -101,6 +101,17 @@ public class RuleTest {
assertThat(rule.getStatus()).isEqualTo(Rule.STATUS_READY);
}
+ @Test
+ public void testTags() {
+ Rule rule = Rule.create();
+ assertThat(rule.getTags()).isEmpty();
+ assertThat(rule.getSystemTags()).isEmpty();
+
+ rule.setTags(new String[] {"tag1", "tag2"});
+ assertThat(rule.getTags()).containsOnly("tag1", "tag2");
+ assertThat(rule.getSystemTags()).isEmpty();
+ }
+
private List<String> getExamplesContainingNewLineCharacter() {
return Arrays.asList("te\nst", "te\ns\nt", "te\rst", "te\n\rst", "te\r\nst");
}