SONAR-4908 fix deprecated RuleRepository with empty name

2 files changed, 11 insertions, 2 deletions

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleDefinitions.java b/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleDefinitions.java
index ffcdbca26cf..ffc553ddccc 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleDefinitions.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleDefinitions.java
@@ -155,8 +155,10 @@ public interface RuleDefinitions extends ServerExtension {
     }
 
     @Override
-    public NewRepositoryImpl setName(String s) {
-      this.name = s;
+    public NewRepositoryImpl setName(@Nullable String s) {
+      if (StringUtils.isNotEmpty(s)) {
+        this.name = s;
+      }
       return this;
     }
 
diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/rule/RuleDefinitionsTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/rule/RuleDefinitionsTest.java
index 33b06647c07..9245e4163c3 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/rule/RuleDefinitionsTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/rule/RuleDefinitionsTest.java
@@ -158,6 +158,13 @@ public class RuleDefinitionsTest {
   }
 
   @Test
+  public void cant_set_blank_repository_name() throws Exception {
+    context.newRepository("findbugs", "java").setName(null).done();
+
+    assertThat(context.repository("findbugs").name()).isEqualTo("findbugs");
+  }
+
+  @Test
   public void fail_if_duplicated_repo_keys() {
     context.newRepository("findbugs", "java").done();
     try {