aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-plugin-api
diff options
context:
space:
mode:
authorJulien Lancelot <julien.lancelot@gmail.com>2013-07-01 11:52:30 +0200
committerJulien Lancelot <julien.lancelot@gmail.com>2013-07-01 11:52:30 +0200
commit9eae51614a193b9777685d3728f4cb737477466b (patch)
treef84a8eb5189b10fda62c9b6c627ce1af41407623 /sonar-plugin-api
parenta7931ea4f7d6f6792568756f1cbd228077bc72f9 (diff)
downloadsonarqube-9eae51614a193b9777685d3728f4cb737477466b.tar.gz
sonarqube-9eae51614a193b9777685d3728f4cb737477466b.zip
Deprecate MAX_ISSUE_KEYS in favour of MAX_PAGE_SIZE in issue query
Diffstat (limited to 'sonar-plugin-api')
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/issue/IssueQuery.java10
-rw-r--r--sonar-plugin-api/src/test/java/org/sonar/api/issue/IssueQueryTest.java2
2 files changed, 9 insertions, 3 deletions
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/issue/IssueQuery.java b/sonar-plugin-api/src/main/java/org/sonar/api/issue/IssueQuery.java
index b3fef00fa47..98ebbe94073 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/issue/IssueQuery.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/issue/IssueQuery.java
@@ -27,6 +27,7 @@ import org.sonar.api.web.UserRole;
import javax.annotation.CheckForNull;
import javax.annotation.Nullable;
+
import java.util.Collection;
import java.util.Collections;
import java.util.Date;
@@ -41,7 +42,12 @@ public class IssueQuery {
public static final int DEFAULT_PAGE_SIZE = 100;
public static final int MAX_RESULTS = 10000;
public static final int MAX_PAGE_SIZE = 500;
- public static final int MAX_ISSUE_KEYS = 500;
+
+ /**
+ * @deprecated since 3.7. It's replaced by IssueQuery#MAX_PAGE_SIZE.
+ */
+ @Deprecated
+ public static final int MAX_ISSUE_KEYS = MAX_PAGE_SIZE;
public static final String SORT_BY_CREATION_DATE = "CREATION_DATE";
public static final String SORT_BY_UPDATE_DATE = "UPDATE_DATE";
@@ -343,7 +349,7 @@ public class IssueQuery {
initPageIndex();
initPageSize();
if (issueKeys != null) {
- Preconditions.checkArgument(issueKeys.size() <= MAX_ISSUE_KEYS, "Number of issue keys must be less than " + MAX_ISSUE_KEYS + " (got " + issueKeys.size() + ")");
+ Preconditions.checkArgument(issueKeys.size() <= MAX_PAGE_SIZE, "Number of issue keys must be less than " + MAX_PAGE_SIZE + " (got " + issueKeys.size() + ")");
}
return new IssueQuery(this);
}
diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/issue/IssueQueryTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/issue/IssueQueryTest.java
index dc7c459e8f3..35ddc491194 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/issue/IssueQueryTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/issue/IssueQueryTest.java
@@ -199,7 +199,7 @@ public class IssueQueryTest {
@Test
public void number_of_issue_keys_should_be_limited() throws Exception {
List<String> issueKeys = newArrayList();
- for (int i=0; i<IssueQuery.MAX_ISSUE_KEYS+1; i++) {
+ for (int i=0; i<IssueQuery.MAX_PAGE_SIZE+1; i++) {
issueKeys.add("issue-key-"+ i);
}
try {