aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-scanner-engine
diff options
context:
space:
mode:
authorBelen Pruvost <belen.pruvost@sonarsource.com>2021-04-29 14:30:56 +0200
committersonartech <sonartech@sonarsource.com>2021-04-29 20:03:32 +0000
commit12ff4a12bc6613cd17d02c3c4b6f7de469a07ffe (patch)
treeddd4c50b0f38d021992fc30d21debfe255031ecb /sonar-scanner-engine
parentca4bbea8375d754cb5cfb37a6cd046ca6d038434 (diff)
downloadsonarqube-12ff4a12bc6613cd17d02c3c4b6f7de469a07ffe.tar.gz
sonarqube-12ff4a12bc6613cd17d02c3c4b6f7de469a07ffe.zip
SONAR-14750 - Add link to warning + update doc
Diffstat (limited to 'sonar-scanner-engine')
-rw-r--r--sonar-scanner-engine/src/main/java/org/sonar/scanner/scm/DefaultBlameOutput.java3
-rw-r--r--sonar-scanner-engine/src/main/java/org/sonar/scm/git/GitScmProvider.java6
-rw-r--r--sonar-scanner-engine/src/test/java/org/sonar/scanner/scm/DefaultBlameOutputTest.java3
-rw-r--r--sonar-scanner-engine/src/test/java/org/sonar/scm/git/GitScmProviderTest.java3
4 files changed, 10 insertions, 5 deletions
diff --git a/sonar-scanner-engine/src/main/java/org/sonar/scanner/scm/DefaultBlameOutput.java b/sonar-scanner-engine/src/main/java/org/sonar/scanner/scm/DefaultBlameOutput.java
index 3e0aa880a61..9a7381826bc 100644
--- a/sonar-scanner-engine/src/main/java/org/sonar/scanner/scm/DefaultBlameOutput.java
+++ b/sonar-scanner-engine/src/main/java/org/sonar/scanner/scm/DefaultBlameOutput.java
@@ -134,7 +134,8 @@ class DefaultBlameOutput implements BlameOutput {
LOG.warn(" * " + f);
}
LOG.warn("This may lead to missing/broken features in SonarQube");
- analysisWarnings.addUnique(String.format("Missing blame information for %d %s. This may lead to some features not working correctly. Please check the analysis logs.",
+ analysisWarnings.addUnique(String.format("Missing blame information for %d %s. This may lead to some features not working correctly. " +
+ "Please check the analysis logs and refer to <a href=\"/documentation/analysis/scm-integration/\" target=\"_blank\">the documentation</a>.",
allFilesToBlame.size(),
allFilesToBlame.size() > 1 ? "files" : "file"));
}
diff --git a/sonar-scanner-engine/src/main/java/org/sonar/scm/git/GitScmProvider.java b/sonar-scanner-engine/src/main/java/org/sonar/scm/git/GitScmProvider.java
index 9f3419eee26..8342668300f 100644
--- a/sonar-scanner-engine/src/main/java/org/sonar/scm/git/GitScmProvider.java
+++ b/sonar-scanner-engine/src/main/java/org/sonar/scm/git/GitScmProvider.java
@@ -105,7 +105,8 @@ public class GitScmProvider extends ScmProvider {
if (targetRef == null) {
analysisWarnings.addUnique(String.format(COULD_NOT_FIND_REF
+ ". You may see unexpected issues and changes. "
- + "Please make sure to fetch this ref before pull request analysis.", targetBranchName));
+ + "Please make sure to fetch this ref before pull request analysis and refer to"
+ + " <a href=\"/documentation/analysis/scm-integration/\" target=\"_blank\">the documentation</a>.", targetBranchName));
return null;
}
@@ -149,7 +150,8 @@ public class GitScmProvider extends ScmProvider {
if (targetRef == null) {
analysisWarnings.addUnique(String.format(COULD_NOT_FIND_REF
+ ". You may see unexpected issues and changes. "
- + "Please make sure to fetch this ref before pull request analysis.", targetBranchName));
+ + "Please make sure to fetch this ref before pull request analysis"
+ + " and refer to <a href=\"/documentation/analysis/scm-integration/\" target=\"_blank\">the documentation</a>.", targetBranchName));
return null;
}
diff --git a/sonar-scanner-engine/src/test/java/org/sonar/scanner/scm/DefaultBlameOutputTest.java b/sonar-scanner-engine/src/test/java/org/sonar/scanner/scm/DefaultBlameOutputTest.java
index 135da7d0799..21ba297db5e 100644
--- a/sonar-scanner-engine/src/test/java/org/sonar/scanner/scm/DefaultBlameOutputTest.java
+++ b/sonar-scanner-engine/src/test/java/org/sonar/scanner/scm/DefaultBlameOutputTest.java
@@ -53,7 +53,8 @@ public class DefaultBlameOutputTest {
new DefaultBlameOutput(null, analysisWarnings, singletonList(file)).finish(true);
assertThat(analysisWarnings.warnings()).extracting(DefaultAnalysisWarnings.Message::getText)
- .containsOnly("Missing blame information for 1 file. This may lead to some features not working correctly. Please check the analysis logs.");
+ .containsOnly("Missing blame information for 1 file. This may lead to some features not working correctly. " +
+ "Please check the analysis logs and refer to <a href=\"/documentation/analysis/scm-integration/\" target=\"_blank\">the documentation</a>.");
}
@Test
diff --git a/sonar-scanner-engine/src/test/java/org/sonar/scm/git/GitScmProviderTest.java b/sonar-scanner-engine/src/test/java/org/sonar/scm/git/GitScmProviderTest.java
index f4501a19768..8f603f32b08 100644
--- a/sonar-scanner-engine/src/test/java/org/sonar/scm/git/GitScmProviderTest.java
+++ b/sonar-scanner-engine/src/test/java/org/sonar/scm/git/GitScmProviderTest.java
@@ -609,7 +609,8 @@ public class GitScmProviderTest {
assertThat(warnLog.getRawMsg()).isEqualTo(refNotFound);
String warning = refNotFound
- + ". You may see unexpected issues and changes. Please make sure to fetch this ref before pull request analysis.";
+ + ". You may see unexpected issues and changes. Please make sure to fetch this ref before pull request analysis"
+ + " and refer to <a href=\"/documentation/analysis/scm-integration/\" target=\"_blank\">the documentation</a>.";
verify(analysisWarnings).addUnique(warning);
}