SONAR-4303 Refactor the issue detail in the issues code viewer

1 files changed, 14 insertions, 8 deletions

diff --git a/sonar-server/src/main/webapp/javascripts/application.js b/sonar-server/src/main/webapp/javascripts/application.js
index cb408cd7c4d..c9598890583 100644
--- a/sonar-server/src/main/webapp/javascripts/application.js
+++ b/sonar-server/src/main/webapp/javascripts/application.js
@@ -425,9 +425,8 @@ function expandAccordionItem(elt) {
 var currentlyDisplayedDropdownMenu;
 
 var hideCurrentDropdownMenu = function () {
-  menu = $j('#' + currentlyDisplayedDropdownMenu);
-  if (menu) {
-    menu.hide();
+  if (currentlyDisplayedDropdownMenu) {
+    currentlyDisplayedDropdownMenu.hide();
   }
   $j(document).unbind('mouseup', hideCurrentDropdownMenu);
 }
@@ -447,14 +446,21 @@ var clickOnDropdownMenuLink = function (event) {
 }
 
 function showDropdownMenu(menuId) {
-  if (menuId == currentlyDisplayedDropdownMenu) {
+  showDropdownMenuOnElement($j('#' + menuId));
+}
+
+function showDropdownMenuOnElement(elt) {
+  var dropdownElt = $j(elt);
+  var dropdownChildren = dropdownElt.children('li');
+
+  if (dropdownElt == currentlyDisplayedDropdownMenu) {
     currentlyDisplayedDropdownMenu = "";
   } else {
-    currentlyDisplayedDropdownMenu = menuId;
+    currentlyDisplayedDropdownMenu = dropdownElt;
     $j(document).mouseup(hideCurrentDropdownMenu);
-    $j('#' + currentlyDisplayedDropdownMenu + ' li').unbind('click');
-    $j('#' + currentlyDisplayedDropdownMenu + ' li').click(clickOnDropdownMenuLink);
-    $j('#' + currentlyDisplayedDropdownMenu).show();
+    dropdownChildren.unbind('click');
+    dropdownChildren.click(clickOnDropdownMenuLink);
+    dropdownElt.show();
   }
 }