aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-server/src/main
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@gmail.com>2011-07-21 17:18:05 +0200
committerSimon Brandhof <simon.brandhof@gmail.com>2011-07-21 17:18:13 +0200
commit5637dd8a4bac8ecc03df4da56e5112ce31d498f5 (patch)
treedb203bfa63c3685faaacd66bfc470e078f8c7165 /sonar-server/src/main
parent0cc5a607a16d081e160ae2f9ac7d9e7db9141e01 (diff)
downloadsonarqube-5637dd8a4bac8ecc03df4da56e5112ce31d498f5.tar.gz
sonarqube-5637dd8a4bac8ecc03df4da56e5112ce31d498f5.zip
SONAR-2547 fix breadcrumb of manual measures
Diffstat (limited to 'sonar-server/src/main')
-rw-r--r--sonar-server/src/main/webapp/WEB-INF/app/controllers/manual_measures_controller.rb8
-rw-r--r--sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb2
-rw-r--r--sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/index.html.erb6
-rw-r--r--sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/new.html.erb6
4 files changed, 11 insertions, 11 deletions
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/manual_measures_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/manual_measures_controller.rb
index f2a9c564f21..255a436722a 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/manual_measures_controller.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/manual_measures_controller.rb
@@ -48,22 +48,22 @@ class ManualMeasuresController < ApplicationController
measure.description = params[:desc]
measure.save!
if (params[:redirect_to_new]=='true')
- redirect_to :action => 'new', :resource => params[:resource]
+ redirect_to :action => 'new', :id => params[:id]
else
- redirect_to :action => 'index', :resource => params[:resource], :metric => params[:metric]
+ redirect_to :action => 'index', :id => params[:id], :metric => params[:metric]
end
end
def delete
metric=Metric.by_key(params[:metric])
ManualMeasure.destroy_all(['resource_id=? and metric_id=?', @resource.id, metric.id])
- redirect_to :action => 'index', :resource => params[:resource], :metric => params[:metric]
+ redirect_to :action => 'index', :id => params[:id], :metric => params[:metric]
end
private
def load_resource
- @resource=Project.by_key(params[:resource])
+ @resource=Project.by_key(params[:id])
return redirect_to home_path unless @resource
return access_denied unless has_role?(:admin, @resource)
@snapshot=@resource.last_snapshot
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb
index 33aefe64b41..70f1a4f0cc7 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_layout.html.erb
@@ -50,7 +50,7 @@
<% end %>
<% if has_role?(:admin, @project) %>
<li class="h2"><%= message('sidebar.project_system') -%></li>
- <li class="<%= 'selected' if request.request_uri.include?('/manual_measures') -%>"><a href="<%= ApplicationController.root_context -%>/manual_measures?resource=<%= @project.id -%>"><%= message('manual_measures.page') -%></a></li>
+ <li class="<%= 'selected' if request.request_uri.include?('/manual_measures') -%>"><a href="<%= ApplicationController.root_context -%>/manual_measures/index/<%= @project.id -%>"><%= message('manual_measures.page') -%></a></li>
<% if (@project.project? || @project.module?) %>
<li class="<%= 'selected' if request.request_uri.include?('/project/settings') -%>"><a href="<%= ApplicationController.root_context -%>/project/settings/<%= @project.id -%>"><%= message('project_settings.page') -%></a></li>
<% end %>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/index.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/index.html.erb
index af436a04946..0b19dcd646b 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/index.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/index.html.erb
@@ -14,7 +14,7 @@
<ul class="operations">
<li class="last">
<%= image_tag 'add.png' -%>
- <a href="<%= ApplicationController.root_context -%>/manual_measures/new?resource=<%= @resource.id -%>" id="addMeasureLink">Add measure</a>
+ <a href="<%= ApplicationController.root_context -%>/manual_measures/new/<%= @resource.id -%>" id="addMeasureLink">Add measure</a>
</li>
</ul>
</div>
@@ -56,8 +56,8 @@
<%= l(measure.updated_at) -%>
</td>
<td class="thin nowrap">
- <a href="<%= url_for :controller => 'manual_measures', :action => 'new', :metric => measure.metric.key, :resource => @resource.key -%>">Edit</a>
- <%= link_to 'Delete', {:action => 'delete', :metric => measure.metric.key, :resource => @resource.id}, {:method => 'POST', :confirm => "This measure will be deleted during next project analysis", :class => 'action'} -%>
+ <a href="<%= url_for :controller => 'manual_measures', :action => 'new', :metric => measure.metric.key, :id => @resource.id -%>">Edit</a>
+ <%= link_to 'Delete', {:action => 'delete', :metric => measure.metric.key, :id => @resource.id}, {:method => 'POST', :confirm => "This measure will be deleted during next project analysis", :class => 'action'} -%>
</td>
</tr>
<% end %>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/new.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/new.html.erb
index 4dc0ef8e3bb..5492e84df4c 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/new.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/manual_measures/new.html.erb
@@ -1,6 +1,6 @@
<script type="text/javascript">
function changeMetric() {
- document.location = '<%= ApplicationController.root_context-%>/manual_measures/new?resource=<%= @resource.key -%>&metric=' + $('metricSelect').getValue();
+ document.location = '<%= ApplicationController.root_context-%>/manual_measures/new/<%= @resource.id -%>?metric=' + $('metricSelect').getValue();
return false;
}
function saveAndAddNew() {
@@ -10,7 +10,7 @@
</script>
<form action="<%= url_for :action => (@measure ? 'save' : 'new') -%>" method="POST" id="createForm">
- <input type="hidden" name="resource" value="<%= @resource.id -%>"/>
+ <input type="hidden" name="id" value="<%= @resource.id -%>"/>
<table class="width100 form">
<tbody>
<tr>
@@ -69,7 +69,7 @@
<input type="submit" value="Save"/>
<input type="submit" value="Save & Add new" onclick="saveAndAddNew()"/>
<% end %>
- <%= link_to 'Cancel', :action => 'index', :resource => @resource.key -%>
+ <%= link_to 'Cancel', :action => 'index', :id => @resource.id -%>
</td>
</tr>
</tbody>