diff options
author | Evgeny Mandrikov <mandrikov@gmail.com> | 2012-03-14 10:10:31 +0400 |
---|---|---|
committer | Evgeny Mandrikov <mandrikov@gmail.com> | 2012-03-14 10:11:51 +0400 |
commit | 7e83fc767544821bd204d3b70f602e88cf61d25a (patch) | |
tree | 39b4a03fa27776133103c891d6f6801bc7c7ced5 /sonar-server/src | |
parent | abb8bac7ab3717b32adea21fa58d20adb6ea7499 (diff) | |
download | sonarqube-7e83fc767544821bd204d3b70f602e88cf61d25a.tar.gz sonarqube-7e83fc767544821bd204d3b70f602e88cf61d25a.zip |
Fix quality flaws in tests: remove unused imports
Diffstat (limited to 'sonar-server/src')
5 files changed, 6 insertions, 20 deletions
diff --git a/sonar-server/src/test/java/org/sonar/server/configuration/BackupTest.java b/sonar-server/src/test/java/org/sonar/server/configuration/BackupTest.java index 83ad7087b5f..13ac73eb6eb 100644 --- a/sonar-server/src/test/java/org/sonar/server/configuration/BackupTest.java +++ b/sonar-server/src/test/java/org/sonar/server/configuration/BackupTest.java @@ -25,7 +25,6 @@ import org.apache.commons.io.IOUtils; import org.apache.commons.lang.CharEncoding; import org.custommonkey.xmlunit.Diff; import org.custommonkey.xmlunit.XMLUnit; -import org.hamcrest.Matchers; import org.junit.Test; import org.sonar.api.database.DatabaseSession; import org.sonar.api.database.configuration.Property; @@ -43,10 +42,7 @@ import java.util.*; import static org.hamcrest.Matchers.is; import static org.hamcrest.Matchers.nullValue; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertNotNull; -import static org.junit.Assert.assertThat; -import static org.junit.Assert.assertTrue; +import static org.junit.Assert.*; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.verify; diff --git a/sonar-server/src/test/java/org/sonar/server/configuration/InheritedProfilesTest.java b/sonar-server/src/test/java/org/sonar/server/configuration/InheritedProfilesTest.java index c83aad75cd0..8674f421d4a 100644 --- a/sonar-server/src/test/java/org/sonar/server/configuration/InheritedProfilesTest.java +++ b/sonar-server/src/test/java/org/sonar/server/configuration/InheritedProfilesTest.java @@ -22,7 +22,6 @@ package org.sonar.server.configuration; import org.junit.Before; import org.junit.Test; import org.sonar.api.profiles.RulesProfile; -import org.sonar.api.utils.ValidationMessages; import org.sonar.jpa.test.AbstractDbUnitTestCase; import static org.hamcrest.Matchers.is; diff --git a/sonar-server/src/test/java/org/sonar/server/configuration/PropertiesBackupTest.java b/sonar-server/src/test/java/org/sonar/server/configuration/PropertiesBackupTest.java index 6a67d6f359b..1a71aba251e 100644 --- a/sonar-server/src/test/java/org/sonar/server/configuration/PropertiesBackupTest.java +++ b/sonar-server/src/test/java/org/sonar/server/configuration/PropertiesBackupTest.java @@ -30,7 +30,6 @@ import org.sonar.test.TestUtils; import java.util.Arrays; import java.util.Collection; -import java.util.List; import static org.hamcrest.Matchers.endsWith; import static org.hamcrest.Matchers.startsWith; diff --git a/sonar-server/src/test/java/org/sonar/server/configuration/RuleChangeTest.java b/sonar-server/src/test/java/org/sonar/server/configuration/RuleChangeTest.java index c0ece24bf48..1b501ee5d22 100644 --- a/sonar-server/src/test/java/org/sonar/server/configuration/RuleChangeTest.java +++ b/sonar-server/src/test/java/org/sonar/server/configuration/RuleChangeTest.java @@ -19,16 +19,11 @@ */ package org.sonar.server.configuration; -import org.sonar.api.rules.RulePriority; - import org.junit.Before; import org.junit.Test; +import org.sonar.api.rules.RulePriority; import org.sonar.jpa.test.AbstractDbUnitTestCase; -import static org.hamcrest.Matchers.is; -import static org.hamcrest.Matchers.nullValue; -import static org.junit.Assert.assertThat; - public class RuleChangeTest extends AbstractDbUnitTestCase { private ProfilesManager profilesManager; @@ -71,21 +66,21 @@ public class RuleChangeTest extends AbstractDbUnitTestCase { profilesManager.ruleParamChanged(2, 3, "param1", "20", "30", "admin"); checkTablesWithExcludedColumns("ruleParamChanged", new String[]{"change_date"}, "active_rule_changes", "active_rule_param_changes"); } - + @Test public void testRuleSeverityChanged() { setupData("initialData"); profilesManager.ruleSeverityChanged(2, 3, RulePriority.BLOCKER, RulePriority.CRITICAL, "admin"); checkTablesWithExcludedColumns("ruleSeverityChanged", new String[]{"change_date"}, "active_rule_changes"); } - + @Test public void testRuleReverted() { setupData("ruleReverted"); profilesManager.revert(2, 3, "admin"); checkTablesWithExcludedColumns("ruleReverted", new String[]{"change_date"}, "active_rule_changes", "active_rule_param_changes"); } - + @Test public void testChangeParentProfile() { setupData("changeParentProfile"); diff --git a/sonar-server/src/test/java/org/sonar/server/filters/DateCriterionTest.java b/sonar-server/src/test/java/org/sonar/server/filters/DateCriterionTest.java index 59734a00d98..0a30afe4b1b 100644 --- a/sonar-server/src/test/java/org/sonar/server/filters/DateCriterionTest.java +++ b/sonar-server/src/test/java/org/sonar/server/filters/DateCriterionTest.java @@ -27,11 +27,8 @@ import java.util.Date; import static org.hamcrest.CoreMatchers.is; import static org.junit.Assert.assertThat; -import static org.junit.Assert.assertTrue; public class DateCriterionTest { - private static final int DAYS = 24 * 60 * 60 * 1000; - @Test public void ignoreTime() throws ParseException { DateCriterion criterion = new DateCriterion().setDate(3); @@ -39,7 +36,7 @@ public class DateCriterionTest { assertThat(date.getHours(), is(0)); assertThat(date.getMinutes(), is(0)); } - + @Test public void testDaysAgo() throws ParseException { DateCriterion criterion = new DateCriterion().setDate(3); |