SONAR-3242 Add pointer cursor on image

+ improve some code

5 files changed, 16 insertions, 12 deletions

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_assign_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_assign_form.html.erb
index 0c61e721d68..efeca053752 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_assign_form.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_assign_form.html.erb
@@ -24,7 +24,7 @@
                        :update => "review",
                        :before => assignee_check_script -%>
    
-  <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+  <%= image_tag 'sep12.png' -%>
   &nbsp;
   <%= button_to_remote message('reviews.assign_to_me_submit'),
                        {
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/resource/_create_violation_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/resource/_create_violation_form.html.erb
index 9c9c5ea911f..1e6da007a2c 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/resource/_create_violation_form.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/resource/_create_violation_form.html.erb
@@ -27,7 +27,7 @@
                 <% end %>
               </select>
               &nbsp;
-              <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+              <%= image_tag 'sep12.png' -%>
               &nbsp;
               <select id="select-rule-<%= @html_id -%>" name="rule" onkeyup="this.blur();this.focus();" onchange="if ($F(this)=='') {$('new_rule_<%= @html_id -%>').show()} else {$('new_rule_<%= @html_id -%>').hide()}">
                 <% is_admin = current_user && has_role?(:admin)
@@ -49,7 +49,7 @@
               <% end %>
 
               &nbsp;
-              <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+              <%= image_tag 'sep12.png' -%>
               &nbsp;
               Assign to: <%= user_autocomplete_field "assignee_login", current_user.login -%>
             </div>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/resource/_violation.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/resource/_violation.html.erb
index afd11c3d8ce..a45f05d58f2 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/resource/_violation.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/resource/_violation.html.erb
@@ -13,13 +13,13 @@
         <img src="<%= ApplicationController.root_context -%>/images/priority/<%= violation.failure_level -%>.png">
       <% end %>
       &nbsp;
-      <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+      <%= image_tag 'sep12.png' -%>
       &nbsp;
       <span class="rulename">
         <a onclick="window.open(this.href,'rule','height=800,width=900,scrollbars=1,resizable=1');return false;" href="<%= url_for :controller => 'rules', :action => 'show', :id => violation.rule.key, :layout => 'false' -%>"><%= h(violation.rule.name) -%></a>
       </span>
       &nbsp;
-      <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+      <%= image_tag 'sep12.png' -%>
       &nbsp;
 
       <% if violation.created_at %>
@@ -27,25 +27,25 @@
         &nbsp;
       <% end %>
       <% if violation.switched_off? %>
-        <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+        <%= image_tag 'sep12.png' -%>
         &nbsp;
         <span class="falsePositive"><%= message('false_positive') -%></span>
         &nbsp;
       <% end %>
       <% if violation.review && violation.review.resolved? %>
-        <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+        <%= image_tag 'sep12.png' -%>
         &nbsp;
         <span class="reviewResolved"><%= message('reviews.status.RESOLVED') -%></span>
         &nbsp;
       <% end %>
       <% if violation.review && violation.review.assignee_id %>
-        <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+        <%= image_tag 'sep12.png' -%>
         &nbsp;
         <%= message('assigned_to') -%> <%= h(violation.review.assignee.name) -%>
         &nbsp;
       <% end %>
       <% if violation.review && violation.review.planned? %>
-        <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+        <%= image_tag 'sep12.png' -%>
         &nbsp;
         <%= message('reviews.planned_for_x', :params => h(violation.review.action_plan.name)) -%>
         &nbsp;
@@ -57,7 +57,7 @@
       <div id="vMsg<%= violation.id -%>">
         
         <% if current_user %>
-          <img src="<%= ApplicationController.root_context -%>/images/actions.png" onclick="$('vActions<%= violation.id -%>').toggle();">
+          <img src="<%= ApplicationController.root_context -%>/images/actions.png" onclick="$('vActions<%= violation.id -%>').toggle();" class="pop-menu-icon">
           <div style="display: none" class="popup-menu" id="vActions<%= violation.id -%>" onmouseout="this.hide();"  onmouseover="this.show();">
               <ul>
                 <li><%= link_to_function message('reviews.comment'), "sCF(#{violation.id})", :name => 'bComment' -%></li>
@@ -106,7 +106,7 @@
             <% if is_last_comment && current_user %>
       <span class="actions" id="commentActions<%= violation.id -%>">
         &nbsp;&nbsp;
-        <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+        <%= image_tag 'sep12.png' -%>
         &nbsp;
         <%
            if current_user.id == review_comment.user_id
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_assign_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_assign_form.html.erb
index de7f925f6ba..60fcd8ffce6 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_assign_form.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_assign_form.html.erb
@@ -25,7 +25,7 @@
                        :update => "vId" + params[:id],
                        :before => assignee_check_script -%>
   &nbsp;
-  <img src="<%= ApplicationController.root_context -%>/images/sep12.png">
+  <%= image_tag 'sep12.png' -%>
   &nbsp;
   <%= button_to_remote message('reviews.assign_to_me_submit'),
                        {
diff --git a/sonar-server/src/main/webapp/stylesheets/style.css b/sonar-server/src/main/webapp/stylesheets/style.css
index 9aad013c58e..8070830abcf 100644
--- a/sonar-server/src/main/webapp/stylesheets/style.css
+++ b/sonar-server/src/main/webapp/stylesheets/style.css
@@ -419,6 +419,10 @@ button[disabled], .button[disabled], input[type="submit"][disabled], input[type=
   cursor: default;
 }
 
+.pop-menu-icon {
+  cursor: pointer;
+}
+
 .popup-menu {
   background-clip: padding-box;
   background-color: #FFFFFF;