diff options
author | Fabrice Bellingard <bellingard@gmail.com> | 2012-04-10 10:24:29 +0200 |
---|---|---|
committer | Fabrice Bellingard <bellingard@gmail.com> | 2012-04-10 10:24:29 +0200 |
commit | 7effa4cf5ef1c02f5cecfdeccd8ba3c20e77fd0b (patch) | |
tree | 9c817a20c2ac45e93b5b495b2c16e53af358aa16 /sonar-ws-client | |
parent | a8614fdb0f491e6dfa955395399b6670b3e5bbfe (diff) | |
download | sonarqube-7effa4cf5ef1c02f5cecfdeccd8ba3c20e77fd0b.tar.gz sonarqube-7effa4cf5ef1c02f5cecfdeccd8ba3c20e77fd0b.zip |
SONAR-3278 Revert back the review search by 'id' on WS
- As previous versions of the Java WS Client used this parameter (and
in turn Sonar Eclipse too)
- But keep it undocumented as it is deprecated
- And update the Java WS Client to not use 'id' anymore but 'ids'
Diffstat (limited to 'sonar-ws-client')
-rw-r--r-- | sonar-ws-client/src/main/java/org/sonar/wsclient/services/ReviewQuery.java | 2 | ||||
-rw-r--r-- | sonar-ws-client/src/test/java/org/sonar/wsclient/services/ReviewQueryTest.java | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ReviewQuery.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ReviewQuery.java index 81d3cc850b0..da420c118a9 100644 --- a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ReviewQuery.java +++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ReviewQuery.java @@ -267,7 +267,7 @@ public class ReviewQuery extends Query<Review> { StringBuilder url = new StringBuilder(BASE_URL); url.append('?'); if (id != null) { - appendUrlParameter(url, "id", id); + appendUrlParameter(url, "ids", id); } else if (ids != null) { appendUrlParameter(url, "ids", ids); } diff --git a/sonar-ws-client/src/test/java/org/sonar/wsclient/services/ReviewQueryTest.java b/sonar-ws-client/src/test/java/org/sonar/wsclient/services/ReviewQueryTest.java index 5632b29c79a..0186f0ec468 100644 --- a/sonar-ws-client/src/test/java/org/sonar/wsclient/services/ReviewQueryTest.java +++ b/sonar-ws-client/src/test/java/org/sonar/wsclient/services/ReviewQueryTest.java @@ -39,7 +39,7 @@ public class ReviewQueryTest extends QueryTestCase { @Test public void queryById() { - assertThat(new ReviewQuery().setId(13L).getUrl(), is("/api/reviews?id=13&")); + assertThat(new ReviewQuery().setId(13L).getUrl(), is("/api/reviews?ids=13&")); assertThat(new ReviewQuery().setIds(10L, 11L).getUrl(), is("/api/reviews?ids=10,11&")); } |