aboutsummaryrefslogtreecommitdiffstats
path: root/sonar-ws-client
diff options
context:
space:
mode:
authorJulien Lancelot <julien.lancelot@gmail.com>2013-05-14 09:49:40 +0200
committerJulien Lancelot <julien.lancelot@gmail.com>2013-05-14 09:49:40 +0200
commitcc72a7cef34b9cc1739ef20d0be8a320a7af18ba (patch)
tree8e9cbe78d63cf67bc52cbf02e2e2b7c9770f1a6d /sonar-ws-client
parentc433a59aba73a56218ba8a2356844554da1794fc (diff)
downloadsonarqube-cc72a7cef34b9cc1739ef20d0be8a320a7af18ba.tar.gz
sonarqube-cc72a7cef34b9cc1739ef20d0be8a320a7af18ba.zip
SONAR-4282 Remove useless show ws action
Diffstat (limited to 'sonar-ws-client')
-rw-r--r--sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlan.java3
-rw-r--r--sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlanClient.java2
-rw-r--r--sonar-ws-client/src/main/java/org/sonar/wsclient/issue/DefaultActionPlanClient.java9
-rw-r--r--sonar-ws-client/src/test/java/org/sonar/wsclient/issue/DefaultActionPlanClientTest.java31
4 files changed, 2 insertions, 43 deletions
diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlan.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlan.java
index 1c0853408ef..84c03ac0589 100644
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlan.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlan.java
@@ -81,13 +81,14 @@ public class ActionPlan {
return JsonUtils.getDateTime(json, "updatedAt");
}
+ @CheckForNull
public Integer totalIssues() {
return JsonUtils.getInteger(json, "totalIssues");
}
+ @CheckForNull
public Integer openIssues() {
return JsonUtils.getInteger(json, "openIssues");
}
-
}
diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlanClient.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlanClient.java
index e4e0e1c1e7b..d535e75bad1 100644
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlanClient.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/ActionPlanClient.java
@@ -28,8 +28,6 @@ public interface ActionPlanClient {
List<ActionPlan> find(String projectKey);
- ActionPlan get(String actionPlanKey);
-
ActionPlan create(NewActionPlan newActionPlan);
ActionPlan update(UpdateActionPlan updateActionPlan);
diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/DefaultActionPlanClient.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/DefaultActionPlanClient.java
index eccdf5038f5..651800edeff 100644
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/DefaultActionPlanClient.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/DefaultActionPlanClient.java
@@ -61,15 +61,6 @@ public class DefaultActionPlanClient implements ActionPlanClient {
}
@Override
- public ActionPlan get(String actionPlanKey) {
- HttpRequest request = requestFactory.get("/api/action_plans/show", EncodingUtils.toMap("key", actionPlanKey));
- if (!request.ok()) {
- throw new IllegalStateException("Fail to search action plan. Bad HTTP response status: " + request.code());
- }
- return createActionPlanResult(request);
- }
-
- @Override
public ActionPlan create(NewActionPlan newActionPlan) {
HttpRequest request = requestFactory.post(NewActionPlan.BASE_URL, newActionPlan.urlParams());
if (!request.ok()) {
diff --git a/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/DefaultActionPlanClientTest.java b/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/DefaultActionPlanClientTest.java
index 6b56706c8de..34fc84b3695 100644
--- a/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/DefaultActionPlanClientTest.java
+++ b/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/DefaultActionPlanClientTest.java
@@ -68,37 +68,6 @@ public class DefaultActionPlanClientTest {
}
@Test
- public void should_find_action_plan() {
- HttpRequestFactory requestFactory = new HttpRequestFactory(httpServer.url(), null, null);
- httpServer.doReturnBody("{\"actionPlan\": {\"key\": \"382f6f2e-ad9d-424a-b973-9b065e04348a\",\n" +
- "\"name\": \"Long term\",\n" +
- "\"status\": \"CLOSED\",\n" +
- "\"project\": \"com.sonarsource.it.samples:simple-sample\",\n" +
- "\"userLogin\": \"admin\",\n" +
- "\"deadLine\": \"2013-05-30T00:00:00+0200\",\n" +
- "\"totalIssues\": 0,\n" +
- "\"openIssues\": 0,\n" +
- "\"createdAt\": \"2013-05-13T12:50:29+0200\",\n" +
- "\"updatedAt\": \"2013-05-13T12:50:44+0200\"}}");
-
- ActionPlanClient client = new DefaultActionPlanClient(requestFactory);
- ActionPlan actionPlan = client.get("382f6f2e-ad9d-424a-b973-9b065e04348a");
-
- assertThat(httpServer.requestedPath()).isEqualTo("/api/action_plans/show?key=382f6f2e-ad9d-424a-b973-9b065e04348a");
- assertThat(actionPlan).isNotNull();
- assertThat(actionPlan.key()).isEqualTo("382f6f2e-ad9d-424a-b973-9b065e04348a");
- assertThat(actionPlan.name()).isEqualTo("Long term");
- assertThat(actionPlan.project()).isEqualTo("com.sonarsource.it.samples:simple-sample");
- assertThat(actionPlan.status()).isEqualTo("CLOSED");
- assertThat(actionPlan.userLogin()).isEqualTo("admin");
- assertThat(actionPlan.deadLine()).isNotNull();
- assertThat(actionPlan.totalIssues()).isEqualTo(0);
- assertThat(actionPlan.openIssues()).isEqualTo(0);
- assertThat(actionPlan.createdAt()).isNotNull();
- assertThat(actionPlan.updatedAt()).isNotNull();
- }
-
- @Test
public void should_create_action_plan() {
HttpRequestFactory requestFactory = new HttpRequestFactory(httpServer.url(), null, null);
httpServer.doReturnBody("{\"actionPlan\": {\"key\": \"382f6f2e-ad9d-424a-b973-9b065e04348a\"}}");