diff options
author | Simon Brandhof <simon.brandhof@sonarsource.com> | 2018-01-10 21:14:52 +0100 |
---|---|---|
committer | Simon Brandhof <simon.brandhof@sonarsource.com> | 2018-01-14 20:37:37 +0100 |
commit | d55f047c445daf698ccde5f0af9d0669804c818b (patch) | |
tree | 990d01ddad6fd40aff012e1f40bfc8ce77918670 /tests | |
parent | 4a5be9fbaba0b9729e909eec935852c56f6e71e2 (diff) | |
download | sonarqube-d55f047c445daf698ccde5f0af9d0669804c818b.tar.gz sonarqube-d55f047c445daf698ccde5f0af9d0669804c818b.zip |
Cleanup code based on Intellij inspections
Diffstat (limited to 'tests')
90 files changed, 195 insertions, 196 deletions
diff --git a/tests/plugins/fake-governance-plugin/src/main/java/ce/ws/BombActivatorAction.java b/tests/plugins/fake-governance-plugin/src/main/java/ce/ws/BombActivatorAction.java index 207661f5ada..31be2ce3bc1 100644 --- a/tests/plugins/fake-governance-plugin/src/main/java/ce/ws/BombActivatorAction.java +++ b/tests/plugins/fake-governance-plugin/src/main/java/ce/ws/BombActivatorAction.java @@ -48,7 +48,7 @@ public class BombActivatorAction implements FakeGoVWsAction { } @Override - public void handle(Request request, Response response) throws Exception { + public void handle(Request request, Response response) { BombType bombType = BombType.valueOf(request.mandatoryParam(PARAM_BOMB_TYPE)); bombConfig.reset(); diff --git a/tests/plugins/fake-governance-plugin/src/main/java/ce/ws/SubmitAction.java b/tests/plugins/fake-governance-plugin/src/main/java/ce/ws/SubmitAction.java index 35744e5ef5b..fb47686044e 100644 --- a/tests/plugins/fake-governance-plugin/src/main/java/ce/ws/SubmitAction.java +++ b/tests/plugins/fake-governance-plugin/src/main/java/ce/ws/SubmitAction.java @@ -46,7 +46,7 @@ public class SubmitAction implements FakeGoVWsAction { } @Override - public void handle(Request request, Response response) throws Exception { + public void handle(Request request, Response response) { String type = request.mandatoryParam(PARAM_TYPE); CeTaskSubmit.Builder submit = ceQueue.prepareSubmit(); diff --git a/tests/plugins/fake-governance-plugin/src/main/java/systemPasscode/SystemPasscodeWebService.java b/tests/plugins/fake-governance-plugin/src/main/java/systemPasscode/SystemPasscodeWebService.java index ee87f516af1..b1682ae6656 100644 --- a/tests/plugins/fake-governance-plugin/src/main/java/systemPasscode/SystemPasscodeWebService.java +++ b/tests/plugins/fake-governance-plugin/src/main/java/systemPasscode/SystemPasscodeWebService.java @@ -41,7 +41,7 @@ public class SystemPasscodeWebService implements WebService, RequestHandler { } @Override - public void handle(Request request, Response response) throws Exception { + public void handle(Request request, Response response) { if (!passcode.isValid(request)) { response.stream().setStatus(HttpURLConnection.HTTP_UNAUTHORIZED); } diff --git a/tests/plugins/fake-governance-plugin/src/main/java/workerCount/RefreshWorkerCountAction.java b/tests/plugins/fake-governance-plugin/src/main/java/workerCount/RefreshWorkerCountAction.java index 61ad50dcc9b..df37590a2ab 100644 --- a/tests/plugins/fake-governance-plugin/src/main/java/workerCount/RefreshWorkerCountAction.java +++ b/tests/plugins/fake-governance-plugin/src/main/java/workerCount/RefreshWorkerCountAction.java @@ -54,7 +54,7 @@ public class RefreshWorkerCountAction implements CeWsAction { } @Override - public void handle(Request request, Response response) throws Exception { + public void handle(Request request, Response response) { String count = request.getParam(PARAM_COUNT).getValue(); try (DbSession dbSession = dbClient.openSession(false)) { dbClient.propertiesDao().saveProperty(new PropertyDto() diff --git a/tests/plugins/ws-plugin/src/main/java/LocalCallWebService.java b/tests/plugins/ws-plugin/src/main/java/LocalCallWebService.java index dd579ad552a..dfd39e39876 100644 --- a/tests/plugins/ws-plugin/src/main/java/LocalCallWebService.java +++ b/tests/plugins/ws-plugin/src/main/java/LocalCallWebService.java @@ -47,7 +47,7 @@ public final class LocalCallWebService implements WebService { private class ProtobufHandler implements RequestHandler { @Override - public void handle(Request request, Response response) throws Exception { + public void handle(Request request, Response response) { WsClient client = wsClientFactory.newClient(request.localConnector()); Ce.TaskTypesWsResponse ceTaskTypes = client.ce().taskTypes(); @@ -57,7 +57,7 @@ public final class LocalCallWebService implements WebService { private class JsonHandler implements RequestHandler { @Override - public void handle(Request request, Response response) throws Exception { + public void handle(Request request, Response response) { WsClient client = wsClientFactory.newClient(request.localConnector()); WsResponse jsonResponse = client.wsConnector().call(new GetRequest("api/issues/search")); @@ -70,7 +70,7 @@ public final class LocalCallWebService implements WebService { private class RequirePermissionHandler implements RequestHandler { @Override - public void handle(Request request, Response response) throws Exception { + public void handle(Request request, Response response) { WsClient client = wsClientFactory.newClient(request.localConnector()); WsResponse jsonResponse = client.wsConnector().call(new GetRequest("api/system/info")); diff --git a/tests/src/test/java/org/sonarqube/tests/analysis/IssueJsonReportTest.java b/tests/src/test/java/org/sonarqube/tests/analysis/IssueJsonReportTest.java index 9fb93047d78..0e4b7ea4311 100644 --- a/tests/src/test/java/org/sonarqube/tests/analysis/IssueJsonReportTest.java +++ b/tests/src/test/java/org/sonarqube/tests/analysis/IssueJsonReportTest.java @@ -64,7 +64,7 @@ public class IssueJsonReportTest { public Tester tester = new Tester(orchestrator).disableOrganizations(); @Test - public void issue_line() throws IOException { + public void issue_line() { ItUtils.restoreProfile(orchestrator, getClass().getResource(RESOURCE_PATH + "one-issue-per-line.xml")); orchestrator.getServer().provisionProject("sample", "xoo-sample"); orchestrator.getServer().associateProjectToQualityProfile("sample", "xoo", "one-issue-per-line"); @@ -98,7 +98,7 @@ public class IssueJsonReportTest { } @Test - public void precise_issue_location() throws IOException { + public void precise_issue_location() { ItUtils.restoreProfile(orchestrator, getClass().getResource(RESOURCE_PATH + "multiline.xml")); orchestrator.getServer().provisionProject("sample-multiline", "xoo-sample"); orchestrator.getServer().associateProjectToQualityProfile("sample-multiline", "xoo", "multiline"); @@ -299,7 +299,7 @@ public class IssueJsonReportTest { return ItUtils.sanitizeTimezones(s); } - private InputStream getResourceInputStream(String resource) throws FileNotFoundException { + private InputStream getResourceInputStream(String resource) { ResourceLocation res = getResource(resource); return getClass().getResourceAsStream(res.getPath()); } diff --git a/tests/src/test/java/org/sonarqube/tests/analysis/PermissionTest.java b/tests/src/test/java/org/sonarqube/tests/analysis/PermissionTest.java index d94a2ede2d0..c12a62753eb 100644 --- a/tests/src/test/java/org/sonarqube/tests/analysis/PermissionTest.java +++ b/tests/src/test/java/org/sonarqube/tests/analysis/PermissionTest.java @@ -69,7 +69,7 @@ public class PermissionTest { } @After - public void tearDown() throws Exception { + public void tearDown() { resetSettings(orchestrator, null, "sonar.forceAuthentication"); userRule.resetUsers(); } @@ -136,7 +136,7 @@ public class PermissionTest { } @Test - public void run_scanner_with_user_having_scan_permission_only_on_project() throws Exception { + public void run_scanner_with_user_having_scan_permission_only_on_project() { userRule.createUser(A_LOGIN, A_PASSWORD); orchestrator.getServer().provisionProject("sample", "sample"); addUserPermission(A_LOGIN, "scan", "sample"); diff --git a/tests/src/test/java/org/sonarqube/tests/analysis/ReportDumpTest.java b/tests/src/test/java/org/sonarqube/tests/analysis/ReportDumpTest.java index 72612cd369e..fec08c0d410 100644 --- a/tests/src/test/java/org/sonarqube/tests/analysis/ReportDumpTest.java +++ b/tests/src/test/java/org/sonarqube/tests/analysis/ReportDumpTest.java @@ -64,7 +64,7 @@ public class ReportDumpTest { verifyUrl(props.getProperty("ceTaskUrl")); } - private void verifyUrl(String url) throws IOException { + private void verifyUrl(String url) { HttpResponse response = orchestrator.getServer().newHttpCall(url).execute(); assertThat(response.isSuccessful()).as(url).isTrue(); assertThat(response.getBodyAsString()).as(url).isNotEmpty(); diff --git a/tests/src/test/java/org/sonarqube/tests/analysis/ScannerTest.java b/tests/src/test/java/org/sonarqube/tests/analysis/ScannerTest.java index b4174c117c3..0fa0f7093e7 100644 --- a/tests/src/test/java/org/sonarqube/tests/analysis/ScannerTest.java +++ b/tests/src/test/java/org/sonarqube/tests/analysis/ScannerTest.java @@ -277,7 +277,7 @@ public class ScannerTest { * SONAR-4239 */ @Test - public void should_display_project_url_after_analysis() throws IOException { + public void should_display_project_url_after_analysis() { orchestrator.getServer().provisionProject("com.sonarsource.it.samples:multi-modules-sample", "Sonar :: Integration Tests :: Multi-modules Sample"); orchestrator.getServer().associateProjectToQualityProfile("com.sonarsource.it.samples:multi-modules-sample", "xoo", "one-issue-per-line"); @@ -341,7 +341,7 @@ public class ScannerTest { * SONAR-4547 */ @Test - public void display_MessageException_without_stacktrace() throws Exception { + public void display_MessageException_without_stacktrace() { orchestrator.getServer().provisionProject("sample", "xoo-sample"); orchestrator.getServer().associateProjectToQualityProfile("sample", "xoo", "one-issue-per-line"); BuildResult result = scanQuietly("shared/xoo-sample", "raiseMessageException", "true"); @@ -358,7 +358,7 @@ public class ScannerTest { * SONAR-4751 */ @Test - public void file_extensions_are_case_insensitive() throws Exception { + public void file_extensions_are_case_insensitive() { orchestrator.getServer().provisionProject("case-sensitive-file-extensions", "Case Sensitive"); orchestrator.getServer().associateProjectToQualityProfile("case-sensitive-file-extensions", "xoo", "one-issue-per-line"); scan("analysis/case-sensitive-file-extensions"); diff --git a/tests/src/test/java/org/sonarqube/tests/analysis/SettingsEncryptionTest.java b/tests/src/test/java/org/sonarqube/tests/analysis/SettingsEncryptionTest.java index 5135bcb5ab2..ee8005fab35 100644 --- a/tests/src/test/java/org/sonarqube/tests/analysis/SettingsEncryptionTest.java +++ b/tests/src/test/java/org/sonarqube/tests/analysis/SettingsEncryptionTest.java @@ -69,7 +69,7 @@ public class SettingsEncryptionTest { * SONAR-2084 */ @Test(expected = BuildFailureException.class) - public void failIfEncryptedPropertyButNoSecretKey() throws Exception { + public void failIfEncryptedPropertyButNoSecretKey() { // path to secret key is missing SonarScanner build = SonarScanner.create(ItUtils.projectDir("shared/xoo-sample")) .setProperty("encryptedProperty", "{aes}9mx5Zq4JVyjeChTcVjEide4kWCwusFl7P2dSVXtg9IY="); diff --git a/tests/src/test/java/org/sonarqube/tests/authorization/ExecuteAnalysisPermissionTest.java b/tests/src/test/java/org/sonarqube/tests/authorization/ExecuteAnalysisPermissionTest.java index 0283c51b7c9..1ac1788f026 100644 --- a/tests/src/test/java/org/sonarqube/tests/authorization/ExecuteAnalysisPermissionTest.java +++ b/tests/src/test/java/org/sonarqube/tests/authorization/ExecuteAnalysisPermissionTest.java @@ -65,7 +65,7 @@ public class ExecuteAnalysisPermissionTest { } @Test - public void should_fail_if_logged_but_no_scan_permission() throws Exception { + public void should_fail_if_logged_but_no_scan_permission() { executeLoggedAnalysis(); removeGlobalPermission("anyone", "scan"); @@ -90,7 +90,7 @@ public class ExecuteAnalysisPermissionTest { } @Test - public void no_need_for_browse_permission_to_scan() throws Exception { + public void no_need_for_browse_permission_to_scan() { // Do a first analysis, no error executeAnonymousAnalysis(); @@ -102,7 +102,7 @@ public class ExecuteAnalysisPermissionTest { } @Test - public void execute_analysis_with_scan_permission_only_on_project() throws Exception { + public void execute_analysis_with_scan_permission_only_on_project() { removeGlobalPermission("anyone", "scan"); addProjectPermission("anyone", PROJECT_KEY, "scan"); diff --git a/tests/src/test/java/org/sonarqube/tests/authorization/ProvisioningPermissionTest.java b/tests/src/test/java/org/sonarqube/tests/authorization/ProvisioningPermissionTest.java index 565d0f8f6ce..fdd652018e4 100644 --- a/tests/src/test/java/org/sonarqube/tests/authorization/ProvisioningPermissionTest.java +++ b/tests/src/test/java/org/sonarqube/tests/authorization/ProvisioningPermissionTest.java @@ -76,7 +76,7 @@ public class ProvisioningPermissionTest { } @AfterClass - public static void restoreData() throws Exception { + public static void restoreData() { tester.wsClient().permissions().addGroup(new AddGroupRequest().setGroupName("anyone").setPermission("provisioning")); } diff --git a/tests/src/test/java/org/sonarqube/tests/ce/BackgroundTasksTest.java b/tests/src/test/java/org/sonarqube/tests/ce/BackgroundTasksTest.java index c6e38d7331c..05b297bee45 100644 --- a/tests/src/test/java/org/sonarqube/tests/ce/BackgroundTasksTest.java +++ b/tests/src/test/java/org/sonarqube/tests/ce/BackgroundTasksTest.java @@ -66,7 +66,7 @@ public class BackgroundTasksTest { } @Test - public void should_not_display_failing_and_search_and_filter_elements_on_project_level_page() throws Exception { + public void should_not_display_failing_and_search_and_filter_elements_on_project_level_page() { runSelenese(ORCHESTRATOR, "/projectAdministration/BackgroundTasksTest/should_not_display_failing_and_search_and_filter_elements_on_project_level_page.html"); } diff --git a/tests/src/test/java/org/sonarqube/tests/ce/CeShutdownTest.java b/tests/src/test/java/org/sonarqube/tests/ce/CeShutdownTest.java index 9fd1c285409..1193f9e1008 100644 --- a/tests/src/test/java/org/sonarqube/tests/ce/CeShutdownTest.java +++ b/tests/src/test/java/org/sonarqube/tests/ce/CeShutdownTest.java @@ -133,7 +133,7 @@ public class CeShutdownTest { return logsTailer; } - void triggerTask() throws InterruptedException { + void triggerTask() { orchestrator.executeBuild(SonarScanner.create(new File("projects/shared/xoo-sample"), "sonar.projectKey", "foo"), false); } @@ -145,11 +145,11 @@ public class CeShutdownTest { return adminWsClient.ce().activityStatus(new ActivityStatusRequest()).getInProgress(); } - boolean hasTaskFinishedSuccessfully() throws Exception { + boolean hasTaskFinishedSuccessfully() { return content.hasLineMatching(Pattern.compile(".* INFO .*Executed task \\| project=foo \\| type=REPORT.*")); } - boolean hasErrorLogs() throws IOException { + boolean hasErrorLogs() { return content.hasText(" ERROR "); } @@ -163,7 +163,7 @@ public class CeShutdownTest { } @Override - public void close() throws Exception { + public void close() { if (stopper != null) { stopper.interrupt(); } diff --git a/tests/src/test/java/org/sonarqube/tests/ce/CeWorkersTest.java b/tests/src/test/java/org/sonarqube/tests/ce/CeWorkersTest.java index 5a170e84bae..82453df03d6 100644 --- a/tests/src/test/java/org/sonarqube/tests/ce/CeWorkersTest.java +++ b/tests/src/test/java/org/sonarqube/tests/ce/CeWorkersTest.java @@ -174,7 +174,7 @@ public class CeWorkersTest { } @Test - public void ce_worker_is_resilient_to_OOM_and_RuntimeException_when_starting_or_stopping_analysis_report_container() throws IOException { + public void ce_worker_is_resilient_to_OOM_and_RuntimeException_when_starting_or_stopping_analysis_report_container() { int initSuccessReportTaskCount = adminWsClient.ce().activity(new ActivityRequest() .setType("REPORT") .setStatus(ImmutableList.of("SUCCESS"))) diff --git a/tests/src/test/java/org/sonarqube/tests/ce/ReportFailureNotificationTest.java b/tests/src/test/java/org/sonarqube/tests/ce/ReportFailureNotificationTest.java index 8063f386bed..d28a0ff8273 100644 --- a/tests/src/test/java/org/sonarqube/tests/ce/ReportFailureNotificationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/ce/ReportFailureNotificationTest.java @@ -67,7 +67,7 @@ public class ReportFailureNotificationTest { private static Wiser smtpServer; @BeforeClass - public static void before() throws Exception { + public static void before() { smtpServer = new Wiser(0); smtpServer.start(); System.out.println("SMTP Server port: " + smtpServer.getServer().getPort()); @@ -81,7 +81,7 @@ public class ReportFailureNotificationTest { } @Before - public void prepare() throws Exception { + public void prepare() { tester.settings().setGlobalSettings( "email.smtp_host.secured", smtpServer.getServer().getHostName(), "email.smtp_port.secured", valueOf(smtpServer.getServer().getPort())); diff --git a/tests/src/test/java/org/sonarqube/tests/duplication/CrossModuleDuplicationsTest.java b/tests/src/test/java/org/sonarqube/tests/duplication/CrossModuleDuplicationsTest.java index 21e708c4f75..eb3ede64201 100644 --- a/tests/src/test/java/org/sonarqube/tests/duplication/CrossModuleDuplicationsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/duplication/CrossModuleDuplicationsTest.java @@ -60,7 +60,7 @@ public class CrossModuleDuplicationsTest { } @Test - public void testDuplications() throws IOException { + public void testDuplications() { analyzeProject(projectDir, PROJECT_KEY, true); verifyDuplicationMeasures(PROJECT_KEY, 2, 54, 2, 56.3); @@ -94,7 +94,7 @@ public class CrossModuleDuplicationsTest { @Test // SONAR-6184 - public void testDuplicationFix() throws IOException { + public void testDuplicationFix() { analyzeProject(projectDir, PROJECT_KEY, true); verifyDuplicationMeasures(PROJECT_KEY + ":module1", 1, 27, 1, 45); diff --git a/tests/src/test/java/org/sonarqube/tests/duplication/CrossProjectDuplicationsTest.java b/tests/src/test/java/org/sonarqube/tests/duplication/CrossProjectDuplicationsTest.java index a6c3670fe59..3b6e1947ee4 100644 --- a/tests/src/test/java/org/sonarqube/tests/duplication/CrossProjectDuplicationsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/duplication/CrossProjectDuplicationsTest.java @@ -79,12 +79,12 @@ public class CrossProjectDuplicationsTest { } @Test - public void origin_project_has_no_duplication_as_it_has_not_been_analyzed_twice() throws Exception { + public void origin_project_has_no_duplication_as_it_has_not_been_analyzed_twice() { assertProjectHasNoDuplication(ORIGIN_PROJECT); } @Test - public void duplicate_project_has_duplication_as_it_has_been_analyzed_twice() throws Exception { + public void duplicate_project_has_duplication_as_it_has_been_analyzed_twice() { Map<String, Double> measures = getMeasuresAsDoubleByMetricKey(orchestrator, DUPLICATE_PROJECT, "duplicated_lines", "duplicated_blocks", "duplicated_files", "duplicated_lines_density"); assertThat(measures.get("duplicated_lines").intValue()).isEqualTo(27); assertThat(measures.get("duplicated_blocks").intValue()).isEqualTo(1); @@ -93,7 +93,7 @@ public class CrossProjectDuplicationsTest { } @Test - public void issue_on_duplicated_blocks_is_generated_on_file() throws Exception { + public void issue_on_duplicated_blocks_is_generated_on_file() { assertThat(issueRule.search(new SearchRequest().setComponentKeys(singletonList(DUPLICATE_FILE)).setRules(singletonList("common-xoo:DuplicatedBlocks"))).getIssuesList()) .hasSize(1); } @@ -109,17 +109,17 @@ public class CrossProjectDuplicationsTest { } @Test - public void project_with_branch_has_no_duplication() throws Exception { + public void project_with_branch_has_no_duplication() { assertProjectHasNoDuplication(DUPLICATE_PROJECT + ":" + BRANCH); } @Test - public void project_with_exclusion_has_no_duplication() throws Exception { + public void project_with_exclusion_has_no_duplication() { assertProjectHasNoDuplication(PROJECT_WITH_EXCLUSION); } @Test - public void project_without_enough_tokens_has_duplication() throws Exception { + public void project_without_enough_tokens_has_duplication() { assertProjectHasNoDuplication(PROJECT_WITHOUT_ENOUGH_TOKENS); } diff --git a/tests/src/test/java/org/sonarqube/tests/duplication/DuplicationsTest.java b/tests/src/test/java/org/sonarqube/tests/duplication/DuplicationsTest.java index 951f72e8d84..30394a1e29b 100644 --- a/tests/src/test/java/org/sonarqube/tests/duplication/DuplicationsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/duplication/DuplicationsTest.java @@ -152,7 +152,7 @@ public class DuplicationsTest { } @Test - public void issues_on_duplicated_blocks_are_generated_on_each_file() throws Exception { + public void issues_on_duplicated_blocks_are_generated_on_each_file() { assertThat(issueRule.search(new SearchRequest().setRules(singletonList("common-xoo:DuplicatedBlocks"))).getIssuesList()).hasSize(13); } diff --git a/tests/src/test/java/org/sonarqube/tests/duplication/NewDuplicationsTest.java b/tests/src/test/java/org/sonarqube/tests/duplication/NewDuplicationsTest.java index 4517db89523..1fe1967a100 100644 --- a/tests/src/test/java/org/sonarqube/tests/duplication/NewDuplicationsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/duplication/NewDuplicationsTest.java @@ -56,7 +56,7 @@ public class NewDuplicationsTest { } @Test - public void new_duplications_on_project() throws Exception { + public void new_duplications_on_project() { Map<String, Measures.Measure> measures = getMeasures("new-duplications"); assertThat(parseDouble(measures.get("new_lines").getPeriods().getPeriodsValue(0).getValue())).isEqualTo(83d, DEFAULT_OFFSET); assertThat(parseDouble(measures.get("new_duplicated_lines").getPeriods().getPeriodsValue(0).getValue())).isEqualTo(71d, DEFAULT_OFFSET); @@ -65,7 +65,7 @@ public class NewDuplicationsTest { } @Test - public void new_duplications_on_directory() throws Exception { + public void new_duplications_on_directory() { Map<String, Measures.Measure> measures = getMeasures("new-duplications:src/main/xoo/duplicated_lines_with_other_dir1"); assertThat(parseDouble(measures.get("new_lines").getPeriods().getPeriodsValue(0).getValue())).isEqualTo(24d, DEFAULT_OFFSET); assertThat(parseDouble(measures.get("new_duplicated_lines").getPeriods().getPeriodsValue(0).getValue())).isEqualTo(24d, DEFAULT_OFFSET); @@ -74,7 +74,7 @@ public class NewDuplicationsTest { } @Test - public void new_duplications_on_file() throws Exception { + public void new_duplications_on_file() { Map<String, Measures.Measure> measures = getMeasures("new-duplications:src/main/xoo/duplicated_lines_within_same_file/DuplicatedLinesInSameFile.xoo"); assertThat(parseDouble(measures.get("new_lines").getPeriods().getPeriodsValue(0).getValue())).isEqualTo(41d, DEFAULT_OFFSET); assertThat(parseDouble(measures.get("new_duplicated_lines").getPeriods().getPeriodsValue(0).getValue())).isEqualTo(29d, DEFAULT_OFFSET); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/AutoAssignTest.java b/tests/src/test/java/org/sonarqube/tests/issue/AutoAssignTest.java index 53a9cf063c7..258ef9b92f3 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/AutoAssignTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/AutoAssignTest.java @@ -60,7 +60,7 @@ public class AutoAssignTest extends AbstractIssueTest { } @After - public void resetData() throws Exception { + public void resetData() { newAdminWsClient(ORCHESTRATOR).wsConnector().call(new PostRequest("api/projects/delete").setParam("project", "AutoAssignTest")); deleteAllUsers(); @@ -69,7 +69,7 @@ public class AutoAssignTest extends AbstractIssueTest { } @Test - public void auto_assign_issues_to_user() throws Exception { + public void auto_assign_issues_to_user() { // verify that login matches, case-sensitive createUser("user1", "User 1", "user1@email.com"); createUser("USER2", "User 2", "user2@email.com"); @@ -109,7 +109,7 @@ public class AutoAssignTest extends AbstractIssueTest { } @Test - public void auto_assign_issues_to_default_assignee() throws Exception { + public void auto_assign_issues_to_default_assignee() { createUser("user1", "User 1", "user1@email.com"); createUser("user2", "User 2", "user2@email.com"); setServerProperty(ORCHESTRATOR, "sonar.issues.defaultAssigneeLogin", "user2"); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/CustomRulesTest.java b/tests/src/test/java/org/sonarqube/tests/issue/CustomRulesTest.java index 0d9c2ea1d0d..470768aa2b4 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/CustomRulesTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/CustomRulesTest.java @@ -45,7 +45,7 @@ public class CustomRulesTest extends AbstractIssueTest { } @Test - public void analyzeProjectWithCustomRules() throws Exception { + public void analyzeProjectWithCustomRules() { ORCHESTRATOR.getServer().adminWsClient().post("api/rules/create", "template_key", "xoo:TemplateRule", "custom_key", "MyCustomRule", diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueActionTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueActionTest.java index 5f24cf0a48f..4fbbb0f10ad 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueActionTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueActionTest.java @@ -66,12 +66,12 @@ public class IssueActionTest extends AbstractIssueTest { } @Test - public void no_comments_by_default() throws Exception { + public void no_comments_by_default() { assertThat(randomIssue.getComments().getCommentsList()).isEmpty(); } @Test - public void add_comment() throws Exception { + public void add_comment() { Issues.Comment comment = issuesService.addComment(new AddCommentRequest().setIssue(randomIssue.getKey()).setText("this is my *comment*")).getIssue().getComments().getComments(0); assertThat(comment.getKey()).isNotNull(); assertThat(comment.getHtmlText()).isEqualTo("this is my <strong>comment</strong>"); @@ -90,7 +90,7 @@ public class IssueActionTest extends AbstractIssueTest { * SONAR-4450 */ @Test - public void should_reject_blank_comment() throws Exception { + public void should_reject_blank_comment() { try { issuesService.addComment(new AddCommentRequest().setIssue(randomIssue.getKey()).setText(" ")); fail(); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueBulkChangeTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueBulkChangeTest.java index 73c468504b0..6d412a237a2 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueBulkChangeTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueBulkChangeTest.java @@ -68,7 +68,7 @@ public class IssueBulkChangeTest extends AbstractIssueTest { private ProjectAnalysis xooSampleLittleIssuesAnalysis; @Before - public void setUp() throws Exception { + public void setUp() { String qualityProfileKey = projectAnalysisRule.registerProfile("/issue/IssueBulkChangeTest/one-issue-per-line-profile.xml"); String projectKey = projectAnalysisRule.registerProject("shared/xoo-sample"); this.xooSampleLittleIssuesAnalysis = projectAnalysisRule.newProjectAnalysis(projectKey) diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueChangelogTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueChangelogTest.java index 70c868604c1..42321b9eeb1 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueChangelogTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueChangelogTest.java @@ -48,7 +48,7 @@ public class IssueChangelogTest extends AbstractIssueTest { } @Test - public void update_changelog_when_assigning_issue_by_user() throws Exception { + public void update_changelog_when_assigning_issue_by_user() { runProjectAnalysis(ORCHESTRATOR, "shared/xoo-sample"); Issue issue = searchRandomIssue(); assertIssueHasNoChange(issue.key()); @@ -66,7 +66,7 @@ public class IssueChangelogTest extends AbstractIssueTest { } @Test - public void update_changelog_when_reopening_unresolved_issue_by_scan() throws Exception { + public void update_changelog_when_reopening_unresolved_issue_by_scan() { runProjectAnalysis(ORCHESTRATOR, "shared/xoo-sample"); Issue issue = searchRandomIssue(); assertIssueHasNoChange(issue.key()); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDatePluginChangedTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDatePluginChangedTest.java index 02b550b2dc4..6ad7158a0f6 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDatePluginChangedTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDatePluginChangedTest.java @@ -81,13 +81,13 @@ public class IssueCreationDatePluginChangedTest { private static Wiser smtpServer; @BeforeClass - public static void setUp() throws Exception { + public static void setUp() { smtpServer = new Wiser(0); smtpServer.start(); } @Before - public void before() throws InterruptedException, MessagingException, IOException { + public void before() { ORCHESTRATOR.resetData(); // Configure Sonar @@ -117,7 +117,7 @@ public class IssueCreationDatePluginChangedTest { } @Test - public void should_use_scm_date_for_new_issues_if_plugin_updated() throws InterruptedException, MessagingException, IOException { + public void should_use_scm_date_for_new_issues_if_plugin_updated() throws InterruptedException { ItUtils.restoreProfile(ORCHESTRATOR, getClass().getResource("/issue/IssueCreationDatePluginChangedTest/profile.xml")); ORCHESTRATOR.getServer().provisionProject(SAMPLE_PROJECT_KEY, SAMPLE_PROJECT_NAME); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDateQPChangedTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDateQPChangedTest.java index 3412d51ecec..30c3e101ce3 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDateQPChangedTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationDateQPChangedTest.java @@ -243,7 +243,7 @@ public class IssueCreationDateQPChangedTest extends AbstractIssueTest { private final String path; - private SourceCode(String path) { + SourceCode(String path) { this.path = path; } } @@ -256,7 +256,7 @@ public class IssueCreationDateQPChangedTest extends AbstractIssueTest { ; private final String key; - private Component(String key) { + Component(String key) { this.key = key; } @@ -275,7 +275,7 @@ public class IssueCreationDateQPChangedTest extends AbstractIssueTest { private final String path; - private QProfile(String path) { + QProfile(String path) { this.path = path; } } @@ -343,11 +343,11 @@ public class IssueCreationDateQPChangedTest extends AbstractIssueTest { private final Date date; - private IssueCreationDate() { + IssueCreationDate() { this.date = null; } - private IssueCreationDate(Date date) { + IssueCreationDate(Date date) { this.date = date; } diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationTest.java index f38ae5843e5..e369330a291 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueCreationTest.java @@ -61,7 +61,7 @@ public class IssueCreationTest extends AbstractIssueTest { } @Test - public void plugin_can_override_profile_severity() throws Exception { + public void plugin_can_override_profile_severity() { ORCHESTRATOR.getServer().provisionProject(SAMPLE_PROJECT_KEY, SAMPLE_PROJECT_KEY); // The rule "OneBlockerIssuePerFile" is enabled with severity "INFO" diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueFilterExtensionTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueFilterExtensionTest.java index 877a3a69666..357ee749083 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueFilterExtensionTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueFilterExtensionTest.java @@ -49,7 +49,7 @@ public class IssueFilterExtensionTest extends AbstractIssueTest { .withQualityProfile(manyRuleProfileKey); @Test - public void should_filter_files() throws Exception { + public void should_filter_files() { analysis.withProperties("sonar.exclusions", "**/HelloA1.xoo").run(); List<Issue> issues = searchIssues(); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueNotificationsTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueNotificationsTest.java index f99f5cd83a9..cf98015fc8d 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueNotificationsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueNotificationsTest.java @@ -118,7 +118,7 @@ public class IssueNotificationsTest { } @After - public void after() throws Exception { + public void after() { clearSmtpMessages(); } diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueSearchTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueSearchTest.java index 0f2d03d7aac..1063e708c74 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueSearchTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueSearchTest.java @@ -80,7 +80,7 @@ public class IssueSearchTest extends AbstractIssueTest { } @Before - public void resetProperties() throws Exception { + public void resetProperties() { setServerProperty(ORCHESTRATOR, "sonar.forceAuthentication", "false"); } @@ -241,7 +241,7 @@ public class IssueSearchTest extends AbstractIssueTest { } @Test - public void return_issue_type() throws Exception { + public void return_issue_type() { SearchWsResponse issues = searchResponse(r -> r.setRules(singletonList("xoo:OneBugIssuePerLine"))); assertThat(issues.getIssuesList()).isNotEmpty(); org.sonarqube.ws.Issues.Issue issue = issues.getIssues(0); @@ -259,7 +259,7 @@ public class IssueSearchTest extends AbstractIssueTest { } @Test - public void search_issues_by_types() throws IOException { + public void search_issues_by_types() { assertThat(searchResponse(r -> r.setTypes(singletonList("CODE_SMELL"))).getPaging().getTotal()).isEqualTo(142); assertThat(searchResponse(r -> r.setTypes(singletonList("BUG"))).getPaging().getTotal()).isEqualTo(106); assertThat(searchResponse(r -> r.setTypes(singletonList("VULNERABILITY"))).getPaging().getTotal()).isEqualTo(8); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueTrackingTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueTrackingTest.java index a6583fab886..b2d6c76c155 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueTrackingTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueTrackingTest.java @@ -56,7 +56,7 @@ public class IssueTrackingTest extends AbstractIssueTest { } @Test - public void close_issues_on_removed_components() throws Exception { + public void close_issues_on_removed_components() { ORCHESTRATOR.getServer().associateProjectToQualityProfile(SAMPLE_PROJECT_KEY, "xoo", "issue-on-tag-foobar"); // version 1 @@ -81,7 +81,7 @@ public class IssueTrackingTest extends AbstractIssueTest { * SONAR-3072 */ @Test - public void track_issues_based_on_blocks_recognition() throws Exception { + public void track_issues_based_on_blocks_recognition() { ORCHESTRATOR.getServer().associateProjectToQualityProfile(SAMPLE_PROJECT_KEY, "xoo", "issue-on-tag-foobar"); // version 1 @@ -112,7 +112,7 @@ public class IssueTrackingTest extends AbstractIssueTest { * SONAR-4310 */ @Test - public void track_existing_unchanged_issues_on_module() throws Exception { + public void track_existing_unchanged_issues_on_module() { // The custom rule on module is enabled ORCHESTRATOR.getServer().associateProjectToQualityProfile(SAMPLE_PROJECT_KEY, "xoo", "one-issue-per-module"); @@ -139,7 +139,7 @@ public class IssueTrackingTest extends AbstractIssueTest { * SONAR-4310 */ @Test - public void track_existing_unchanged_issues_on_multi_modules() throws Exception { + public void track_existing_unchanged_issues_on_multi_modules() { // The custom rule on module is enabled ORCHESTRATOR.getServer().provisionProject("com.sonarsource.it.samples:multi-modules-sample", "com.sonarsource.it.samples:multi-modules-sample"); ORCHESTRATOR.getServer().associateProjectToQualityProfile("com.sonarsource.it.samples:multi-modules-sample", "xoo", "one-issue-per-module"); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/IssueWorkflowTest.java b/tests/src/test/java/org/sonarqube/tests/issue/IssueWorkflowTest.java index 5c620a9608c..0a96279adc2 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/IssueWorkflowTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/IssueWorkflowTest.java @@ -72,7 +72,7 @@ public class IssueWorkflowTest extends AbstractIssueTest { * be CLOSED with resolution REMOVED */ @Test - public void issue_is_closed_as_removed_when_rule_is_disabled() throws Exception { + public void issue_is_closed_as_removed_when_rule_is_disabled() { SearchRequest ruleSearchRequest = new SearchRequest().setRules(singletonList("xoo:OneIssuePerLine")); List<Issue> issues = issueRule.search(ruleSearchRequest).getIssuesList(); assertThat(issues).isNotEmpty(); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssueAssignTest.java b/tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssueAssignTest.java index 5154ce9133b..4e76ba14180 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssueAssignTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssueAssignTest.java @@ -65,7 +65,7 @@ public class OrganizationIssueAssignTest { private User user; @Before - public void setUp() throws Exception { + public void setUp() { org1 = tester.organizations().generate(); org2 = tester.organizations().generate(); user = tester.users().generate(); diff --git a/tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssuesPageTest.java b/tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssuesPageTest.java index a5f51dcd2b1..64a162edc7e 100644 --- a/tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssuesPageTest.java +++ b/tests/src/test/java/org/sonarqube/tests/issue/OrganizationIssuesPageTest.java @@ -51,7 +51,7 @@ public class OrganizationIssuesPageTest { private Users.CreateWsResponse.User user2; @Before - public void setUp() throws Exception { + public void setUp() { org1 = tester.organizations().generate(); org2 = tester.organizations().generate(); user1 = tester.users().generate(); diff --git a/tests/src/test/java/org/sonarqube/tests/marketplace/UpdateCenterTest.java b/tests/src/test/java/org/sonarqube/tests/marketplace/UpdateCenterTest.java index 64e0006edf4..e1c851aaae1 100644 --- a/tests/src/test/java/org/sonarqube/tests/marketplace/UpdateCenterTest.java +++ b/tests/src/test/java/org/sonarqube/tests/marketplace/UpdateCenterTest.java @@ -47,7 +47,7 @@ public class UpdateCenterTest { private Navigation nav = Navigation.create(orchestrator); @After - public void tearDown() throws Exception { + public void tearDown() { userRule.resetUsers(); } diff --git a/tests/src/test/java/org/sonarqube/tests/measure/DifferentialPeriodsTest.java b/tests/src/test/java/org/sonarqube/tests/measure/DifferentialPeriodsTest.java index f6f605cb863..65aa3e7c804 100644 --- a/tests/src/test/java/org/sonarqube/tests/measure/DifferentialPeriodsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/measure/DifferentialPeriodsTest.java @@ -49,7 +49,7 @@ public class DifferentialPeriodsTest { * SONAR-7093 */ @Test - public void ensure_leak_period_defined_at_project_level_is_taken_into_account() throws Exception { + public void ensure_leak_period_defined_at_project_level_is_taken_into_account() { orchestrator.getServer().provisionProject(PROJECT_KEY, PROJECT_KEY); // Set a global property and a project property to ensure project property is used @@ -81,7 +81,7 @@ public class DifferentialPeriodsTest { * SONAR-7237 */ @Test - public void ensure_differential_measures_are_computed_when_adding_new_component_after_period() throws Exception { + public void ensure_differential_measures_are_computed_when_adding_new_component_after_period() { orchestrator.getServer().provisionProject(MULTI_MODULE_PROJECT_KEY, MULTI_MODULE_PROJECT_KEY); tester.settings().setProjectSetting(MULTI_MODULE_PROJECT_KEY, "sonar.leak.period", "30"); @@ -103,7 +103,7 @@ public class DifferentialPeriodsTest { } @Test - public void compute_no_new_lines_measures_when_changes_but_no_scm() throws Exception { + public void compute_no_new_lines_measures_when_changes_but_no_scm() { orchestrator.getServer().provisionProject(MULTI_MODULE_PROJECT_KEY, MULTI_MODULE_PROJECT_KEY); tester.settings().setProjectSetting(MULTI_MODULE_PROJECT_KEY, "sonar.leak.period", "previous_version"); @@ -125,7 +125,7 @@ public class DifferentialPeriodsTest { } @Test - public void compute_zero_new_lines_measures_when_no_changes_and_scm_available() throws Exception { + public void compute_zero_new_lines_measures_when_no_changes_and_scm_available() { String projectKey = "sample-scm"; orchestrator.getServer().provisionProject(projectKey, projectKey); tester.settings().setProjectSetting(projectKey, "sonar.leak.period", "previous_version"); diff --git a/tests/src/test/java/org/sonarqube/tests/measure/ProjectDashboardTest.java b/tests/src/test/java/org/sonarqube/tests/measure/ProjectDashboardTest.java index d687efeeb35..72c95312c0f 100644 --- a/tests/src/test/java/org/sonarqube/tests/measure/ProjectDashboardTest.java +++ b/tests/src/test/java/org/sonarqube/tests/measure/ProjectDashboardTest.java @@ -47,12 +47,12 @@ public class ProjectDashboardTest { private String adminUser; @Before - public void setUp() throws Exception { + public void setUp() { adminUser = tester.users().generateAdministratorOnDefaultOrganization().getLogin(); } @Test - public void after_first_analysis() throws Exception { + public void after_first_analysis() { executeBuild("shared/xoo-sample", "project-for-overview", "Project For Overview"); runSelenese(orchestrator, "/measure/ProjectDashboardTest/test_project_overview_after_first_analysis.html"); diff --git a/tests/src/test/java/org/sonarqube/tests/measure/SincePreviousVersionHistoryTest.java b/tests/src/test/java/org/sonarqube/tests/measure/SincePreviousVersionHistoryTest.java index 3d369bf5195..871e4df67e6 100644 --- a/tests/src/test/java/org/sonarqube/tests/measure/SincePreviousVersionHistoryTest.java +++ b/tests/src/test/java/org/sonarqube/tests/measure/SincePreviousVersionHistoryTest.java @@ -50,7 +50,7 @@ public class SincePreviousVersionHistoryTest { public Tester tester = new Tester(orchestrator); @Before - public void setUp() throws Exception { + public void setUp() { tester.settings().setGlobalSettings("sonar.leak.period", "previous_version"); } diff --git a/tests/src/test/java/org/sonarqube/tests/measure/SinceXDaysHistoryTest.java b/tests/src/test/java/org/sonarqube/tests/measure/SinceXDaysHistoryTest.java index deb2f936ef3..cbf9b9a381c 100644 --- a/tests/src/test/java/org/sonarqube/tests/measure/SinceXDaysHistoryTest.java +++ b/tests/src/test/java/org/sonarqube/tests/measure/SinceXDaysHistoryTest.java @@ -72,17 +72,17 @@ public class SinceXDaysHistoryTest { } @Test - public void check_files_variation() throws Exception { + public void check_files_variation() { checkMeasure("files", 3); } @Test - public void check_issues_variation() throws Exception { + public void check_issues_variation() { checkMeasure("violations", 45); } @Test - public void check_new_issues_measures() throws Exception { + public void check_new_issues_measures() { checkMeasure("new_violations", 45); } diff --git a/tests/src/test/java/org/sonarqube/tests/organization/OrganizationTest.java b/tests/src/test/java/org/sonarqube/tests/organization/OrganizationTest.java index 16e8ec6d252..85492174721 100644 --- a/tests/src/test/java/org/sonarqube/tests/organization/OrganizationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/organization/OrganizationTest.java @@ -254,7 +254,7 @@ public class OrganizationTest { } @Test - public void return_groups_belonging_to_a_user_on_an_organization() throws Exception { + public void return_groups_belonging_to_a_user_on_an_organization() { Organization organization = tester.organizations().generate(); User user = tester.users().generate(); tester.organizations().service().addMember(new AddMemberRequest().setOrganization(organization.getKey()).setLogin(user.getLogin())); diff --git a/tests/src/test/java/org/sonarqube/tests/organization/RootUserTest.java b/tests/src/test/java/org/sonarqube/tests/organization/RootUserTest.java index f12eb6d565a..2622d2f1963 100644 --- a/tests/src/test/java/org/sonarqube/tests/organization/RootUserTest.java +++ b/tests/src/test/java/org/sonarqube/tests/organization/RootUserTest.java @@ -62,7 +62,7 @@ public class RootUserTest { } @Test - public void last_root_can_not_be_unset_root() throws SQLException { + public void last_root_can_not_be_unset_root() { expectBadRequestError(() -> tester.wsClient().roots().unsetRoot(new UnsetRootRequest().setLogin(UserRule.ADMIN_LOGIN))); } diff --git a/tests/src/test/java/org/sonarqube/tests/performance/MavenLogsTest.java b/tests/src/test/java/org/sonarqube/tests/performance/MavenLogsTest.java index d6eeb2a6670..f53247192ab 100644 --- a/tests/src/test/java/org/sonarqube/tests/performance/MavenLogsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/performance/MavenLogsTest.java @@ -25,18 +25,18 @@ import static org.assertj.core.api.Assertions.assertThat; public class MavenLogsTest { @Test - public void testExtractTotalTime() throws Exception { + public void testExtractTotalTime() { assertThat(MavenLogs.extractTotalTime(" \n Total time: 6.015s \n ")).isEqualTo(6015); assertThat(MavenLogs.extractTotalTime(" \n Total time: 3:14.025s\n ")).isEqualTo(194025); } @Test - public void testMaxMemory() throws Exception { + public void testMaxMemory() { assertThat(MavenLogs.extractMaxMemory(" Final Memory: 68M/190M ")).isEqualTo(190); } @Test - public void testEndMemory() throws Exception { + public void testEndMemory() { assertThat(MavenLogs.extractEndMemory(" Final Memory: 68M/190M ")).isEqualTo(68); } } diff --git a/tests/src/test/java/org/sonarqube/tests/performance/ServerLogsTest.java b/tests/src/test/java/org/sonarqube/tests/performance/ServerLogsTest.java index 8a9317d5de4..89dba2dd051 100644 --- a/tests/src/test/java/org/sonarqube/tests/performance/ServerLogsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/performance/ServerLogsTest.java @@ -26,7 +26,7 @@ import static org.assertj.core.api.Assertions.assertThat; public class ServerLogsTest { @Test - public void logs_with_different_computations_take_the_last_one() throws Exception { + public void logs_with_different_computations_take_the_last_one() { assertThat(ServerLogs.extractComputationTotalTime(Lists.newArrayList( "2015.09.29 16:57:45 INFO web[][o.s.s.c.q.CeWorkerRunnableImpl] Executed task | project=com.github.kevinsawicki:http-request-parent | id=AVAZm9oHIXrp54OmOeQe | time=2283ms", "2015.09.29 16:57:45 INFO web[][o.s.s.c.q.CeWorkerRunnableImpl] Executed task | project=com.github.kevinsawicki:http-request-parent | id=AVAZm9oHIXrp54OmOeQe | time=1234ms"))) diff --git a/tests/src/test/java/org/sonarqube/tests/performance/scanner/BootstrappingTest.java b/tests/src/test/java/org/sonarqube/tests/performance/scanner/BootstrappingTest.java index 120942b51ef..511f09d79ae 100644 --- a/tests/src/test/java/org/sonarqube/tests/performance/scanner/BootstrappingTest.java +++ b/tests/src/test/java/org/sonarqube/tests/performance/scanner/BootstrappingTest.java @@ -63,7 +63,7 @@ public class BootstrappingTest extends AbstractPerfTest { } @Test - public void analyzeProjectWith100FlatModules() throws IOException { + public void analyzeProjectWith100FlatModules() { SonarScanner scanner = SonarScanner.create() .setProperties( @@ -107,7 +107,7 @@ public class BootstrappingTest extends AbstractPerfTest { } @Test - public void analyzeProjectWith50NestedModules() throws IOException { + public void analyzeProjectWith50NestedModules() { SonarScanner scanner = SonarScanner.create() .setProperties( "sonar.projectKey", "many-nested-modules", diff --git a/tests/src/test/java/org/sonarqube/tests/performance/scanner/DuplicationTest.java b/tests/src/test/java/org/sonarqube/tests/performance/scanner/DuplicationTest.java index 8a0978781ce..dc88ed9e7e1 100644 --- a/tests/src/test/java/org/sonarqube/tests/performance/scanner/DuplicationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/performance/scanner/DuplicationTest.java @@ -55,7 +55,7 @@ public class DuplicationTest extends AbstractPerfTest { public static final Orchestrator orchestrator = ScannerPerformanceSuite.ORCHESTRATOR; @BeforeClass - public static void setUp() throws IOException { + public static void setUp() { // Execute a first analysis to prevent any side effects with cache of plugin JAR files orchestrator.executeBuild(newScanner("-Xmx512m -server", "sonar.profile", "one-xoo-issue-per-line")); } diff --git a/tests/src/test/java/org/sonarqube/tests/performance/scanner/HighlightingTest.java b/tests/src/test/java/org/sonarqube/tests/performance/scanner/HighlightingTest.java index 43ef77bdd59..040e68669ec 100644 --- a/tests/src/test/java/org/sonarqube/tests/performance/scanner/HighlightingTest.java +++ b/tests/src/test/java/org/sonarqube/tests/performance/scanner/HighlightingTest.java @@ -54,7 +54,7 @@ public class HighlightingTest extends AbstractPerfTest { public static Orchestrator orchestrator = ScannerPerformanceSuite.ORCHESTRATOR; @BeforeClass - public static void setUp() throws IOException { + public static void setUp() { // Execute a first analysis to prevent any side effects with cache of plugin JAR files orchestrator.executeBuild(newScanner("-Xmx512m -server", "sonar.profile", "one-xoo-issue-per-line")); } diff --git a/tests/src/test/java/org/sonarqube/tests/performance/scanner/ScannerPerformanceSuite.java b/tests/src/test/java/org/sonarqube/tests/performance/scanner/ScannerPerformanceSuite.java index a37a6b63b40..1b789600e24 100644 --- a/tests/src/test/java/org/sonarqube/tests/performance/scanner/ScannerPerformanceSuite.java +++ b/tests/src/test/java/org/sonarqube/tests/performance/scanner/ScannerPerformanceSuite.java @@ -52,7 +52,7 @@ public class ScannerPerformanceSuite { .build(); @BeforeClass - public static void setUp() throws IOException { + public static void setUp() { // Execute a first analysis to prevent any side effects with cache of plugin JAR files ORCHESTRATOR.executeBuild(AbstractPerfTest.newScanner("-Xmx512m -server", "sonar.profile", "one-xoo-issue-per-line")); } diff --git a/tests/src/test/java/org/sonarqube/tests/performance/server/ComputeEnginePerfTest.java b/tests/src/test/java/org/sonarqube/tests/performance/server/ComputeEnginePerfTest.java index dc91ca74a05..7ee7fa84624 100644 --- a/tests/src/test/java/org/sonarqube/tests/performance/server/ComputeEnginePerfTest.java +++ b/tests/src/test/java/org/sonarqube/tests/performance/server/ComputeEnginePerfTest.java @@ -58,7 +58,7 @@ public class ComputeEnginePerfTest extends AbstractPerfTest { } @Before - public void before() throws Exception { + public void before() { orchestrator.resetData(); } diff --git a/tests/src/test/java/org/sonarqube/tests/performance/server/ServerPerfTest.java b/tests/src/test/java/org/sonarqube/tests/performance/server/ServerPerfTest.java index be26a4d06f3..3de0d05c8cc 100644 --- a/tests/src/test/java/org/sonarqube/tests/performance/server/ServerPerfTest.java +++ b/tests/src/test/java/org/sonarqube/tests/performance/server/ServerPerfTest.java @@ -102,7 +102,7 @@ public class ServerPerfTest extends AbstractPerfTest { return end; } - private static long extractStopDate(List<String> lines) throws IOException { + private static long extractStopDate(List<String> lines) { Collections.reverse(lines); Date end = ServerLogs.extractFirstDate(lines); return end.getTime(); diff --git a/tests/src/test/java/org/sonarqube/tests/plugins/CompressPluginsTest.java b/tests/src/test/java/org/sonarqube/tests/plugins/CompressPluginsTest.java index 879b3a16fe3..ca57e9fc7e4 100644 --- a/tests/src/test/java/org/sonarqube/tests/plugins/CompressPluginsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/plugins/CompressPluginsTest.java @@ -62,7 +62,7 @@ public class CompressPluginsTest { } @Test - public void plugins_installed_ws_should_expose_compressed_plugin() throws JSONException { + public void plugins_installed_ws_should_expose_compressed_plugin() { WsResponse response = tester.wsClient().wsConnector().call(new GetRequest("api/plugins/installed")); String content = response.content(); JsonParser parser = new JsonParser(); diff --git a/tests/src/test/java/org/sonarqube/tests/plugins/PluginsTest.java b/tests/src/test/java/org/sonarqube/tests/plugins/PluginsTest.java index 49716644959..eb32eebbc6c 100644 --- a/tests/src/test/java/org/sonarqube/tests/plugins/PluginsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/plugins/PluginsTest.java @@ -82,7 +82,7 @@ public class PluginsTest { private static Orchestrator ORCHESTRATOR; @BeforeClass - public static void startServer() throws MalformedURLException { + public static void startServer() { OrchestratorBuilder builder = Orchestrator.builderEnv() .setZipFile(byWildcardMavenFilename(new File("../sonar-application/target"), "sonar*.zip").getFile()); diff --git a/tests/src/test/java/org/sonarqube/tests/plugins/VersionPluginTest.java b/tests/src/test/java/org/sonarqube/tests/plugins/VersionPluginTest.java index 6c7797be8c6..a29c92e78a4 100644 --- a/tests/src/test/java/org/sonarqube/tests/plugins/VersionPluginTest.java +++ b/tests/src/test/java/org/sonarqube/tests/plugins/VersionPluginTest.java @@ -44,7 +44,7 @@ public class VersionPluginTest { } @Before - public void deleteData() throws IOException { + public void deleteData() { orchestrator.resetData(); } diff --git a/tests/src/test/java/org/sonarqube/tests/project/ProjectBulkDeletionPageTest.java b/tests/src/test/java/org/sonarqube/tests/project/ProjectBulkDeletionPageTest.java index 49b04db2773..65d64c732d8 100644 --- a/tests/src/test/java/org/sonarqube/tests/project/ProjectBulkDeletionPageTest.java +++ b/tests/src/test/java/org/sonarqube/tests/project/ProjectBulkDeletionPageTest.java @@ -52,7 +52,7 @@ public class ProjectBulkDeletionPageTest { * SONAR-2614, SONAR-3805 */ @Test - public void bulk_deletion_on_selected_projects() throws Exception { + public void bulk_deletion_on_selected_projects() { Project project1 = tester.projects().provision(p -> p.setName("Foo")); Project project2 = tester.projects().provision(p -> p.setName("Bar")); Project project3 = tester.projects().provision(p -> p.setName("FooQux")); diff --git a/tests/src/test/java/org/sonarqube/tests/project/ProjectFilterTest.java b/tests/src/test/java/org/sonarqube/tests/project/ProjectFilterTest.java index 6a58e909b0b..0828af7a7ff 100644 --- a/tests/src/test/java/org/sonarqube/tests/project/ProjectFilterTest.java +++ b/tests/src/test/java/org/sonarqube/tests/project/ProjectFilterTest.java @@ -142,7 +142,6 @@ public class ProjectFilterTest { assertThat(searchProjects(new SearchProjectsRequest().setFilter("query = \"nd\" AND ncloc > 50")).getComponentsList()) .extracting(Component::getKey).containsExactly("project3", "project4"); assertThat(searchProjects(new SearchProjectsRequest().setFilter("query = \"unknown\" AND ncloc > 50")).getComponentsList()).isEmpty(); - ; // Check facets assertThat(searchProjects(new SearchProjectsRequest().setFilter("query = \"apache\"").setFacets(singletonList("ncloc"))).getFacets().getFacets(0).getValuesList()) @@ -290,7 +289,7 @@ public class ProjectFilterTest { return searchProjects(new SearchProjectsRequest().setOrganization(organization.getKey()).setFilter(filter)); } - private SearchProjectsWsResponse searchProjects(SearchProjectsRequest request) throws IOException { + private SearchProjectsWsResponse searchProjects(SearchProjectsRequest request) { return tester.wsClient().components().searchProjects(request); } diff --git a/tests/src/test/java/org/sonarqube/tests/project/ProjectKeyUpdatePageTest.java b/tests/src/test/java/org/sonarqube/tests/project/ProjectKeyUpdatePageTest.java index c6183fd07f0..40d7abf27ed 100644 --- a/tests/src/test/java/org/sonarqube/tests/project/ProjectKeyUpdatePageTest.java +++ b/tests/src/test/java/org/sonarqube/tests/project/ProjectKeyUpdatePageTest.java @@ -45,7 +45,7 @@ public class ProjectKeyUpdatePageTest { public Tester tester = new Tester(orchestrator); @Before - public void setUp() throws Exception { + public void setUp() { tester.wsClient().users().skipOnboardingTutorial(); } diff --git a/tests/src/test/java/org/sonarqube/tests/project/ProjectListTest.java b/tests/src/test/java/org/sonarqube/tests/project/ProjectListTest.java index 21dd94c3821..1c26c05f410 100644 --- a/tests/src/test/java/org/sonarqube/tests/project/ProjectListTest.java +++ b/tests/src/test/java/org/sonarqube/tests/project/ProjectListTest.java @@ -43,7 +43,7 @@ public class ProjectListTest { * SONAR-3105 */ @Test - public void test_projects_index_ws() throws IOException { + public void test_projects_index_ws() { SonarScanner build = SonarScanner.create(projectDir("shared/xoo-sample")); orchestrator.executeBuild(build); diff --git a/tests/src/test/java/org/sonarqube/tests/project/ProjectSettingsTest.java b/tests/src/test/java/org/sonarqube/tests/project/ProjectSettingsTest.java index fa496360576..029cf8a8b5c 100644 --- a/tests/src/test/java/org/sonarqube/tests/project/ProjectSettingsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/project/ProjectSettingsTest.java @@ -101,7 +101,7 @@ public class ProjectSettingsTest { } @Test - public void display_module_settings() throws UnsupportedEncodingException { + public void display_module_settings() { orchestrator.executeBuild(SonarScanner.create(projectDir("shared/xoo-multi-modules-sample"))); tester.openBrowser().logIn().submitCredentials(adminUser) diff --git a/tests/src/test/java/org/sonarqube/tests/project/ProjectVisibilityPageTest.java b/tests/src/test/java/org/sonarqube/tests/project/ProjectVisibilityPageTest.java index 1629de298de..64db22b012d 100644 --- a/tests/src/test/java/org/sonarqube/tests/project/ProjectVisibilityPageTest.java +++ b/tests/src/test/java/org/sonarqube/tests/project/ProjectVisibilityPageTest.java @@ -51,7 +51,7 @@ public class ProjectVisibilityPageTest { } @Test - public void return_all_projects_even_when_no_permission() throws Exception { + public void return_all_projects_even_when_no_permission() { orchestrator.executeBuild(SonarScanner.create(projectDir("shared/xoo-sample")).setProperties("sonar.projectKey", "sample1")); orchestrator.executeBuild(SonarScanner.create(projectDir("shared/xoo-sample")).setProperties("sonar.projectKey", "sample2")); tester.wsClient().projects().updateVisibility(new UpdateVisibilityRequest().setProject("sample2").setVisibility("private")); diff --git a/tests/src/test/java/org/sonarqube/tests/projectAdministration/ProjectPermissionsTest.java b/tests/src/test/java/org/sonarqube/tests/projectAdministration/ProjectPermissionsTest.java index 88b42fd681f..b674f11ef1a 100644 --- a/tests/src/test/java/org/sonarqube/tests/projectAdministration/ProjectPermissionsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/projectAdministration/ProjectPermissionsTest.java @@ -57,7 +57,7 @@ public class ProjectPermissionsTest { } @Test - public void test_project_permissions_page_shows_only_single_project() throws Exception { + public void test_project_permissions_page_shows_only_single_project() { runSelenese(orchestrator, "/projectAdministration/ProjectPermissionsTest/test_project_permissions_page_shows_only_single_project.html"); } diff --git a/tests/src/test/java/org/sonarqube/tests/qualityGate/OrganizationQualityGateTest.java b/tests/src/test/java/org/sonarqube/tests/qualityGate/OrganizationQualityGateTest.java index 355b276eafd..9b6223cf7e2 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityGate/OrganizationQualityGateTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityGate/OrganizationQualityGateTest.java @@ -104,7 +104,7 @@ public class OrganizationQualityGateTest { } @Test - public void search_projects_only_return_projects_from_quality_gate_organization() throws Exception { + public void search_projects_only_return_projects_from_quality_gate_organization() { Organization organization = tester.organizations().generate(); Project project = tester.projects().provision(organization); Organization otherOrganization = tester.organizations().generate(); @@ -124,7 +124,7 @@ public class OrganizationQualityGateTest { } @Test - public void list_quality_gates_from_organization() throws Exception { + public void list_quality_gates_from_organization() { Organization organization = tester.organizations().generate(); Organization otherOrganization = tester.organizations().generate(); Qualitygates.CreateResponse qualityGate = tester.qGates().generate(organization); diff --git a/tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateNotificationTest.java b/tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateNotificationTest.java index 5ce6b954ea2..683e9436750 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateNotificationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateNotificationTest.java @@ -54,13 +54,13 @@ public class QualityGateNotificationTest { private static Wiser smtpServer; @BeforeClass - public static void startSmtpServer() throws Exception { + public static void startSmtpServer() { smtpServer = new Wiser(0); smtpServer.start(); } @AfterClass - public static void stopSmtpServer() throws Exception { + public static void stopSmtpServer() { if (smtpServer != null) { smtpServer.stop(); } diff --git a/tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateOnRatingMeasuresTest.java b/tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateOnRatingMeasuresTest.java index eb8f487c2a9..84c6f0f1be0 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateOnRatingMeasuresTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityGate/QualityGateOnRatingMeasuresTest.java @@ -45,7 +45,7 @@ public class QualityGateOnRatingMeasuresTest { .disableOrganizations(); @Test - public void generate_warning_qgate_on_rating_metric() throws Exception { + public void generate_warning_qgate_on_rating_metric() { Project project = tester.projects().provision(); Qualitygates.CreateResponse qualityGate = tester.qGates().generate(); tester.qGates().associateProject(qualityGate, project); @@ -63,7 +63,7 @@ public class QualityGateOnRatingMeasuresTest { } @Test - public void generate_error_qgate_on_rating_metric_on_leak_period() throws Exception { + public void generate_error_qgate_on_rating_metric_on_leak_period() { Project project = tester.projects().provision(); Qualitygates.CreateResponse qualityGate = tester.qGates().generate(); tester.qGates().associateProject(qualityGate, project); diff --git a/tests/src/test/java/org/sonarqube/tests/qualityModel/MaintainabilityRatingMeasureTest.java b/tests/src/test/java/org/sonarqube/tests/qualityModel/MaintainabilityRatingMeasureTest.java index 7af7eb2a280..4f8e28f25cd 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityModel/MaintainabilityRatingMeasureTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityModel/MaintainabilityRatingMeasureTest.java @@ -86,7 +86,7 @@ public class MaintainabilityRatingMeasureTest { } @Test - public void use_development_cost_parameter() throws Exception { + public void use_development_cost_parameter() { ItUtils.restoreProfile(orchestrator, getClass().getResource("/qualityModel/one-issue-per-line.xml")); orchestrator.getServer().provisionProject("sample", "sample"); orchestrator.getServer().associateProjectToQualityProfile("sample", "xoo", "one-issue-per-line"); @@ -102,7 +102,7 @@ public class MaintainabilityRatingMeasureTest { } @Test - public void use_language_specific_parameters() throws Exception { + public void use_language_specific_parameters() { ItUtils.restoreProfile(orchestrator, getClass().getResource("/qualityModel/one-issue-per-line.xml")); orchestrator.getServer().provisionProject(PROJECT, PROJECT); orchestrator.getServer().associateProjectToQualityProfile(PROJECT, "xoo", "one-issue-per-line"); @@ -120,7 +120,7 @@ public class MaintainabilityRatingMeasureTest { } @Test - public void use_rating_grid_parameter() throws Exception { + public void use_rating_grid_parameter() { ItUtils.restoreProfile(orchestrator, getClass().getResource("/qualityModel/one-issue-per-line.xml")); orchestrator.getServer().provisionProject("sample", "sample"); orchestrator.getServer().associateProjectToQualityProfile("sample", "xoo", "one-issue-per-line"); diff --git a/tests/src/test/java/org/sonarqube/tests/qualityModel/NewDebtRatioMeasureTest.java b/tests/src/test/java/org/sonarqube/tests/qualityModel/NewDebtRatioMeasureTest.java index 2fe7d65a7ae..43009ce4bea 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityModel/NewDebtRatioMeasureTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityModel/NewDebtRatioMeasureTest.java @@ -52,7 +52,7 @@ public class NewDebtRatioMeasureTest { public Tester tester = new Tester(orchestrator); @Test - public void new_debt_ratio_is_computed_from_new_debt_and_new_ncloc_count_per_file() throws Exception { + public void new_debt_ratio_is_computed_from_new_debt_and_new_ncloc_count_per_file() { tester.settings().setGlobalSettings("sonar.leak.period", "previous_version"); // run analysis on the day of after the first commit, with 'one-issue-per-line' profile @@ -76,7 +76,7 @@ public class NewDebtRatioMeasureTest { } @Test - public void compute_new_debt_ratio_using_number_days_in_leak_period() throws Exception { + public void compute_new_debt_ratio_using_number_days_in_leak_period() { tester.settings().setGlobalSettings("sonar.leak.period", "30"); // run analysis on the day of after the first commit, with 'one-issue-per-line' profile diff --git a/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtAndIssueNewMeasuresTest.java b/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtAndIssueNewMeasuresTest.java index 055c4fe86ef..842778d6496 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtAndIssueNewMeasuresTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtAndIssueNewMeasuresTest.java @@ -45,7 +45,7 @@ public class TechnicalDebtAndIssueNewMeasuresTest { public Tester tester = new Tester(orchestrator); @Test - public void since_30_days_with_constant_effort() throws Exception { + public void since_30_days_with_constant_effort() { tester.settings().setGlobalSettings("sonar.leak.period", "30"); restoreQualityProfile("one-issue-per-line"); provisionSampleProject(); @@ -83,7 +83,7 @@ public class TechnicalDebtAndIssueNewMeasuresTest { } @Test - public void since_30_days_with_effort_change() throws Exception { + public void since_30_days_with_effort_change() { tester.settings().setGlobalSettings("sonar.leak.period", "30"); restoreQualityProfile("one-issue-per-line"); provisionSampleProject(); @@ -121,7 +121,7 @@ public class TechnicalDebtAndIssueNewMeasuresTest { } @Test - public void since_previous_version_with_constant_effort() throws Exception { + public void since_previous_version_with_constant_effort() { tester.settings().setGlobalSettings("sonar.leak.period", "previous_version"); restoreQualityProfile("one-issue-per-line"); provisionSampleProject(); @@ -159,7 +159,7 @@ public class TechnicalDebtAndIssueNewMeasuresTest { } @Test - public void since_previous_version_with_effort_change() throws Exception { + public void since_previous_version_with_effort_change() { tester.settings().setGlobalSettings( "sonar.leak.period", "previous_version"); restoreQualityProfile("one-issue-per-line"); provisionSampleProject(); diff --git a/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtInIssueChangelogTest.java b/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtInIssueChangelogTest.java index a9b9f5eb397..f7593032ffc 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtInIssueChangelogTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtInIssueChangelogTest.java @@ -47,7 +47,7 @@ public class TechnicalDebtInIssueChangelogTest { public Tester tester = new Tester(orchestrator); @Test - public void display_debt_in_issue_changelog() throws Exception { + public void display_debt_in_issue_changelog() { ItUtils.restoreProfile(orchestrator, getClass().getResource("/qualityModel/one-issue-per-file.xml")); orchestrator.getServer().provisionProject("sample", "sample"); orchestrator.getServer().associateProjectToQualityProfile("sample", "xoo", "one-issue-per-file"); diff --git a/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtTest.java b/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtTest.java index dfb10d8e889..8ee437a49c3 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityModel/TechnicalDebtTest.java @@ -45,7 +45,7 @@ public class TechnicalDebtTest { * SONAR-4716 */ @Test - public void technical_debt_on_issue() throws Exception { + public void technical_debt_on_issue() { ItUtils.restoreProfile(orchestrator, getClass().getResource("/qualityModel/one-issue-per-line.xml")); orchestrator.getServer().provisionProject("sample", "sample"); orchestrator.getServer().associateProjectToQualityProfile("sample", "xoo", "one-issue-per-line"); diff --git a/tests/src/test/java/org/sonarqube/tests/qualityProfile/BuiltInQualityProfilesNotificationTest.java b/tests/src/test/java/org/sonarqube/tests/qualityProfile/BuiltInQualityProfilesNotificationTest.java index 6eb16bf0571..fb973a82a5c 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityProfile/BuiltInQualityProfilesNotificationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityProfile/BuiltInQualityProfilesNotificationTest.java @@ -50,13 +50,13 @@ public class BuiltInQualityProfilesNotificationTest { private static UserRule userRule; @Before - public void init() throws Exception { + public void init() { smtpServer = new Wiser(0); smtpServer.start(); } @After - public void tearDown() throws Exception { + public void tearDown() { if (orchestrator != null) { orchestrator.stop(); } diff --git a/tests/src/test/java/org/sonarqube/tests/qualityProfile/QualityProfilesUiTest.java b/tests/src/test/java/org/sonarqube/tests/qualityProfile/QualityProfilesUiTest.java index 436d4e93302..6be533734cc 100644 --- a/tests/src/test/java/org/sonarqube/tests/qualityProfile/QualityProfilesUiTest.java +++ b/tests/src/test/java/org/sonarqube/tests/qualityProfile/QualityProfilesUiTest.java @@ -54,7 +54,7 @@ public class QualityProfilesUiTest { public Tester tester = new Tester(orchestrator).disableOrganizations(); @Before - public void initAdminUser() throws Exception { + public void initAdminUser() { userRule.createAdminUser(ADMIN_USER_LOGIN, ADMIN_USER_LOGIN); } diff --git a/tests/src/test/java/org/sonarqube/tests/serverSystem/HttpHeadersTest.java b/tests/src/test/java/org/sonarqube/tests/serverSystem/HttpHeadersTest.java index df8225abfd3..5b8688a4201 100644 --- a/tests/src/test/java/org/sonarqube/tests/serverSystem/HttpHeadersTest.java +++ b/tests/src/test/java/org/sonarqube/tests/serverSystem/HttpHeadersTest.java @@ -47,7 +47,7 @@ public class HttpHeadersTest { } @Test - public void verify_headers_of_base_url() throws Exception { + public void verify_headers_of_base_url() { Response response = call(orchestrator.getServer().getUrl() + "/"); verifySecurityHeaders(response); @@ -58,7 +58,7 @@ public class HttpHeadersTest { } @Test - public void verify_headers_of_ws() throws Exception { + public void verify_headers_of_ws() { Response response = call(orchestrator.getServer().getUrl() + "/api/issues/search"); verifySecurityHeaders(response); @@ -67,7 +67,7 @@ public class HttpHeadersTest { } @Test - public void verify_headers_of_images() throws Exception { + public void verify_headers_of_images() { Response response = call(orchestrator.getServer().getUrl() + "/images/logo.svg"); verifySecurityHeaders(response); @@ -76,7 +76,7 @@ public class HttpHeadersTest { } @Test - public void verify_headers_of_css() throws Exception { + public void verify_headers_of_css() { Response response = call(orchestrator.getServer().getUrl() + "/css/sonar." + JS_HASH + ".css"); verifySecurityHeaders(response); @@ -85,7 +85,7 @@ public class HttpHeadersTest { } @Test - public void verify_headers_of_js() throws Exception { + public void verify_headers_of_js() { Response response = call(orchestrator.getServer().getUrl() + "/js/app." + JS_HASH + ".js"); verifySecurityHeaders(response); @@ -93,7 +93,7 @@ public class HttpHeadersTest { } @Test - public void verify_headers_of_images_provided_by_plugins() throws Exception { + public void verify_headers_of_images_provided_by_plugins() { Response response = call(orchestrator.getServer().getUrl() + "/static/uiextensionsplugin/cute.jpg"); verifySecurityHeaders(response); @@ -101,7 +101,7 @@ public class HttpHeadersTest { } @Test - public void verify_headers_of_js_provided_by_plugins() throws Exception { + public void verify_headers_of_js_provided_by_plugins() { Response response = call(orchestrator.getServer().getUrl() + "/static/uiextensionsplugin/extension.js"); verifySecurityHeaders(response); @@ -109,7 +109,7 @@ public class HttpHeadersTest { } @Test - public void verify_headers_of_html_provided_by_plugins() throws Exception { + public void verify_headers_of_html_provided_by_plugins() { Response response = call(orchestrator.getServer().getUrl() + "/static/uiextensionsplugin/file.html"); verifySecurityHeaders(response); diff --git a/tests/src/test/java/org/sonarqube/tests/serverSystem/PingTest.java b/tests/src/test/java/org/sonarqube/tests/serverSystem/PingTest.java index 73fb865e83c..a56ed9deee0 100644 --- a/tests/src/test/java/org/sonarqube/tests/serverSystem/PingTest.java +++ b/tests/src/test/java/org/sonarqube/tests/serverSystem/PingTest.java @@ -33,7 +33,7 @@ public class PingTest { public static final Orchestrator orchestrator = Category4Suite.ORCHESTRATOR; @Test - public void ping_answers_pong() throws Exception { + public void ping_answers_pong() { HttpResponse response = orchestrator.getServer().newHttpCall("/api/system/ping").execute(); assertThat(response.getBodyAsString()).isEqualTo("pong"); diff --git a/tests/src/test/java/org/sonarqube/tests/serverSystem/ServerSystemTest.java b/tests/src/test/java/org/sonarqube/tests/serverSystem/ServerSystemTest.java index 09f5b7c1395..1fa47c91352 100644 --- a/tests/src/test/java/org/sonarqube/tests/serverSystem/ServerSystemTest.java +++ b/tests/src/test/java/org/sonarqube/tests/serverSystem/ServerSystemTest.java @@ -86,7 +86,7 @@ public class ServerSystemTest { } @Test - public void http_response_should_be_gzipped() throws IOException { + public void http_response_should_be_gzipped() { String url = orchestrator.getServer().getUrl() + "/api/rules/search"; Response metricsResponse = call(url); assertThat(metricsResponse.isSuccessful()).as("Response code is %s", metricsResponse.code()).isTrue(); diff --git a/tests/src/test/java/org/sonarqube/tests/settings/DeprecatedPropertiesWsTest.java b/tests/src/test/java/org/sonarqube/tests/settings/DeprecatedPropertiesWsTest.java index 5775c366a00..2f26e1113d8 100644 --- a/tests/src/test/java/org/sonarqube/tests/settings/DeprecatedPropertiesWsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/settings/DeprecatedPropertiesWsTest.java @@ -82,7 +82,7 @@ public class DeprecatedPropertiesWsTest { static SettingsService adminSettingsService; @BeforeClass - public static void init() throws Exception { + public static void init() { orchestrator.resetData(); userRule.createUser(USER_LOGIN, "password"); adminWsClient = newAdminWsClient(orchestrator); @@ -93,13 +93,13 @@ public class DeprecatedPropertiesWsTest { } @AfterClass - public static void resetAfterClass() throws Exception { + public static void resetAfterClass() { doResetSettings(); userRule.deactivateUsers(USER_LOGIN); } @Before - public void resetBefore() throws Exception { + public void resetBefore() { doResetSettings(); } @@ -159,7 +159,7 @@ public class DeprecatedPropertiesWsTest { } @Test - public void secured_setting_not_returned_to_not_admin() throws Exception { + public void secured_setting_not_returned_to_not_admin() { setProperty("setting.secured", "value", null); // Admin can see the secured setting @@ -171,7 +171,7 @@ public class DeprecatedPropertiesWsTest { } @Test - public void license_setting_not_returned_to_not_logged() throws Exception { + public void license_setting_not_returned_to_not_logged() { setProperty("setting.license.secured", "value", null); // Admin and user can see the license setting @@ -183,7 +183,7 @@ public class DeprecatedPropertiesWsTest { } @Test - public void get_all_global_settings() throws Exception { + public void get_all_global_settings() { List<Properties.Property> properties = getProperties(null); assertThat(properties).isNotEmpty(); assertThat(properties).extracting("key") @@ -223,7 +223,7 @@ public class DeprecatedPropertiesWsTest { } @Test - public void get_all_component_settings() throws Exception { + public void get_all_component_settings() { List<Properties.Property> properties = getProperties(PROJECT_KEY); assertThat(properties).isNotEmpty(); assertThat(properties).extracting("key") diff --git a/tests/src/test/java/org/sonarqube/tests/settings/EmailsTest.java b/tests/src/test/java/org/sonarqube/tests/settings/EmailsTest.java index 78dbf4f299d..835c7494eba 100644 --- a/tests/src/test/java/org/sonarqube/tests/settings/EmailsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/settings/EmailsTest.java @@ -58,7 +58,7 @@ public class EmailsTest { private static Wiser SMTP_SERVER; @BeforeClass - public static void before() throws Exception { + public static void before() { SMTP_SERVER = new Wiser(0); SMTP_SERVER.start(); System.out.println("SMTP Server port: " + SMTP_SERVER.getServer().getPort()); @@ -77,7 +77,7 @@ public class EmailsTest { } @Test - public void update_email_settings() throws Exception { + public void update_email_settings() { updateEmailSettings("localhost", "42", "noreply@email.com", "The Devil", "[EMAIL]", "ssl", "john", "123456"); Settings.ValuesWsResponse response = tester.settings().service().values(new ValuesRequest() diff --git a/tests/src/test/java/org/sonarqube/tests/settings/PropertySetsTest.java b/tests/src/test/java/org/sonarqube/tests/settings/PropertySetsTest.java index f8f14710469..9d9e50c0c17 100644 --- a/tests/src/test/java/org/sonarqube/tests/settings/PropertySetsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/settings/PropertySetsTest.java @@ -58,7 +58,7 @@ public class PropertySetsTest { private String adminUser; @BeforeClass - public static void initSettingsService() throws Exception { + public static void initSettingsService() { SETTINGS = newAdminWsClient(orchestrator).settings(); } @@ -68,12 +68,12 @@ public class PropertySetsTest { } @After - public void reset_settings() throws Exception { + public void reset_settings() { resetSettings(orchestrator, null, "sonar.demo", "sonar.autogenerated", "sonar.test.jira.servers"); } @Test - public void support_property_sets() throws UnsupportedEncodingException { + public void support_property_sets() { SettingsPage page = nav.logIn().submitCredentials(adminUser).openSettings(null).openCategory("DEV") .assertSettingDisplayed("sonar.test.jira.servers"); @@ -90,7 +90,7 @@ public class PropertySetsTest { } @Test - public void support_property_sets_with_auto_generated_keys() throws UnsupportedEncodingException { + public void support_property_sets_with_auto_generated_keys() { SettingsPage page = nav.logIn().submitCredentials(adminUser).openSettings(null).openCategory("DEV") .assertSettingDisplayed("sonar.autogenerated"); @@ -120,7 +120,7 @@ public class PropertySetsTest { } @Test - public void delete_property_set() throws Exception { + public void delete_property_set() { SETTINGS.set(new SetRequest() .setKey("sonar.test.jira.servers") .setFieldValues(asList("{\"url\":\"http://jira1\"}", "{\"port\":\"12345\"}"))); diff --git a/tests/src/test/java/org/sonarqube/tests/settings/SettingsTest.java b/tests/src/test/java/org/sonarqube/tests/settings/SettingsTest.java index 3876af117c5..04c4f0ad670 100644 --- a/tests/src/test/java/org/sonarqube/tests/settings/SettingsTest.java +++ b/tests/src/test/java/org/sonarqube/tests/settings/SettingsTest.java @@ -76,7 +76,7 @@ public class SettingsTest { private static SettingsService adminSettingsService; @BeforeClass - public static void initSettingsService() throws Exception { + public static void initSettingsService() { userRule.createUser("setting-user", "setting-user"); userRule.createUser("scanner-user", "scanner-user"); adminWsClient = newAdminWsClient(orchestrator); @@ -98,14 +98,14 @@ public class SettingsTest { } @AfterClass - public static void tearDown() throws Exception { + public static void tearDown() { userRule.deactivateUsers("setting-user", "scanner-user"); // Restore 'Execute Analysis' permission to anyone adminWsClient.permissions().addGroup(new AddGroupRequest().setGroupName("anyone").setPermission("scan")); } @After - public void reset_settings() throws Exception { + public void reset_settings() { resetSettings(orchestrator, null, PLUGIN_SETTING_KEY, "globalPropertyChange.received", "hidden", "setting.secured", "setting.license.secured"); } @@ -169,13 +169,13 @@ public class SettingsTest { } @Test - public void multi_values_setting() throws Exception { + public void multi_values_setting() { adminSettingsService.set(new SetRequest().setKey("multi").setValues(asList("value1", "value2", "value3"))); assertThat(getSetting("multi", anonymousSettingsService).getValues().getValuesList()).containsOnly("value1", "value2", "value3"); } @Test - public void property_set_setting() throws Exception { + public void property_set_setting() { adminSettingsService.set(new SetRequest().setKey("sonar.jira").setFieldValues(asList( "{\"key\":\"jira1\", \"url\":\"http://jira1\", \"port\":\"12345\", \"type\":\"A\"}", "{\"key\":\"jira2\", \"url\":\"http://jira2\", \"port\":\"54321\"}"))); @@ -186,7 +186,7 @@ public class SettingsTest { } @Test - public void return_defined_settings_when_no_key_provided() throws Exception { + public void return_defined_settings_when_no_key_provided() { adminSettingsService.set(new SetRequest().setKey(PLUGIN_SETTING_KEY).setValue("some value")); adminSettingsService.set(new SetRequest().setKey("hidden").setValue("test")); diff --git a/tests/src/test/java/org/sonarqube/tests/settings/SettingsTestRestartingOrchestrator.java b/tests/src/test/java/org/sonarqube/tests/settings/SettingsTestRestartingOrchestrator.java index 977de004eeb..8aee5ebb876 100644 --- a/tests/src/test/java/org/sonarqube/tests/settings/SettingsTestRestartingOrchestrator.java +++ b/tests/src/test/java/org/sonarqube/tests/settings/SettingsTestRestartingOrchestrator.java @@ -58,7 +58,7 @@ public class SettingsTestRestartingOrchestrator { } @Test - public void test_settings() throws UnsupportedEncodingException { + public void test_settings() { URL secretKeyUrl = getClass().getResource("/settings/SettingsTest/sonar-secret.txt"); orchestrator = Orchestrator.builderEnv() .addPlugin(pluginArtifact("settings-plugin")) @@ -85,7 +85,7 @@ public class SettingsTestRestartingOrchestrator { } @Test - public void property_relocation() throws UnsupportedEncodingException { + public void property_relocation() { orchestrator = Orchestrator.builderEnv() .addPlugin(pluginArtifact("property-relocation-plugin")) .addPlugin(xooPlugin()) diff --git a/tests/src/test/java/org/sonarqube/tests/startup/StartupIndexationTest.java b/tests/src/test/java/org/sonarqube/tests/startup/StartupIndexationTest.java index 1040d20e50a..643a0ff12d5 100644 --- a/tests/src/test/java/org/sonarqube/tests/startup/StartupIndexationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/startup/StartupIndexationTest.java @@ -118,7 +118,7 @@ public class StartupIndexationTest { } @Override - public void close() throws Exception { + public void close() { if (tester != null) { try { tester.after(); diff --git a/tests/src/test/java/org/sonarqube/tests/test/NewCoverageTest.java b/tests/src/test/java/org/sonarqube/tests/test/NewCoverageTest.java index 2096b482f69..69ecf0226de 100644 --- a/tests/src/test/java/org/sonarqube/tests/test/NewCoverageTest.java +++ b/tests/src/test/java/org/sonarqube/tests/test/NewCoverageTest.java @@ -47,7 +47,7 @@ public class NewCoverageTest { public Tester tester = new Tester(orchestrator); @Test - public void new_coverage() throws Exception { + public void new_coverage() { orchestrator.executeBuilds(SonarScanner.create(projectDir("testing/xoo-sample-new-coverage-v1")) .setProperty("sonar.projectDate", "2015-02-01") .setProperty("sonar.scm.disabled", "false")); diff --git a/tests/src/test/java/org/sonarqube/tests/test/TestExecutionTest.java b/tests/src/test/java/org/sonarqube/tests/test/TestExecutionTest.java index 31f92c87402..c573dc92f79 100644 --- a/tests/src/test/java/org/sonarqube/tests/test/TestExecutionTest.java +++ b/tests/src/test/java/org/sonarqube/tests/test/TestExecutionTest.java @@ -62,7 +62,7 @@ public class TestExecutionTest { } @Test - public void test_execution_measures() throws Exception { + public void test_execution_measures() { orchestrator.executeBuilds(SonarScanner.create(projectDir("testing/xoo-sample-with-tests-execution-measures"))); Map<String, Double> measures = getMeasuresAsDoubleByMetricKey(orchestrator, "sample-with-tests", diff --git a/tests/src/test/java/org/sonarqube/tests/user/BaseIdentityProviderTest.java b/tests/src/test/java/org/sonarqube/tests/user/BaseIdentityProviderTest.java index 6f3bff5e86a..e445488536d 100644 --- a/tests/src/test/java/org/sonarqube/tests/user/BaseIdentityProviderTest.java +++ b/tests/src/test/java/org/sonarqube/tests/user/BaseIdentityProviderTest.java @@ -82,7 +82,7 @@ public class BaseIdentityProviderTest { @Before @After - public void resetData() throws Exception { + public void resetData() { userRule.resetUsers(); userRule.removeGroups(GROUP1, GROUP2, GROUP3); resetSettings(ORCHESTRATOR, null, @@ -95,7 +95,7 @@ public class BaseIdentityProviderTest { } @Test - public void create_new_user_when_authenticate() throws Exception { + public void create_new_user_when_authenticate() { enablePlugin(); setUserCreatedByAuthPlugin(USER_LOGIN, USER_PROVIDER_ID, USER_NAME, USER_EMAIL); @@ -108,7 +108,7 @@ public class BaseIdentityProviderTest { } @Test - public void authenticate_user_through_ui() throws Exception { + public void authenticate_user_through_ui() { enablePlugin(); setUserCreatedByAuthPlugin(USER_LOGIN, USER_PROVIDER_ID, USER_NAME, USER_EMAIL); @@ -118,7 +118,7 @@ public class BaseIdentityProviderTest { } @Test - public void display_unauthorized_page_when_authentication_failed() throws Exception { + public void display_unauthorized_page_when_authentication_failed() { enablePlugin(); // As this property is null, the plugin will throw an exception setServerProperty(ORCHESTRATOR, "sonar.auth.fake-base-id-provider.user", null); @@ -142,7 +142,7 @@ public class BaseIdentityProviderTest { } @Test - public void fail_to_authenticate_when_not_allowed_to_sign_up() throws Exception { + public void fail_to_authenticate_when_not_allowed_to_sign_up() { enablePlugin(); setUserCreatedByAuthPlugin(USER_LOGIN, USER_PROVIDER_ID, USER_NAME, USER_EMAIL); setServerProperty(ORCHESTRATOR, "sonar.auth.fake-base-id-provider.allowsUsersToSignUp", "false"); @@ -153,7 +153,7 @@ public class BaseIdentityProviderTest { } @Test - public void update_existing_user_when_authenticate() throws Exception { + public void update_existing_user_when_authenticate() { enablePlugin(); setUserCreatedByAuthPlugin(USER_LOGIN, USER_PROVIDER_ID, USER_NAME, USER_EMAIL); @@ -169,7 +169,7 @@ public class BaseIdentityProviderTest { } @Test - public void reactivate_disabled_user() throws Exception { + public void reactivate_disabled_user() { enablePlugin(); setUserCreatedByAuthPlugin(USER_LOGIN, USER_PROVIDER_ID, USER_NAME, USER_EMAIL); @@ -190,7 +190,7 @@ public class BaseIdentityProviderTest { } @Test - public void not_authenticate_when_plugin_is_disabled() throws Exception { + public void not_authenticate_when_plugin_is_disabled() { setServerProperty(ORCHESTRATOR, "sonar.auth.fake-base-id-provider.enabled", "false"); setUserCreatedByAuthPlugin(USER_LOGIN, USER_PROVIDER_ID, USER_NAME, USER_EMAIL); @@ -219,7 +219,7 @@ public class BaseIdentityProviderTest { } @Test - public void synchronize_groups_for_new_user() throws Exception { + public void synchronize_groups_for_new_user() { enablePlugin(); userRule.createGroup(GROUP1); userRule.createGroup(GROUP2); @@ -233,7 +233,7 @@ public class BaseIdentityProviderTest { } @Test - public void synchronize_groups_for_existing_user() throws Exception { + public void synchronize_groups_for_existing_user() { enablePlugin(); userRule.createGroup(GROUP1); userRule.createGroup(GROUP2); @@ -250,7 +250,7 @@ public class BaseIdentityProviderTest { } @Test - public void remove_user_groups_when_groups_provided_by_plugin_are_empty() throws Exception { + public void remove_user_groups_when_groups_provided_by_plugin_are_empty() { enablePlugin(); userRule.createGroup(GROUP1); userRule.createUser(USER_LOGIN, "password"); @@ -266,7 +266,7 @@ public class BaseIdentityProviderTest { } @Test - public void allow_user_login_with_2_characters() throws Exception { + public void allow_user_login_with_2_characters() { enablePlugin(); String login = "jo"; setUserCreatedByAuthPlugin(login, USER_PROVIDER_ID, USER_NAME, USER_EMAIL); diff --git a/tests/src/test/java/org/sonarqube/tests/user/LocalAuthenticationTest.java b/tests/src/test/java/org/sonarqube/tests/user/LocalAuthenticationTest.java index 53ea4427ccf..fc3707f322e 100644 --- a/tests/src/test/java/org/sonarqube/tests/user/LocalAuthenticationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/user/LocalAuthenticationTest.java @@ -62,7 +62,7 @@ public class LocalAuthenticationTest { public Tester tester = new Tester(orchestrator).disableOrganizations(); @After - public void resetProperties() throws Exception { + public void resetProperties() { resetSettings(orchestrator, null, "sonar.forceAuthentication"); } @@ -154,7 +154,7 @@ public class LocalAuthenticationTest { } @Test - public void allow_user_login_with_2_characters() throws Exception { + public void allow_user_login_with_2_characters() { tester.users().generate(u -> u.setLogin("jo").setPassword("password")); assertThat(checkAuthenticationWithAuthenticateWebService("jo", "password")).isTrue(); @@ -215,7 +215,7 @@ public class LocalAuthenticationTest { * SONAR-7640 */ @Test - public void authentication_with_any_ws() throws Exception { + public void authentication_with_any_ws() { tester.users().generate(u -> u.setLogin("test").setPassword("password")); assertThat(checkAuthenticationWithAnyWS("test", "password").code()).isEqualTo(200); diff --git a/tests/src/test/java/org/sonarqube/tests/user/MyAccountPageTest.java b/tests/src/test/java/org/sonarqube/tests/user/MyAccountPageTest.java index a90a916d0df..226082b75b1 100644 --- a/tests/src/test/java/org/sonarqube/tests/user/MyAccountPageTest.java +++ b/tests/src/test/java/org/sonarqube/tests/user/MyAccountPageTest.java @@ -54,7 +54,7 @@ public class MyAccountPageTest { } @Test - public void should_display_user_details() throws Exception { + public void should_display_user_details() { Navigation nav = tester.openBrowser(); nav.openLogin().submitCredentials("account-user", "password").shouldBeLoggedIn(); nav.open("/account"); @@ -67,7 +67,7 @@ public class MyAccountPageTest { } @Test - public void should_change_password() throws Exception { + public void should_change_password() { Navigation nav = tester.openBrowser(); nav.openLogin().submitCredentials("account-user", "password").shouldBeLoggedIn(); nav.open("/account/security"); @@ -80,7 +80,7 @@ public class MyAccountPageTest { } @Test - public void should_display_projects() throws Exception { + public void should_display_projects() { // first, try on empty instance runSelenese(orchestrator, "/user/MyAccountPageTest/should_display_no_projects.html"); diff --git a/tests/src/test/java/org/sonarqube/tests/user/OAuth2IdentityProviderTest.java b/tests/src/test/java/org/sonarqube/tests/user/OAuth2IdentityProviderTest.java index a33f438b9f2..0c7b1744d15 100644 --- a/tests/src/test/java/org/sonarqube/tests/user/OAuth2IdentityProviderTest.java +++ b/tests/src/test/java/org/sonarqube/tests/user/OAuth2IdentityProviderTest.java @@ -109,7 +109,7 @@ public class OAuth2IdentityProviderTest { } @Test - public void authenticate_user_through_ui() throws Exception { + public void authenticate_user_through_ui() { simulateRedirectionToCallback(); enablePlugin(); @@ -120,7 +120,7 @@ public class OAuth2IdentityProviderTest { } @Test - public void redirect_to_requested_page() throws UnsupportedEncodingException { + public void redirect_to_requested_page() { simulateRedirectionToCallback(); enablePlugin(); tester.users().generate(u -> u.setLogin(USER_LOGIN)); @@ -140,7 +140,7 @@ public class OAuth2IdentityProviderTest { } @Test - public void display_unauthorized_page_when_authentication_failed_in_callback() throws Exception { + public void display_unauthorized_page_when_authentication_failed_in_callback() { simulateRedirectionToCallback(); enablePlugin(); @@ -153,7 +153,7 @@ public class OAuth2IdentityProviderTest { } @Test - public void fail_to_authenticate_when_not_allowed_to_sign_up() throws Exception { + public void fail_to_authenticate_when_not_allowed_to_sign_up() { simulateRedirectionToCallback(); enablePlugin(); tester.settings().setGlobalSettings("sonar.auth.fake-oauth2-id-provider.allowsUsersToSignUp", "false"); diff --git a/tests/src/test/java/org/sonarqube/tests/user/RealmAuthenticationTest.java b/tests/src/test/java/org/sonarqube/tests/user/RealmAuthenticationTest.java index 68ec5cbb687..36ad102dd95 100644 --- a/tests/src/test/java/org/sonarqube/tests/user/RealmAuthenticationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/user/RealmAuthenticationTest.java @@ -89,12 +89,12 @@ public class RealmAuthenticationTest { @Before @After - public void resetData() throws Exception { + public void resetData() { resetSettings(orchestrator, null, USERS_PROPERTY, "sonar.security.updateUserAttributes"); } @Before - public void initAdminUser() throws Exception { + public void initAdminUser() { userRule.createAdminUser(ADMIN_USER_LOGIN, ADMIN_USER_LOGIN); } @@ -232,7 +232,7 @@ public class RealmAuthenticationTest { // SONAR-3258 @Test - public void shouldAutomaticallyReactivateDeletedUser() throws Exception { + public void shouldAutomaticallyReactivateDeletedUser() { // Given clean Sonar installation and no users in external system // Let's create and delete the user "tester" in Sonar DB @@ -262,7 +262,7 @@ public class RealmAuthenticationTest { * SONAR-7036 */ @Test - public void update_password_of_technical_user() throws Exception { + public void update_password_of_technical_user() { // Create user in external authentication updateUsersInExtAuth(ImmutableMap.of(USER_LOGIN + ".password", USER_LOGIN)); verifyAuthenticationIsOk(USER_LOGIN, USER_LOGIN); @@ -288,7 +288,7 @@ public class RealmAuthenticationTest { * SONAR-7640 */ @Test - public void authentication_with_ws() throws Exception { + public void authentication_with_ws() { // Given clean Sonar installation and no users in external system String login = USER_LOGIN; String password = "1234567"; diff --git a/tests/src/test/java/org/sonarqube/tests/user/SsoAuthenticationTest.java b/tests/src/test/java/org/sonarqube/tests/user/SsoAuthenticationTest.java index 716a6a0dd17..07159881842 100644 --- a/tests/src/test/java/org/sonarqube/tests/user/SsoAuthenticationTest.java +++ b/tests/src/test/java/org/sonarqube/tests/user/SsoAuthenticationTest.java @@ -70,7 +70,7 @@ public class SsoAuthenticationTest { public static RuleChain ruleChain = RuleChain.outerRule(orchestrator).around(userRule); @Before - public void resetData() throws Exception { + public void resetData() { userRule.resetUsers(); } @@ -82,7 +82,7 @@ public class SsoAuthenticationTest { } @Test - public void authenticate_with_only_login() throws Exception { + public void authenticate_with_only_login() { doCall(USER_LOGIN, null, null, null); userRule.verifyUserExists(USER_LOGIN, USER_LOGIN, null); @@ -106,7 +106,7 @@ public class SsoAuthenticationTest { } @Test - public void synchronize_groups_when_authenticating_existing_user() throws Exception { + public void synchronize_groups_when_authenticating_existing_user() { userRule.createGroup(GROUP_1); userRule.createGroup(GROUP_2); userRule.createGroup(GROUP_3); @@ -119,7 +119,7 @@ public class SsoAuthenticationTest { } @Test - public void authentication_with_local_user_is_possible_when_no_header() throws Exception { + public void authentication_with_local_user_is_possible_when_no_header() { userRule.createUser(USER_LOGIN, "password"); checkLocalAuthentication(USER_LOGIN, "password"); diff --git a/tests/src/test/java/org/sonarqube/tests/user/UsersPageTest.java b/tests/src/test/java/org/sonarqube/tests/user/UsersPageTest.java index f736e9cfb62..a71f4305511 100644 --- a/tests/src/test/java/org/sonarqube/tests/user/UsersPageTest.java +++ b/tests/src/test/java/org/sonarqube/tests/user/UsersPageTest.java @@ -51,7 +51,7 @@ public class UsersPageTest { public Tester tester = new Tester(orchestrator).disableOrganizations(); @Before - public void initUsers() throws Exception { + public void initUsers() { adminUser = tester.users().generateAdministrator(u -> u.setLogin("admin-user").setPassword("admin-user")); tester.users().generate(u -> u.setLogin("random-user").setPassword("random-user")); } diff --git a/tests/src/test/java/org/sonarqube/tests/webhook/ExternalServer.java b/tests/src/test/java/org/sonarqube/tests/webhook/ExternalServer.java index 2edb48afc44..220dc1f59e5 100644 --- a/tests/src/test/java/org/sonarqube/tests/webhook/ExternalServer.java +++ b/tests/src/test/java/org/sonarqube/tests/webhook/ExternalServer.java @@ -48,7 +48,7 @@ class ExternalServer extends ExternalResource { jetty.setHandler(new AbstractHandler() { @Override public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) - throws IOException, ServletException { + throws IOException { if ("POST".equalsIgnoreCase(request.getMethod())) { String json = request.getReader().lines().collect(Collectors.joining(System.lineSeparator())); diff --git a/tests/src/test/java/util/ProjectAnalysisRule.java b/tests/src/test/java/util/ProjectAnalysisRule.java index 15f560fdf79..a60bbe5530a 100644 --- a/tests/src/test/java/util/ProjectAnalysisRule.java +++ b/tests/src/test/java/util/ProjectAnalysisRule.java @@ -98,7 +98,7 @@ public class ProjectAnalysisRule extends ExternalResource { } @Override - protected void before() throws Throwable { + protected void before() { orchestrator.resetData(); } |