diff options
Diffstat (limited to 'sonar-plugin-api-impl/src')
2 files changed, 13 insertions, 1 deletions
diff --git a/sonar-plugin-api-impl/src/main/java/org/sonar/api/batch/sensor/issue/internal/DefaultIssueLocation.java b/sonar-plugin-api-impl/src/main/java/org/sonar/api/batch/sensor/issue/internal/DefaultIssueLocation.java index 2dc92187466..c9d123f12dc 100644 --- a/sonar-plugin-api-impl/src/main/java/org/sonar/api/batch/sensor/issue/internal/DefaultIssueLocation.java +++ b/sonar-plugin-api-impl/src/main/java/org/sonar/api/batch/sensor/issue/internal/DefaultIssueLocation.java @@ -33,6 +33,7 @@ import org.sonar.api.issue.Issue; import static java.util.Objects.requireNonNull; import static org.apache.commons.lang.StringUtils.abbreviate; +import static org.apache.commons.lang.StringUtils.trim; import static org.sonar.api.utils.Preconditions.checkArgument; import static org.sonar.api.utils.Preconditions.checkState; @@ -64,7 +65,7 @@ public class DefaultIssueLocation implements NewIssueLocation, IssueLocation { @Override public DefaultIssueLocation message(String message) { validateMessage(message); - this.message = abbreviate(message, Issue.MESSAGE_MAX_SIZE); + this.message = abbreviate(trim(message), Issue.MESSAGE_MAX_SIZE); return this; } diff --git a/sonar-plugin-api-impl/src/test/java/org/sonar/api/batch/sensor/issue/internal/DefaultIssueLocationTest.java b/sonar-plugin-api-impl/src/test/java/org/sonar/api/batch/sensor/issue/internal/DefaultIssueLocationTest.java index 1c26aaa4400..4f7b5e552fc 100644 --- a/sonar-plugin-api-impl/src/test/java/org/sonar/api/batch/sensor/issue/internal/DefaultIssueLocationTest.java +++ b/sonar-plugin-api-impl/src/test/java/org/sonar/api/batch/sensor/issue/internal/DefaultIssueLocationTest.java @@ -19,6 +19,7 @@ */ package org.sonar.api.batch.sensor.issue.internal; +import java.util.Collections; import java.util.List; import org.apache.commons.lang.StringUtils; import org.junit.Test; @@ -124,4 +125,14 @@ public class DefaultIssueLocationTest { .hasMessageStartingWith("Character \\u0000 is not supported in issue message") .hasMessageEndingWith(", on component: src/Foo.php"); } + + @Test + public void should_trim_on_default_message_method(){ + assertThat(new DefaultIssueLocation().message(" message ").message()).isEqualTo("message"); + } + + @Test + public void should_not_trim_on_messageFormattings_message_method(){ + assertThat(new DefaultIssueLocation().message(" message ", Collections.emptyList()).message()).isEqualTo(" message "); + } } |