From 1ace6fef25bfce62a9b96a3a079e80cb75f819a7 Mon Sep 17 00:00:00 2001
From: Julien Lancelot <julien.lancelot@gmail.com>
Date: Mon, 8 Jul 2013 10:38:15 +0200
Subject: Fix quality flaws

---
 sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java   | 3 ++-
 .../src/main/java/org/sonar/server/issue/SetSeverityAction.java        | 3 ++-
 .../src/main/java/org/sonar/server/issue/TransitionAction.java         | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java b/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
index cb12690cb26..8550c60b2a3 100644
--- a/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/CommentAction.java
@@ -45,7 +45,8 @@ public class CommentAction extends Action implements ServerComponent {
 
   @Override
   public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
-    return comment(properties) != null;
+    comment(properties);
+    return true;
   }
 
   @Override
diff --git a/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java b/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
index 4a5ea4c82f1..ab9ab82c973 100644
--- a/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/SetSeverityAction.java
@@ -46,7 +46,8 @@ public class SetSeverityAction extends Action implements ServerComponent {
 
   @Override
   public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
-    return severity(properties) != null;
+    severity(properties);
+    return true;
   }
 
   @Override
diff --git a/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java b/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
index cc949f993dc..16da057468a 100644
--- a/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/TransitionAction.java
@@ -43,7 +43,8 @@ public class TransitionAction extends Action implements ServerComponent {
 
   @Override
   public boolean verify(Map<String, Object> properties, List<Issue> issues, UserSession userSession) {
-    return transition(properties) != null;
+    transition(properties);
+    return true;
   }
 
   @Override
-- 
cgit v1.2.3