From 66bc1a5209be23f425bdd63cccb26f5dcc272697 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Thu, 23 Jan 2014 09:54:02 +0100 Subject: Fix unit test --- .../src/main/java/org/sonar/server/issue/ws/IssueShowWsHandler.java | 1 + .../test/java/org/sonar/server/issue/ws/IssueShowWsHandlerTest.java | 5 ++--- .../issue/ws/IssueShowWsHandlerTest/show_issue_with_users.json | 3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/sonar-server/src/main/java/org/sonar/server/issue/ws/IssueShowWsHandler.java b/sonar-server/src/main/java/org/sonar/server/issue/ws/IssueShowWsHandler.java index 4de83cc922d..4f284d55056 100644 --- a/sonar-server/src/main/java/org/sonar/server/issue/ws/IssueShowWsHandler.java +++ b/sonar-server/src/main/java/org/sonar/server/issue/ws/IssueShowWsHandler.java @@ -187,6 +187,7 @@ public class IssueShowWsHandler implements RequestHandler { json .beginObject() .prop("key", entry.getKey()) + // TODO convert tech debt .prop("newValue", (String) diff.newValue()) .prop("oldValue", (String) diff.oldValue()) .endObject(); diff --git a/sonar-server/src/test/java/org/sonar/server/issue/ws/IssueShowWsHandlerTest.java b/sonar-server/src/test/java/org/sonar/server/issue/ws/IssueShowWsHandlerTest.java index d058ecb9a07..98f4aae943b 100644 --- a/sonar-server/src/test/java/org/sonar/server/issue/ws/IssueShowWsHandlerTest.java +++ b/sonar-server/src/test/java/org/sonar/server/issue/ws/IssueShowWsHandlerTest.java @@ -144,13 +144,12 @@ public class IssueShowWsHandlerTest { Issue issue = createStandardIssue() .setAssignee("john") .setReporter("steven") - .setAuthorLogin("henry"); + .setAuthorLogin("Henry"); issues.add(issue); result.addUsers(Lists.newArrayList( new DefaultUser().setLogin("john").setName("John"), - new DefaultUser().setLogin("steven").setName("Steven"), - new DefaultUser().setLogin("henry").setName("Henry") + new DefaultUser().setLogin("steven").setName("Steven") )); MockUserSession.set(); diff --git a/sonar-server/src/test/resources/org/sonar/server/issue/ws/IssueShowWsHandlerTest/show_issue_with_users.json b/sonar-server/src/test/resources/org/sonar/server/issue/ws/IssueShowWsHandlerTest/show_issue_with_users.json index 74c8c1ab508..9554a79702e 100644 --- a/sonar-server/src/test/resources/org/sonar/server/issue/ws/IssueShowWsHandlerTest/show_issue_with_users.json +++ b/sonar-server/src/test/resources/org/sonar/server/issue/ws/IssueShowWsHandlerTest/show_issue_with_users.json @@ -9,8 +9,7 @@ "assigneeName": "John", "reporter": "steven", "reporterName": "Steven", - "author": "henry", - "authorName": "Henry", + "author": "Henry", "creationDate": "2014-01-22T19:10:03+0100", "transitions": [], "actions": [], -- cgit v1.2.3