From b1a0b9b0737e169250d06845ab2656007376a3b8 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Thu, 9 Jul 2015 16:23:36 +0200 Subject: Add test with no data on formulas --- .../formula/AverageFormulaExecutionTest.java | 24 ++++++++++++++++++++++ .../formula/DistributionFormulaExecutionTest.java | 23 +++++++++++++++++++++ .../formula/SumFormulaExecutionTest.java | 23 +++++++++++++++++++++ 3 files changed, 70 insertions(+) diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/formula/AverageFormulaExecutionTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/formula/AverageFormulaExecutionTest.java index 9ce12223fe5..ae1fc1ebb39 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/computation/formula/AverageFormulaExecutionTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/computation/formula/AverageFormulaExecutionTest.java @@ -33,6 +33,7 @@ import org.sonar.server.computation.metric.MetricRepositoryRule; import org.sonar.server.computation.period.PeriodsHolderRule; import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.guava.api.Assertions.assertThat; import static org.sonar.api.measures.CoreMetrics.COMPLEXITY_IN_FUNCTIONS_KEY; import static org.sonar.api.measures.CoreMetrics.FUNCTIONS_KEY; import static org.sonar.api.measures.CoreMetrics.FUNCTION_COMPLEXITY_KEY; @@ -115,4 +116,27 @@ public class AverageFormulaExecutionTest { assertThat(toEntries(measureRepository.getNewRawMeasures(1211))).containsOnly(entryOf(FUNCTION_COMPLEXITY_KEY, newMeasureBuilder().create(4.5d))); } + @Test + public void not_add_measures_when_no_data_on_file() { + DumbComponent project = builder(PROJECT, 1) + .addChildren( + builder(MODULE, 11) + .addChildren( + builder(DIRECTORY, 111) + .addChildren( + builder(Component.Type.FILE, 1111).build() + ).build() + ).build() + ).build(); + + treeRootHolder.setRoot(project); + + sut.visit(project); + + assertThat(measureRepository.getNewRawMeasures(1)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(11)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(111)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(1111)).isEmpty(); + } + } diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/formula/DistributionFormulaExecutionTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/formula/DistributionFormulaExecutionTest.java index 1df455ff261..9c5043c6ae5 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/computation/formula/DistributionFormulaExecutionTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/computation/formula/DistributionFormulaExecutionTest.java @@ -98,4 +98,27 @@ public class DistributionFormulaExecutionTest { assertThat(measureRepository.getNewRawMeasures(1211)).isEmpty(); } + @Test + public void not_add_measures_when_no_data_on_file() { + DumbComponent project = builder(PROJECT, 1) + .addChildren( + builder(MODULE, 11) + .addChildren( + builder(DIRECTORY, 111) + .addChildren( + builder(Component.Type.FILE, 1111).build() + ).build() + ).build() + ).build(); + + treeRootHolder.setRoot(project); + + sut.visit(project); + + assertThat(measureRepository.getNewRawMeasures(1)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(11)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(111)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(1111)).isEmpty(); + } + } diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/formula/SumFormulaExecutionTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/formula/SumFormulaExecutionTest.java index 01c8c0ef265..f7196b29350 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/computation/formula/SumFormulaExecutionTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/computation/formula/SumFormulaExecutionTest.java @@ -98,4 +98,27 @@ public class SumFormulaExecutionTest { assertThat(measureRepository.getNewRawMeasures(1211)).isEmpty(); } + @Test + public void not_add_measures_when_no_data_on_file() { + DumbComponent project = builder(PROJECT, 1) + .addChildren( + builder(MODULE, 11) + .addChildren( + builder(DIRECTORY, 111) + .addChildren( + builder(Component.Type.FILE, 1111).build() + ).build() + ).build() + ).build(); + + treeRootHolder.setRoot(project); + + sut.visit(project); + + assertThat(measureRepository.getNewRawMeasures(1)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(11)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(111)).isEmpty(); + assertThat(measureRepository.getNewRawMeasures(1111)).isEmpty(); + } + } -- cgit v1.2.3