From de1cfcf63262e9c7cddbcc35702e30d916fa04ff Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Mon, 18 Aug 2014 12:54:12 +0600
Subject: SONAR-4406 Some minor improvements

---
 server/sonar-web/src/main/coffee/design/view.coffee        |  1 +
 server/sonar-web/src/main/hbs/design/design.hbs            | 14 +++++++-------
 .../src/main/resources/org/sonar/l10n/core.properties      | 13 +++++++++++++
 3 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/server/sonar-web/src/main/coffee/design/view.coffee b/server/sonar-web/src/main/coffee/design/view.coffee
index 23a2f16cb88..ea2483623b5 100644
--- a/server/sonar-web/src/main/coffee/design/view.coffee
+++ b/server/sonar-web/src/main/coffee/design/view.coffee
@@ -100,6 +100,7 @@ define [
       column = cell.parent().children().index(cell) - 1
       row = cell.parent().parent().children().index cell.parent()
       id = @collection.at(row).get('v')[column].i
+      return unless id
       @showInfoViewSpinner()
       @scrollToInfoView()
       $.get API_DEPENDECIES, parent: id, (data) =>
diff --git a/server/sonar-web/src/main/hbs/design/design.hbs b/server/sonar-web/src/main/hbs/design/design.hbs
index 743c4db6ebd..f9a7b523066 100644
--- a/server/sonar-web/src/main/hbs/design/design.hbs
+++ b/server/sonar-web/src/main/hbs/design/design.hbs
@@ -1,21 +1,21 @@
 <div class="dsm-header">
-  <i class="icon-help"></i> <a href="http://docs.codehaus.org/x/QQFhC">{{t 'help'}}</a>
+  <i class="icon-help"></i> <a href="http://docs.codehaus.org/x/QQFhC">{{t 'design.help'}}</a>
 </div>
 
 <ul class="dsm-legend">
   <li>
     <span class="dsm-legend-square gray"></span>
-    <span class="dsm-legend-label">Dependency</span>
+    <span class="dsm-legend-label">{{t 'design.legend.dependencies'}}</span>
   </li>
   <li>
     <span class="dsm-legend-square red"></span>
-    <span class="dsm-legend-label">Suspect dependency (cycle)</span>
+    <span class="dsm-legend-label">{{t 'design.legend.cycles'}}</span>
   </li>
   <li>
     <span class="dsm-legend-square green"></span>
-    <span class="dsm-legend-label">uses</span>
+    <span class="dsm-legend-label">{{t 'design.legend.uses'}}</span>
     <span class="dsm-legend-square blue"></span>
-    <span class="dsm-legend-label">uses</span>
+    <span class="dsm-legend-label">{{t 'design.legend.uses'}}</span>
     <span class="dsm-legend-square yellow"></span>
   </li>
 </ul>
@@ -25,12 +25,12 @@
     <tbody>
     {{#eachIndex items}}
       <tr>
-        <td class="dsm-body-title">
+        <td class="dsm-body-title" title="{{t 'design.rowTooltip'}}">
           {{qualifierIcon q}} {{n}}
           <span class="dsm-body-title-indicator"></span>
         </td>
         {{#eachIndex v}}
-          <td class="dsm-body-cell {{#if status}}dsm-body-cell-{{status}}{{/if}}">
+          <td class="dsm-body-cell {{#if status}}dsm-body-cell-{{status}}{{/if}}" title="{{t 'design.cellTooltip'}}">
             {{#eq index ../index}}–{{else}}{{w}}{{/eq}}
           </td>
         {{/eachIndex}}
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 9170f96b64b..4e9c3d65d21 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -2719,3 +2719,16 @@ component_viewer.workspace=Workspace
 component_viewer.workspace.tooltip=Keeps track of history of navigation
 component_viewer.workspace.show_workspace=Show workspace
 component_viewer.workspace.hide_workspace=Hide workspace
+
+
+#------------------------------------------------------------------------------
+#
+# DESIGN
+#
+#------------------------------------------------------------------------------
+design.help=Help
+design.legend.dependencies=Dependency
+design.legend.cycles=Suspect dependency (cycle)
+design.legend.uses=- uses >
+design.cellTooltip=Click to highlight, double-click to display more details
+design.rowTooltip=Click to highlight, double-click to zoom
-- 
cgit v1.2.3