From 6771e1e53238ca9ea8c1f03ac7f2f1007265ef6e Mon Sep 17 00:00:00 2001
From: Fabrice Bellingard <bellingard@gmail.com>
Date: Fri, 20 Jan 2012 11:33:25 +0100
Subject: SONAR-3012 Improve widget rendering

- 2 columns instead of 3
- "On new code" just below "unreviewed violations"
---
 .../core/widgets/reviews/reviews_metrics.html.erb  | 44 ++++++++++------------
 1 file changed, 20 insertions(+), 24 deletions(-)

(limited to 'plugins/sonar-core-plugin')

diff --git a/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/reviews/reviews_metrics.html.erb b/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/reviews/reviews_metrics.html.erb
index dbb02475816..4403de98ad9 100644
--- a/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/reviews/reviews_metrics.html.erb
+++ b/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/reviews/reviews_metrics.html.erb
@@ -8,7 +8,7 @@
 %>
 <table width="100%">
   <tr>
-    <td valign="top" width="33%" nowrap>
+    <td valign="top" width="48%" nowrap>
       <div class="dashbox">
         <h3><%= message('widget.reviews_metrics.active_reviews') -%></h3>
         <% if active_reviews %>
@@ -30,39 +30,35 @@
       </div>
     </td>
     <td width="10"> </td>
-    <td valign="top" width="33%">
-      <div class="dashbox">
-        <h3><%= message('widget.reviews_metrics.false_positives') -%></h3>
-        <% if false_positive_reviews %>
-        <p>
-          <span class="big"><%= format_measure(false_positive_reviews, :suffix => '', :url => url_for_drilldown(false_positive_reviews)) -%></span>
-          <%= dashboard_configuration.selected_period? ? format_variation(false_positive_reviews) : trend_icon(false_positive_reviews) -%>
-        </p>
-        <% else %>
-          <span class="empty_widget"><%= message('widget.reviews_metrics.no_data') -%></span>
-        <% end %>
-      </div>
-    </td>
-    <td width="10"> </td>
-    <td valign="top" width="33%">
+    <td valign="top">
       <div class="dashbox">
         <h3><%= message('widget.reviews_metrics.unreviewed_violations') -%></h3>
         <% if unreviewed_violations %>
         <p>
           <span class="big"><%= format_measure(unreviewed_violations, :suffix => '', :url => url_for_drilldown(unreviewed_violations)) -%></span>
           <%= dashboard_configuration.selected_period? ? format_variation(unreviewed_violations) : trend_icon(unreviewed_violations) -%>
+          <% 
+             if new_unreviewed_violations && @dashboard_configuration.selected_period? 
+          %>
+            <br/>
+            <span style="font-weight: bold">
+              <%= message('widget.reviews_metrics.on_new_code') -%>
+              <a href="<%= url_for_drilldown('new_unreviewed_violations', :period => dashboard_configuration.period_index) -%>"><%= format_variation(new_unreviewed_violations, :style => 'none', :default => '-') -%></a>
+            </span>
+          <% end %>
         </p>
         <% else %>
           <span class="empty_widget"><%= message('widget.reviews_metrics.no_data') -%></span>
         <% end %>
-        <% 
-           if new_unreviewed_violations && @dashboard_configuration.selected_period? 
-        %>
-          <br/>
-          <h3><%= message('widget.reviews_metrics.on_new_code') -%></h3>
-          <p>
-            <span class="big"><a href="<%= url_for_drilldown('new_unreviewed_violations', :period => dashboard_configuration.period_index) -%>"><%= format_variation(new_unreviewed_violations, :style => 'none', :default => '-') -%></a></span>
-          </p>
+        <br/>
+        <h3><%= message('widget.reviews_metrics.false_positives') -%></h3>
+        <% if false_positive_reviews %>
+        <p>
+          <span class="big"><%= format_measure(false_positive_reviews, :suffix => '', :url => url_for_drilldown(false_positive_reviews)) -%></span>
+          <%= dashboard_configuration.selected_period? ? format_variation(false_positive_reviews) : trend_icon(false_positive_reviews) -%>
+        </p>
+        <% else %>
+          <span class="empty_widget"><%= message('widget.reviews_metrics.no_data') -%></span>
         <% end %>
       </div>
     </td>
-- 
cgit v1.2.3