From 295a87208f8c9898fbdc733a438587dc03a16877 Mon Sep 17 00:00:00 2001 From: Matteo Mara Date: Mon, 9 Jan 2023 10:21:46 +0100 Subject: [NO-JIRA] Remove reported code smells about usage of instanceof --- .../src/main/java/org/sonar/auth/ldap/CallbackHandlerImpl.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'server/sonar-auth-ldap/src') diff --git a/server/sonar-auth-ldap/src/main/java/org/sonar/auth/ldap/CallbackHandlerImpl.java b/server/sonar-auth-ldap/src/main/java/org/sonar/auth/ldap/CallbackHandlerImpl.java index 472a1821cf8..08b267d3478 100644 --- a/server/sonar-auth-ldap/src/main/java/org/sonar/auth/ldap/CallbackHandlerImpl.java +++ b/server/sonar-auth-ldap/src/main/java/org/sonar/auth/ldap/CallbackHandlerImpl.java @@ -41,13 +41,11 @@ public class CallbackHandlerImpl implements CallbackHandler { @Override public void handle(Callback[] callbacks) throws UnsupportedCallbackException, IOException { for (Callback callBack : callbacks) { - if (callBack instanceof NameCallback) { + if (callBack instanceof NameCallback nameCallback) { // Handles username callback - NameCallback nameCallback = (NameCallback) callBack; nameCallback.setName(name); - } else if (callBack instanceof PasswordCallback) { + } else if (callBack instanceof PasswordCallback passwordCallback) { // Handles password callback - PasswordCallback passwordCallback = (PasswordCallback) callBack; passwordCallback.setPassword(password.toCharArray()); } else { throw new UnsupportedCallbackException(callBack, "Callback not supported"); -- cgit v1.2.3