From 6519110cd4f98fabf3bef46896eecbead3eb646a Mon Sep 17 00:00:00 2001 From: Duarte Meneses Date: Fri, 22 Oct 2021 10:38:45 -0500 Subject: Fix code quality issues --- .../src/test/java/org/sonar/auth/ldap/LdapAutodiscoveryTest.java | 4 ++-- .../src/test/java/org/sonar/auth/ldap/LdapGroupMappingTest.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'server/sonar-auth-ldap/src') diff --git a/server/sonar-auth-ldap/src/test/java/org/sonar/auth/ldap/LdapAutodiscoveryTest.java b/server/sonar-auth-ldap/src/test/java/org/sonar/auth/ldap/LdapAutodiscoveryTest.java index f4d527f376b..d39bccde4b2 100644 --- a/server/sonar-auth-ldap/src/test/java/org/sonar/auth/ldap/LdapAutodiscoveryTest.java +++ b/server/sonar-auth-ldap/src/test/java/org/sonar/auth/ldap/LdapAutodiscoveryTest.java @@ -63,7 +63,7 @@ public class LdapAutodiscoveryTest { assertThat(new LdapSrvRecord("http://foo:389", 1, 1)).isEqualTo(new LdapSrvRecord("http://foo:389", 2, 0)); assertThat(new LdapSrvRecord("http://foo:389", 1, 1)).isNotEqualTo(new LdapSrvRecord("http://foo:388", 1, 1)); - assertThat(new LdapSrvRecord("http://foo:389", 1, 1).hashCode()).isEqualTo(new LdapSrvRecord("http://foo:389", 1, 1).hashCode()); + assertThat(new LdapSrvRecord("http://foo:389", 1, 1)).hasSameHashCodeAs(new LdapSrvRecord("http://foo:389", 1, 1).hashCode()); } @Test @@ -74,7 +74,7 @@ public class LdapAutodiscoveryTest { NamingEnumeration namingEnumeration = mock(NamingEnumeration.class); when(context.getAttributes(Mockito.anyString(), Mockito.anyObject())).thenReturn(attributes); - when(attributes.get(Mockito.eq("srv"))).thenReturn(attribute); + when(attributes.get("srv")).thenReturn(attribute); when(attribute.getAll()).thenReturn(namingEnumeration); when(namingEnumeration.hasMore()).thenReturn(true, true, true, true, true, false); when(namingEnumeration.next()) diff --git a/server/sonar-auth-ldap/src/test/java/org/sonar/auth/ldap/LdapGroupMappingTest.java b/server/sonar-auth-ldap/src/test/java/org/sonar/auth/ldap/LdapGroupMappingTest.java index d7eb43a8896..50060cf2935 100644 --- a/server/sonar-auth-ldap/src/test/java/org/sonar/auth/ldap/LdapGroupMappingTest.java +++ b/server/sonar-auth-ldap/src/test/java/org/sonar/auth/ldap/LdapGroupMappingTest.java @@ -35,7 +35,7 @@ public class LdapGroupMappingTest { assertThat(groupMapping.getRequest()).isEqualTo("(&(objectClass=groupOfUniqueNames)(uniqueMember={0}))"); assertThat(groupMapping.getRequiredUserAttributes()).isEqualTo(new String[] {"dn"}); - assertThat(groupMapping.toString()).isEqualTo("LdapGroupMapping{" + + assertThat(groupMapping).hasToString("LdapGroupMapping{" + "baseDn=null," + " idAttribute=cn," + " requiredUserAttributes=[dn]," + -- cgit v1.2.3