From 09f8f0f6ca0fab099775351385b1dfbe96bc6e5f Mon Sep 17 00:00:00 2001 From: Jacek Date: Tue, 6 Aug 2019 17:40:20 +0200 Subject: SONAR-12364 - SonarQube analysis fixes --- .../java/org/sonar/db/component/BranchDtoTest.java | 31 ++++++++++++++++++++++ .../db/newcodeperiod/NewCodePeriodDaoTest.java | 15 +++++++++++ 2 files changed, 46 insertions(+) (limited to 'server/sonar-db-dao/src/test') diff --git a/server/sonar-db-dao/src/test/java/org/sonar/db/component/BranchDtoTest.java b/server/sonar-db-dao/src/test/java/org/sonar/db/component/BranchDtoTest.java index 43019062bc4..2f39a2fb03d 100644 --- a/server/sonar-db-dao/src/test/java/org/sonar/db/component/BranchDtoTest.java +++ b/server/sonar-db-dao/src/test/java/org/sonar/db/component/BranchDtoTest.java @@ -49,6 +49,37 @@ public class BranchDtoTest { assertThat(underTest.isMain()).isFalse(); } + @Test + public void verify_equals() { + underTest.setUuid("U1"); + underTest.setProjectUuid("U2"); + underTest.setKey("K1"); + underTest.setBranchType(BranchType.LONG); + underTest.setMergeBranchUuid("U3"); + + assertThat(underTest.toString()).isEqualTo("BranchDto{uuid='U1', " + + "projectUuid='U2', kee='K1', keyType=null, branchType=LONG, mergeBranchUuid='U3'}"); + } + + @Test + public void verify_toString() { + underTest.setUuid("U1"); + underTest.setProjectUuid("U2"); + underTest.setKey("K1"); + underTest.setBranchType(BranchType.LONG); + underTest.setMergeBranchUuid("U3"); + + BranchDto toCompare = new BranchDto(); + + toCompare.setUuid("U1"); + toCompare.setProjectUuid("U2"); + toCompare.setKey("K1"); + toCompare.setBranchType(BranchType.LONG); + toCompare.setMergeBranchUuid("U3"); + + assertThat(underTest).isEqualTo(toCompare); + } + @Test public void encode_and_decode_pull_request_data() { String branch = "feature/pr1"; diff --git a/server/sonar-db-dao/src/test/java/org/sonar/db/newcodeperiod/NewCodePeriodDaoTest.java b/server/sonar-db-dao/src/test/java/org/sonar/db/newcodeperiod/NewCodePeriodDaoTest.java index 4b238b9eef9..1b5009af1a9 100644 --- a/server/sonar-db-dao/src/test/java/org/sonar/db/newcodeperiod/NewCodePeriodDaoTest.java +++ b/server/sonar-db-dao/src/test/java/org/sonar/db/newcodeperiod/NewCodePeriodDaoTest.java @@ -252,6 +252,21 @@ public class NewCodePeriodDaoTest { assertThat(exists).isTrue(); } + @Test + public void delete_by_project_uuid_and_branch_uuid() { + when(uuidFactory.create()).thenReturn(NEW_CODE_PERIOD_UUID); + + underTest.insert(dbSession, new NewCodePeriodDto() + .setProjectUuid("proj-uuid") + .setBranchUuid("branch-uuid") + .setType(NewCodePeriodType.SPECIFIC_ANALYSIS) + .setValue("analysis-uuid")); + + underTest.deleteByProjectUuidAndBranchUuid(dbSession, "proj-uuid", "branch-uuid"); + db.commit(); + assertNewCodePeriodRowCount(0); + } + @Test public void exists_by_project_analysis_is_false() { boolean exists = underTest.existsByProjectAnalysisUuid(dbSession, "analysis-uuid"); -- cgit v1.2.3