From b6bffded1c8e125cb2621b47ddcb9ddb0799b98f Mon Sep 17 00:00:00 2001 From: Léo Geoffroy <99647462+leo-geoffroy-sonarsource@users.noreply.github.com> Date: Tue, 11 Oct 2022 11:00:11 +0200 Subject: SONAR-17352 Fix quality issues Co-authored-by: Duarte Meneses --- .../src/main/java/org/sonar/db/component/ComponentDao.java | 2 +- .../src/test/java/org/sonar/db/component/ComponentDaoTest.java | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) (limited to 'server/sonar-db-dao') diff --git a/server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java b/server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java index c561e71775e..4eb3b7e177d 100644 --- a/server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java +++ b/server/sonar-db-dao/src/main/java/org/sonar/db/component/ComponentDao.java @@ -392,7 +392,7 @@ public class ComponentDao implements Dao { mapper(session).setPrivateForRootComponentUuid(branchUuid, isPrivate); } - public void setPrivateForRootComponentUuid(DbSession session, String branchUuid, boolean isPrivate, @Nullable String qualifier, String componentKey, String componentName) { + public void setPrivateForRootComponentUuid(DbSession session, String branchUuid, boolean isPrivate, String qualifier, String componentKey, String componentName) { ComponentNewValue componentNewValue = new ComponentNewValue(branchUuid, componentName, componentKey, isPrivate, qualifier); auditPersister.updateComponentVisibility(session, componentNewValue); mapper(session).setPrivateForRootComponentUuid(branchUuid, isPrivate); diff --git a/server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java b/server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java index 3533a00faea..706b1012917 100644 --- a/server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java +++ b/server/sonar-db-dao/src/test/java/org/sonar/db/component/ComponentDaoTest.java @@ -299,7 +299,9 @@ public class ComponentDaoTest { @Test public void select_by_keys_throws_ISE_if_both_branch_and_pr_are_passed() { - assertThatThrownBy(() -> underTest.selectByKeys(db.getSession(), List.of("key"), "branch", "pr")) + DbSession session = db.getSession(); + List keys = List.of("key"); + assertThatThrownBy(() -> underTest.selectByKeys(session, keys, "branch", "pr")) .isInstanceOf(IllegalStateException.class); } -- cgit v1.2.3