From 3ecc736b43a6d0e85fd4b4089c3dcad53f8640ec Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Lievremont Date: Tue, 15 Jul 2014 11:49:56 +0200 Subject: SONAR-5001 Link description_format column to relational backend --- .../java/org/sonar/server/rule/db/RuleDaoTest.java | 7 +++++++ .../sonar/server/rule/db/RuleDaoTest/insert-result.xml | 2 +- .../server/rule/db/RuleDaoTest/insert_all-result.xml | 4 ++-- .../org/sonar/server/rule/db/RuleDaoTest/selectAll.xml | 2 +- .../sonar/server/rule/db/RuleDaoTest/selectById.xml | 4 ++-- .../server/rule/db/RuleDaoTest/selectNonManual.xml | 4 ++-- .../server/rule/db/RuleDaoTest/select_by_name.xml | 4 ++-- .../server/rule/db/RuleDaoTest/select_by_rule_key.xml | 4 ++-- .../db/RuleDaoTest/select_enables_and_non_manual.xml | 6 +++--- .../sonar/server/rule/db/RuleDaoTest/update-result.xml | 6 +++--- .../org/sonar/server/rule/db/RuleDaoTest/update.xml | 6 +++--- ..._issue_with_coeff_to_constant_issue_with_offset.xml | 6 +++--- ...with_coeff_to_constant_issue_with_offset_result.xml | 6 +++--- ...copy_requirements_from_characteristics_to_rules.xml | 18 +++++++++--------- ...quirements_from_characteristics_to_rules_result.xml | 18 +++++++++--------- .../do_nothing_when_already_executed.xml | 18 +++++++++--------- .../do_nothing_when_already_executed_result.xml | 18 +++++++++--------- 17 files changed, 70 insertions(+), 63 deletions(-) (limited to 'server/sonar-server') diff --git a/server/sonar-server/src/test/java/org/sonar/server/rule/db/RuleDaoTest.java b/server/sonar-server/src/test/java/org/sonar/server/rule/db/RuleDaoTest.java index 491af760ce9..8412ee5b049 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/rule/db/RuleDaoTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/rule/db/RuleDaoTest.java @@ -69,6 +69,7 @@ public class RuleDaoTest extends AbstractDaoTestCase { assertThat(ruleDto.getId()).isEqualTo(1); assertThat(ruleDto.getName()).isEqualTo("Avoid Null"); assertThat(ruleDto.getDescription()).isEqualTo("Should avoid NULL"); + assertThat(ruleDto.getDescriptionFormat()).isEqualTo("HTML"); assertThat(ruleDto.getStatus()).isEqualTo(RuleStatus.READY); assertThat(ruleDto.getRepositoryKey()).isEqualTo("checkstyle"); assertThat(ruleDto.getNoteData()).isEqualTo("Rule note with accents \u00e9\u00e8\u00e0"); @@ -93,6 +94,7 @@ public class RuleDaoTest extends AbstractDaoTestCase { assertThat(ruleDto.getId()).isEqualTo(1); assertThat(ruleDto.getName()).isEqualTo("Avoid Null"); assertThat(ruleDto.getDescription()).isEqualTo("Should avoid NULL"); + assertThat(ruleDto.getDescriptionFormat()).isEqualTo("HTML"); assertThat(ruleDto.getStatus()).isEqualTo(RuleStatus.READY); assertThat(ruleDto.getRepositoryKey()).isEqualTo("checkstyle"); assertThat(ruleDto.getNoteData()).isEqualTo("Rule note with accents \u00e9\u00e8\u00e0"); @@ -115,6 +117,7 @@ public class RuleDaoTest extends AbstractDaoTestCase { assertThat(ruleDto.getId()).isEqualTo(2); assertThat(ruleDto.getName()).isEqualTo("Avoid Null"); assertThat(ruleDto.getDescription()).isEqualTo("Should avoid NULL"); + assertThat(ruleDto.getDescriptionFormat()).isEqualTo("HTML"); assertThat(ruleDto.getStatus()).isEqualTo(RuleStatus.READY); assertThat(ruleDto.getRepositoryKey()).isEqualTo("checkstyle"); } @@ -170,6 +173,7 @@ public class RuleDaoTest extends AbstractDaoTestCase { .setRepositoryKey("plugin") .setName("new name") .setDescription("new description") + .setDescriptionFormat("MARKDOWN") .setStatus(RuleStatus.DEPRECATED) .setConfigKey("NewConfigKey") .setSeverity(Severity.INFO) @@ -210,6 +214,7 @@ public class RuleDaoTest extends AbstractDaoTestCase { .setRepositoryKey("plugin") .setName("new name") .setDescription("new description") + .setDescriptionFormat("MARKDOWN") .setStatus(RuleStatus.DEPRECATED) .setConfigKey("NewConfigKey") .setSeverity(Severity.INFO) @@ -244,6 +249,7 @@ public class RuleDaoTest extends AbstractDaoTestCase { .setRepositoryKey("plugin") .setName("new name") .setDescription("new description") + .setDescriptionFormat("HTML") .setStatus(RuleStatus.DEPRECATED) .setConfigKey("NewConfigKey") .setSeverity(Severity.INFO) @@ -266,6 +272,7 @@ public class RuleDaoTest extends AbstractDaoTestCase { .setRepositoryKey("plugin2") .setName("new name2") .setDescription("new description2") + .setDescriptionFormat("MARKDOWN") .setStatus(RuleStatus.BETA) .setConfigKey("NewConfigKey2") .setSeverity(Severity.MAJOR) diff --git a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/insert-result.xml b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/insert-result.xml index 766dcf93a1b..144ea0906f9 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/insert-result.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/insert-result.xml @@ -27,7 +27,7 @@ remediation_function="LINEAR" default_remediation_function="LINEAR_OFFSET" remediation_coeff="1h" default_remediation_coeff="5d" remediation_offset="5min" default_remediation_offset="10h" - effort_to_fix_description="squid.S115.effortToFix" + effort_to_fix_description="squid.S115.effortToFix" description_format="MARKDOWN" /> diff --git a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/insert_all-result.xml b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/insert_all-result.xml index e687f135fbe..1aa7b053d0d 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/insert_all-result.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/insert_all-result.xml @@ -27,7 +27,7 @@ remediation_function="LINEAR" default_remediation_function="LINEAR_OFFSET" remediation_coeff="1h" default_remediation_coeff="5d" remediation_offset="5min" default_remediation_offset="10h" - effort_to_fix_description="squid.S115.effortToFix" + effort_to_fix_description="squid.S115.effortToFix" description_format="HTML" /> diff --git a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/selectAll.xml b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/selectAll.xml index 2dbc0f1c3cf..57fc4fecb51 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/selectAll.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/selectAll.xml @@ -2,7 +2,7 @@ - - + + diff --git a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/selectNonManual.xml b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/selectNonManual.xml index 53e9a2dfecc..c69e0d85864 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/selectNonManual.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/selectNonManual.xml @@ -1,6 +1,6 @@ - - + + diff --git a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_by_name.xml b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_by_name.xml index ee6c7b8a0b8..0f2d818a01d 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_by_name.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_by_name.xml @@ -1,6 +1,6 @@ - - + + diff --git a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_by_rule_key.xml b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_by_rule_key.xml index ee6c7b8a0b8..0f2d818a01d 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_by_rule_key.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_by_rule_key.xml @@ -1,6 +1,6 @@ - - + + diff --git a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_enables_and_non_manual.xml b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_enables_and_non_manual.xml index 38d6cc5ce02..fe85e591078 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_enables_and_non_manual.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/select_enables_and_non_manual.xml @@ -1,7 +1,7 @@ + note_created_at="[null]" note_data="[null]" note_updated_at="[null]" note_user_login="[null]" description_format="HTML"/> + note_created_at="[null]" note_data="[null]" note_updated_at="[null]" note_user_login="[null]" description_format="HTML"/> diff --git a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/update.xml b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/update.xml index d4979390cdf..e0e99d24549 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/update.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/rule/db/RuleDaoTest/update.xml @@ -1,12 +1,12 @@ + plugin_config_key="AvoidNull" priority="2" is_template="[false]" language="golo" created_at="2011-04-25 01:05:00" template_id="2" description_format="HTML"/> + plugin_config_key="Parent1" priority="2" is_template="[false]" language="golo" created_at="1981-10-24 15:20:00" description_format="HTML"/> + plugin_config_key="Parent2" priority="2" is_template="[false]" language="dart" created_at="1982-12-14 03:15:00" description_format="HTML"/> diff --git a/server/sonar-server/src/test/resources/org/sonar/server/startup/CopyRequirementsFromCharacteristicsToRulesTest/convert_constant_issue_with_coeff_to_constant_issue_with_offset.xml b/server/sonar-server/src/test/resources/org/sonar/server/startup/CopyRequirementsFromCharacteristicsToRulesTest/convert_constant_issue_with_coeff_to_constant_issue_with_offset.xml index 0dd12e8beed..432fb122d56 100644 --- a/server/sonar-server/src/test/resources/org/sonar/server/startup/CopyRequirementsFromCharacteristicsToRulesTest/convert_constant_issue_with_coeff_to_constant_issue_with_offset.xml +++ b/server/sonar-server/src/test/resources/org/sonar/server/startup/CopyRequirementsFromCharacteristicsToRulesTest/convert_constant_issue_with_coeff_to_constant_issue_with_offset.xml @@ -2,7 +2,7 @@ Update rule to Constant/issue with only offset --> No update --> Update rule to Constant/issue with offset --> Update rule to Constant/issue with only offset --> No update --> Nothing to do --> Update rule to disable characteristic --> Do nothing --> Nothing to do --> Update rule --> to be replaced by null)="[null]" with different value of debt -> Update rule --> to be replaced by null)="[null]" with different value of debt -> Update rule --> should be replaced by 0d)="[null]" with different value of debt -> Update rule --> should keep 0d)="[null]" with different value of debt -> Update rule --> Nothing to do --> Update rule to disable characteristic --> Do nothing --> Nothing to do --> Update rule --> to be replaced by null), with different value of debt -> Update rule --> to be replaced by null), with different value of debt -> Update rule --> should keep 0h), with different value of debt -> Update rule --> should keep 0d), with different value of debt -> Update rule --> Nothing to do --> Update rule to disable characteristic --> Do nothing --> Nothing to do --> Update rule --> to be replaced by null)="[null]" with different value of debt -> Update rule --> to be replaced by null)="[null]" with different value of debt -> Update rule --> should be replaced by 0d)="[null]" with different value of debt -> Update rule --> should keep 0d)="[null]" with different value of debt -> Update rule --> Nothing to do --> Update rule to disable characteristic --> Do nothing --> Nothing to do --> Update rule --> to be replaced by null)="[null]" with different value of debt -> Update rule --> to be replaced by null)="[null]" with different value of debt -> Update rule --> should be replaced by 0d)="[null]" with different value of debt -> Update rule --> should keep 0d)="[null]" with different value of debt -> Update rule -->