From 46d075adfb3c4a666010a14d925203690bad0f10 Mon Sep 17 00:00:00 2001 From: Wouter Admiraal Date: Thu, 4 Apr 2019 15:16:46 +0200 Subject: Improve test coverage --- server/sonar-web/src/main/js/helpers/qualityGates.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'server/sonar-web/src/main/js/helpers/qualityGates.ts') diff --git a/server/sonar-web/src/main/js/helpers/qualityGates.ts b/server/sonar-web/src/main/js/helpers/qualityGates.ts index 5dbb8a257b1..090647a8781 100644 --- a/server/sonar-web/src/main/js/helpers/qualityGates.ts +++ b/server/sonar-web/src/main/js/helpers/qualityGates.ts @@ -34,12 +34,10 @@ export function extractStatusConditionsFromProjectStatus( } export function isSameStatusConditionList( - conditions?: T.QualityGateStatusCondition[], - prevConditions?: T.QualityGateStatusCondition[] + conditions: T.QualityGateStatusCondition[] = [], + prevConditions: T.QualityGateStatusCondition[] = [] ): boolean { - if (conditions === undefined || prevConditions === undefined) { - return !(prevConditions || conditions); - } else if (conditions.length !== prevConditions.length) { + if (conditions.length !== prevConditions.length) { return false; } else { const filtered = conditions.filter(c1 => { -- cgit v1.2.3