From 78e12d6af59b774ee6f3fa16e38aa35caab159d7 Mon Sep 17 00:00:00 2001 From: Stas Vilchik Date: Wed, 2 Dec 2015 15:01:20 +0100 Subject: improve display of overview pages when no coverage or duplications details available --- .../src/main/js/apps/overview/domains/coverage-domain.js | 14 +++++++++++++- .../main/js/apps/overview/domains/duplications-domain.js | 14 ++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) (limited to 'server/sonar-web') diff --git a/server/sonar-web/src/main/js/apps/overview/domains/coverage-domain.js b/server/sonar-web/src/main/js/apps/overview/domains/coverage-domain.js index d79f7846f51..f9aabc06ec6 100644 --- a/server/sonar-web/src/main/js/apps/overview/domains/coverage-domain.js +++ b/server/sonar-web/src/main/js/apps/overview/domains/coverage-domain.js @@ -36,7 +36,7 @@ export const CoverageMain = React.createClass({ ready: true, measures, leak, - coverageMetricPrefix: this.getCoverageMetricPrefix(measures), + coverageMetricPrefix: this.getCoverageMetricPrefix(measures) }); }); }, @@ -73,6 +73,14 @@ export const CoverageMain = React.createClass({ ; }, + renderEmpty() { + return
+
+

{window.t('overview.no_coverage')}

+
+
; + }, + renderLegend () { return }, @@ -89,6 +97,10 @@ export const CoverageMain = React.createClass({ let coverageMetric = this.state.coverageMetricPrefix + 'coverage', uncoveredLinesMetric = this.state.coverageMetricPrefix + 'uncovered_lines'; + if (this.state.measures[coverageMetric] == null) { + return this.renderEmpty(); + } + return
diff --git a/server/sonar-web/src/main/js/apps/overview/domains/duplications-domain.js b/server/sonar-web/src/main/js/apps/overview/domains/duplications-domain.js index fe4cae3afac..785ca31ae65 100644 --- a/server/sonar-web/src/main/js/apps/overview/domains/duplications-domain.js +++ b/server/sonar-web/src/main/js/apps/overview/domains/duplications-domain.js @@ -64,6 +64,14 @@ export const DuplicationsMain = React.createClass({
; }, + renderEmpty() { + return
+
+

{window.t('overview.no_duplications')}

+
+
; + }, + renderLegend () { return }, @@ -81,9 +89,15 @@ export const DuplicationsMain = React.createClass({ if (!this.state.ready) { return this.renderLoading(); } + + if (this.state.measures['duplicated_lines_density'] == null) { + return this.renderEmpty(); + } + let treemapScale = d3.scale.linear() .domain([0, 25, 50, 75, 100]) .range(CHART_COLORS_RANGE_PERCENT); + return
-- cgit v1.2.3