From f6f59ecbf8e15e3b251bb0a44a0846b5acca7ea4 Mon Sep 17 00:00:00 2001 From: Antoine Vinot Date: Fri, 19 Aug 2022 17:05:25 +0200 Subject: SONAR-17210 - Update Github Scanning Alerts on status changes --- .../QGChangeEventListenersImplTest.java | 50 ++++++++++++++++------ 1 file changed, 36 insertions(+), 14 deletions(-) (limited to 'server/sonar-webserver-api/src/test') diff --git a/server/sonar-webserver-api/src/test/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImplTest.java b/server/sonar-webserver-api/src/test/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImplTest.java index cd83615d99b..e5215ae5f31 100644 --- a/server/sonar-webserver-api/src/test/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImplTest.java +++ b/server/sonar-webserver-api/src/test/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImplTest.java @@ -64,20 +64,20 @@ public class QGChangeEventListenersImplTest { @Rule public LogTester logTester = new LogTester(); - private QGChangeEventListener listener1 = mock(QGChangeEventListener.class); - private QGChangeEventListener listener2 = mock(QGChangeEventListener.class); - private QGChangeEventListener listener3 = mock(QGChangeEventListener.class); - private List listeners = Arrays.asList(listener1, listener2, listener3); + private final QGChangeEventListener listener1 = mock(QGChangeEventListener.class); + private final QGChangeEventListener listener2 = mock(QGChangeEventListener.class); + private final QGChangeEventListener listener3 = mock(QGChangeEventListener.class); + private final List listeners = Arrays.asList(listener1, listener2, listener3); - private String project1Uuid = RandomStringUtils.randomAlphabetic(6); - private BranchDto project1 = newBranchDto(project1Uuid); - private DefaultIssue component1Issue = newDefaultIssue(project1Uuid); - private List oneIssueOnComponent1 = singletonList(component1Issue); - private QGChangeEvent component1QGChangeEvent = newQGChangeEvent(project1); + private final String project1Uuid = RandomStringUtils.randomAlphabetic(6); + private final BranchDto project1 = newBranchDto(project1Uuid); + private final DefaultIssue component1Issue = newDefaultIssue(project1Uuid); + private final List oneIssueOnComponent1 = singletonList(component1Issue); + private final QGChangeEvent component1QGChangeEvent = newQGChangeEvent(project1); - private InOrder inOrder = Mockito.inOrder(listener1, listener2, listener3); + private final InOrder inOrder = Mockito.inOrder(listener1, listener2, listener3); - private QGChangeEventListenersImpl underTest = new QGChangeEventListenersImpl(new QGChangeEventListener[] {listener1, listener2, listener3}); + private final QGChangeEventListenersImpl underTest = new QGChangeEventListenersImpl(new QGChangeEventListener[] {listener1, listener2, listener3}); @Test public void broadcastOnIssueChange_has_no_effect_when_issues_are_empty() { @@ -149,9 +149,9 @@ public class QGChangeEventListenersImplTest { List traceLogs = logTester.logs(LoggerLevel.TRACE); assertThat(traceLogs).hasSize(3) .containsOnly( - "calling onChange() on listener " + listener1.getClass().getName() + " for events " + component1QGChangeEvent.toString() + "...", - "calling onChange() on listener " + listener2.getClass().getName() + " for events " + component1QGChangeEvent.toString() + "...", - "calling onChange() on listener " + listener3.getClass().getName() + " for events " + component1QGChangeEvent.toString() + "..."); + "calling onChange() on listener " + listener1.getClass().getName() + " for events " + component1QGChangeEvent + "...", + "calling onChange() on listener " + listener2.getClass().getName() + " for events " + component1QGChangeEvent + "...", + "calling onChange() on listener " + listener3.getClass().getName() + " for events " + component1QGChangeEvent + "..."); } @Test @@ -252,6 +252,28 @@ public class QGChangeEventListenersImplTest { assertThat(changedIssue.isNotClosed()).isFalse(); } + @Test + public void isVulnerability_returns_true_if_issue_is_of_type_vulnerability() { + DefaultIssue defaultIssue = new DefaultIssue(); + defaultIssue.setStatus(Issue.STATUS_OPEN); + defaultIssue.setType(RuleType.VULNERABILITY); + + ChangedIssue changedIssue = new ChangedIssueImpl(defaultIssue); + + assertThat(changedIssue.isVulnerability()).isTrue(); + } + + @Test + public void isVulnerability_returns_false_if_issue_is_not_of_type_vulnerability() { + DefaultIssue defaultIssue = new DefaultIssue(); + defaultIssue.setStatus(Issue.STATUS_OPEN); + defaultIssue.setType(RuleType.BUG); + + ChangedIssue changedIssue = new ChangedIssueImpl(defaultIssue); + + assertThat(changedIssue.isVulnerability()).isFalse(); + } + @Test public void test_status_mapping() { assertThat(ChangedIssueImpl.statusOf(new DefaultIssue().setStatus(Issue.STATUS_OPEN))).isEqualTo(QGChangeEventListener.Status.OPEN); -- cgit v1.2.3