From d871fdd2dda38b9768367c3ab6ba71fba3ccb10b Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Mon, 23 Mar 2015 09:05:25 +0100
Subject: fix quality flaws

---
 .../src/main/js/coding-rules/facets/characteristic-facet.js  |  1 -
 .../src/main/js/components/navigator/models/state.js         | 12 +++++++-----
 server/sonar-web/src/main/js/sortable.js                     |  2 +-
 .../sonar-web/src/main/js/source-viewer/measures-overlay.js  |  1 -
 .../src/main/js/source-viewer/popups/duplication-popup.js    |  1 -
 5 files changed, 8 insertions(+), 9 deletions(-)

(limited to 'server')

diff --git a/server/sonar-web/src/main/js/coding-rules/facets/characteristic-facet.js b/server/sonar-web/src/main/js/coding-rules/facets/characteristic-facet.js
index 5275d260317..c7485ba0572 100644
--- a/server/sonar-web/src/main/js/coding-rules/facets/characteristic-facet.js
+++ b/server/sonar-web/src/main/js/coding-rules/facets/characteristic-facet.js
@@ -48,7 +48,6 @@ define([
         obj.has_debt_characteristic = null;
         obj[property] = this.getValue();
       }
-      console.log(obj);
       this.options.app.state.updateFilter(obj);
     },
 
diff --git a/server/sonar-web/src/main/js/components/navigator/models/state.js b/server/sonar-web/src/main/js/components/navigator/models/state.js
index 0f0ddf5f4ca..c9e4fcf6b85 100644
--- a/server/sonar-web/src/main/js/components/navigator/models/state.js
+++ b/server/sonar-web/src/main/js/components/navigator/models/state.js
@@ -20,11 +20,13 @@
 define(function () {
 
   return Backbone.Model.extend({
-    defaults: {
-      page: 1,
-      maxResultsReached: false,
-      query: {},
-      facets: []
+    defaults: function () {
+      return {
+        page: 1,
+        maxResultsReached: false,
+        query: {},
+        facets: []
+      };
     },
 
     nextPage: function () {
diff --git a/server/sonar-web/src/main/js/sortable.js b/server/sonar-web/src/main/js/sortable.js
index cfe3c07a89e..b9100ed585d 100644
--- a/server/sonar-web/src/main/js/sortable.js
+++ b/server/sonar-web/src/main/js/sortable.js
@@ -39,7 +39,7 @@
     }).get();
 
     Array.prototype.sort.call(sortArray, function(a, b) {
-      if (isNaN(a.value) || isNaN(a.value)) {
+      if (isNaN(a.value) || isNaN(b.value)) {
         return order * (a.value > b.value ? 1 : -1);
       } else {
         return order * (a.value - b.value);
diff --git a/server/sonar-web/src/main/js/source-viewer/measures-overlay.js b/server/sonar-web/src/main/js/source-viewer/measures-overlay.js
index 5887c20af28..37822ac56bc 100644
--- a/server/sonar-web/src/main/js/source-viewer/measures-overlay.js
+++ b/server/sonar-web/src/main/js/source-viewer/measures-overlay.js
@@ -128,7 +128,6 @@ define([
           measures: measures,
           measuresToDisplay: that.prepareMetrics(metrics)
         });
-        console.log(that.model.get('measuresToDisplay'));
       });
     },
 
diff --git a/server/sonar-web/src/main/js/source-viewer/popups/duplication-popup.js b/server/sonar-web/src/main/js/source-viewer/popups/duplication-popup.js
index e1479daa14d..4564bfd8d1d 100644
--- a/server/sonar-web/src/main/js/source-viewer/popups/duplication-popup.js
+++ b/server/sonar-web/src/main/js/source-viewer/popups/duplication-popup.js
@@ -35,7 +35,6 @@ define([
     goToFile: function (e) {
       var uuid = $(e.currentTarget).data('uuid'),
           line = $(e.currentTarget).data('line');
-      console.log(uuid);
       if (Workspace == null) {
         Workspace = require('workspace/main');
       }
-- 
cgit v1.2.3