From b2b78e6333268b30e8d5825de2ed5d2c5958d7a8 Mon Sep 17 00:00:00 2001
From: Simon Brandhof <simon.brandhof@gmail.com>
Date: Mon, 12 Aug 2013 12:27:03 +0200
Subject: SONAR-4563 Use strict comparison for createdAfter in the Issues
 search engine

---
 .../src/main/resources/org/sonar/core/issue/db/IssueMapper.xml     | 3 +++
 sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java | 7 ++++++-
 .../core/issue/db/IssueDaoTest/should_select_by_date_creation.xml  | 2 +-
 3 files changed, 10 insertions(+), 2 deletions(-)

(limited to 'sonar-core/src')

diff --git a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
index 8e65de6406d..e2c55b4aa92 100644
--- a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
+++ b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
@@ -290,6 +290,9 @@
       <if test="query.createdAfter() != null">
         and i.issue_creation_date &gt; #{query.createdAfter}
       </if>
+      <if test="query.createdAtOrAfter() != null">
+        and i.issue_creation_date &gt;= #{query.createdAtOrAfter}
+      </if>
       <if test="query.createdBefore() != null">
         and i.issue_creation_date &lt; #{query.createdBefore}
       </if>
diff --git a/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java b/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java
index 69ac592d896..b8fdb2977bc 100644
--- a/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/issue/db/IssueDaoTest.java
@@ -120,8 +120,13 @@ public class IssueDaoTest extends AbstractDaoTestCase {
   public void should_select_by_date_creation() {
     setupData("shared", "should_select_by_date_creation");
 
-    IssueQuery query = IssueQuery.builder().createdAfter(DateUtils.parseDate("2013-04-15")).requiredRole("user").build();
+    IssueQuery query = IssueQuery.builder().createdAfter(DateUtils.parseDate("2013-04-15")).build();
     assertThat(dao.selectIssueIds(query)).hasSize(1);
+    assertThat(dao.selectIssueIds(query).get(0).getId()).isEqualTo(100L);
+
+    query = IssueQuery.builder().createdAtOrAfter(DateUtils.parseDate("2013-04-15")).build();
+    assertThat(dao.selectIssueIds(query)).hasSize(1);
+    assertThat(dao.selectIssueIds(query).get(0).getId()).isEqualTo(100L);
 
     query = IssueQuery.builder().createdBefore(DateUtils.parseDate("2013-04-17")).requiredRole("user").build();
     assertThat(dao.selectIssueIds(query)).hasSize(2);
diff --git a/sonar-core/src/test/resources/org/sonar/core/issue/db/IssueDaoTest/should_select_by_date_creation.xml b/sonar-core/src/test/resources/org/sonar/core/issue/db/IssueDaoTest/should_select_by_date_creation.xml
index cd509c70d50..cf6048a5e83 100644
--- a/sonar-core/src/test/resources/org/sonar/core/issue/db/IssueDaoTest/should_select_by_date_creation.xml
+++ b/sonar-core/src/test/resources/org/sonar/core/issue/db/IssueDaoTest/should_select_by_date_creation.xml
@@ -18,7 +18,7 @@
       assignee="perceval"
       author_login="[null]"
       issue_attributes="JIRA=FOO-1234"
-      issue_creation_date="2013-04-16"
+      issue_creation_date="2013-04-16 15:50:45"
       issue_update_date="2013-04-16"
       issue_close_date="2013-04-16"
       created_at="2013-04-16"
-- 
cgit v1.2.3