From 0969171e8fffb08af06a32a1226d3eff02d336db Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Fri, 20 Sep 2013 07:55:48 +0200 Subject: Fix quality flaws --- .../src/main/java/org/sonar/core/permission/PermissionFacade.java | 4 ++-- sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'sonar-core') diff --git a/sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java b/sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java index 054970f9c42..44306841b8c 100644 --- a/sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java +++ b/sonar-core/src/main/java/org/sonar/core/permission/PermissionFacade.java @@ -100,7 +100,7 @@ public class PermissionFacade implements TaskComponent, ServerComponent { insertGroupPermission(resourceId, groupId, permission, null); } - public void insertGroupPermission(@Nullable Long resourceId, @Nullable String groupName, String permission, @Nullable SqlSession session) { + public void insertGroupPermission(@Nullable Long resourceId, String groupName, String permission, @Nullable SqlSession session) { if (DefaultGroups.isAnyone(groupName)) { insertGroupPermission(resourceId, (Long) null, permission, session); } else { @@ -127,7 +127,7 @@ public class PermissionFacade implements TaskComponent, ServerComponent { deleteGroupPermission(resourceId, groupId, permission, null); } - public void deleteGroupPermission(@Nullable Long resourceId, @Nullable String groupName, String permission, @Nullable SqlSession session) { + public void deleteGroupPermission(@Nullable Long resourceId, String groupName, String permission, @Nullable SqlSession session) { if (DefaultGroups.isAnyone(groupName)) { deleteGroupPermission(resourceId, (Long) null, permission, session); } else { diff --git a/sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java b/sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java index 669acafaeeb..9a683f6d8c3 100644 --- a/sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java +++ b/sonar-core/src/main/java/org/sonar/core/user/GroupRoleDto.java @@ -51,11 +51,12 @@ public class GroupRoleDto { return this; } + @Nullable public Long getResourceId() { return resourceId; } - public GroupRoleDto setResourceId(Long resourceId) { + public GroupRoleDto setResourceId(@Nullable Long resourceId) { this.resourceId = resourceId; return this; } -- cgit v1.2.3