From f51d791bf3c45222086f031f75cdaeae0358883a Mon Sep 17 00:00:00 2001
From: Evgeny Mandrikov <mandrikov@gmail.com>
Date: Mon, 12 Sep 2011 02:26:06 +0400
Subject: Fix violations

---
 .../src/main/java/org/sonar/duplications/cpd/Match.java           | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

(limited to 'sonar-duplications')

diff --git a/sonar-duplications/src/main/java/org/sonar/duplications/cpd/Match.java b/sonar-duplications/src/main/java/org/sonar/duplications/cpd/Match.java
index 0ec9a9ad72c..2541b814d2c 100644
--- a/sonar-duplications/src/main/java/org/sonar/duplications/cpd/Match.java
+++ b/sonar-duplications/src/main/java/org/sonar/duplications/cpd/Match.java
@@ -89,11 +89,16 @@ public class Match implements Comparable<Match> {
       second = m2.getIndex();
     }
 
+    @Override
     public int hashCode() {
       return first + 37 * second;
     }
 
+    @Override
     public boolean equals(Object other) {
+      if (!(other instanceof MatchCode)) {
+        return false;
+      }
       MatchCode mc = (MatchCode) other;
       return mc.first == first && mc.second == second;
     }
@@ -145,7 +150,7 @@ public class Match implements Comparable<Match> {
   }
 
   public int compareTo(Match other) {
-    int diff = other.getTokenCount() - getTokenCount();
+    int diff = other.getTokenCount() - getTokenCount(); // NOSONAR Bad practice - Class defines compareTo(...) and uses Object.equals()
     if (diff != 0) {
       return diff;
     }
@@ -160,6 +165,7 @@ public class Match implements Comparable<Match> {
     return marks[1];
   }
 
+  @Override
   public String toString() {
     return "Match: " + EOL + "tokenCount = " + tokenCount + EOL + "marks = " + markSet.size();
   }
-- 
cgit v1.2.3