From 80fb6e85116635811a262052da8d740ab178ca55 Mon Sep 17 00:00:00 2001
From: Simon Brandhof <simon.brandhof@gmail.com>
Date: Wed, 29 May 2013 22:53:55 +0200
Subject: Fix some quality flaws

---
 .../src/main/java/org/sonar/api/issue/RubyIssueService.java      | 6 ++++--
 .../src/main/java/org/sonar/api/resources/Project.java           | 9 +++++----
 .../src/main/java/org/sonar/api/utils/KeyValueFormat.java        | 4 ++--
 3 files changed, 11 insertions(+), 8 deletions(-)

(limited to 'sonar-plugin-api/src')

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/issue/RubyIssueService.java b/sonar-plugin-api/src/main/java/org/sonar/api/issue/RubyIssueService.java
index 458f123541f..4da22172578 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/issue/RubyIssueService.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/issue/RubyIssueService.java
@@ -54,8 +54,10 @@ public interface RubyIssueService extends ServerComponent {
    *   <li>'reporters': list of reporter logins. Note that reporters are defined only on "manual" issues.</li>
    *   <li>'assignees': list of assignee logins.</li>
    *   <li>'assigned': true to get only assigned issues, false to get only unassigned issues. By default no filtering is done.</li>
-   *   <li>'createdAfter': match all the issues created after the given date (inclusive). Both date and datetime ISO formats are supported: 2013-05-18 or 2010-05-18T15:50:45+0100</li>
-   *   <li>'createdBefore': match all the issues created before the given date (exclusive). Both date and datetime ISO formats are supported: 2013-05-18 or 2010-05-18T15:50:45+0100</li>
+   *   <li>'createdAfter': match all the issues created after the given date (inclusive).
+   *   Both date and datetime ISO formats are supported: 2013-05-18 or 2010-05-18T15:50:45+0100</li>
+   *   <li>'createdBefore': match all the issues created before the given date (exclusive).
+   *   Both date and datetime ISO formats are supported: 2013-05-18 or 2010-05-18T15:50:45+0100</li>
    *   <li>'pageSize': maximum number of results per page. Default is {@link org.sonar.api.issue.IssueQuery#DEFAULT_PAGE_SIZE},
    *   except when the parameter 'components' is set. In this case there's no limit by default (all results in the same page).</li>
    *   <li>'pageIndex': index of the selected page. Default is 1.</li>
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/resources/Project.java b/sonar-plugin-api/src/main/java/org/sonar/api/resources/Project.java
index 88ce3a94d3a..ac3494b136b 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/resources/Project.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/resources/Project.java
@@ -74,7 +74,6 @@ public class Project extends Resource implements Component {
   private Date analysisDate;
   private AnalysisType analysisType;
   private String analysisVersion;
-  private boolean latestAnalysis;
 
   // modules tree
   private Project parent;
@@ -212,12 +211,14 @@ public class Project extends Resource implements Component {
   /**
    * For internal use only.
    *
-   * @deprecated in 3.6. It's not possible to do an analyse before the latest known quality snapshot. See http://jira.codehaus.org/browse/SONAR-4334
+   * @deprecated in 3.6. It's not possible to analyze a project before the latest known quality snapshot.
+   * See http://jira.codehaus.org/browse/SONAR-4334
    */
   @Deprecated
   public Project setLatestAnalysis(boolean b) {
-    if (b == false) {
-      throw new UnsupportedOperationException("The analysis is always the latest one. Past analysis must be done in a chronological order.");
+    if (!b) {
+      throw new UnsupportedOperationException("The analysis is always the latest one. " +
+        "Past analysis must be done in a chronological order.");
     }
     return this;
   }
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/KeyValueFormat.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/KeyValueFormat.java
index b1368a91969..24fd2c8cf50 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/KeyValueFormat.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/KeyValueFormat.java
@@ -477,8 +477,8 @@ public final class KeyValueFormat {
    * @deprecated since 2.7. Replaced by Converter
    */
   @Deprecated
-  public interface Transformer<KEY, VALUE> {
-    KeyValue<KEY, VALUE> transform(String key, String value);
+  public interface Transformer<K, V> {
+    KeyValue<K, V> transform(String key, String value);
   }
 
   /**
-- 
cgit v1.2.3