From 2bb7acebc75ff7ae6cb0a413ac298f048a43d534 Mon Sep 17 00:00:00 2001 From: Wojtek Wajerowicz <115081248+wojciech-wajerowicz-sonarsource@users.noreply.github.com> Date: Wed, 7 Jun 2023 17:18:52 +0200 Subject: SONAR-19160 handle missing locations in SARIF import. (#8476) --- .../scanner/externalissue/sarif/ResultMapperTest.java | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) (limited to 'sonar-scanner-engine/src/test/java/org/sonar') diff --git a/sonar-scanner-engine/src/test/java/org/sonar/scanner/externalissue/sarif/ResultMapperTest.java b/sonar-scanner-engine/src/test/java/org/sonar/scanner/externalissue/sarif/ResultMapperTest.java index c6eaed7f556..309a8ed9503 100644 --- a/sonar-scanner-engine/src/test/java/org/sonar/scanner/externalissue/sarif/ResultMapperTest.java +++ b/sonar-scanner-engine/src/test/java/org/sonar/scanner/externalissue/sarif/ResultMapperTest.java @@ -129,7 +129,19 @@ public class ResultMapperTest { } @Test - public void mapResult_whenLocationNotFound_createsProjectLocation() { + public void mapResult_whenLocationsIsEmpty_createsProjectLocation() { + NewExternalIssue newExternalIssue = resultMapper.mapResult(DRIVER_NAME, WARNING, result); + + verify(locationMapper).fillIssueInProjectLocation(result, newExternalIssueLocation); + verifyNoMoreInteractions(locationMapper); + verify(newExternalIssue).at(newExternalIssueLocation); + verify(newExternalIssue, never()).addLocation(any()); + verify(newExternalIssue, never()).addFlow(any()); + } + + @Test + public void mapResult_whenLocationsIsNull_createsProjectLocation() { + when(result.getLocations()).thenReturn(null); NewExternalIssue newExternalIssue = resultMapper.mapResult(DRIVER_NAME, WARNING, result); verify(locationMapper).fillIssueInProjectLocation(result, newExternalIssueLocation); -- cgit v1.2.3