From bb32902cf66508fbdf2e3991fba329f557b5de4c Mon Sep 17 00:00:00 2001 From: fmallet Date: Mon, 20 Sep 2010 13:43:04 +0000 Subject: fix Checkstyle extension implementation : MethodsCountCheck. A NullPointerException was thrown on files without java class definition. --- .../src/main/java/org/sonar/it/checkstyle/MethodsCountCheck.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'tests/integration/checkstyle-extensions') diff --git a/tests/integration/checkstyle-extensions/src/main/java/org/sonar/it/checkstyle/MethodsCountCheck.java b/tests/integration/checkstyle-extensions/src/main/java/org/sonar/it/checkstyle/MethodsCountCheck.java index c824851d524..b82a6a98d17 100644 --- a/tests/integration/checkstyle-extensions/src/main/java/org/sonar/it/checkstyle/MethodsCountCheck.java +++ b/tests/integration/checkstyle-extensions/src/main/java/org/sonar/it/checkstyle/MethodsCountCheck.java @@ -19,6 +19,11 @@ public class MethodsCountCheck extends Check { return new int[]{TokenTypes.CLASS_DEF, TokenTypes.METHOD_DEF}; } + public void beginTree(DetailAST rootAST) { + methodsCount = 0; + classAST = null; + } + public void visitToken(DetailAST ast) { //ensure this is an unit test. if ( ast.getType() == TokenTypes.CLASS_DEF ) { @@ -31,7 +36,7 @@ public class MethodsCountCheck extends Check { public void finishTree(DetailAST rootAST) { super.finishTree(rootAST); - if (methodsCount < minMethodsCount) { + if (classAST != null && methodsCount < minMethodsCount) { log(classAST.getLineNo(), classAST.getColumnNo(), "Too few methods (" + methodsCount + ") in class" ); } } -- cgit v1.2.3