From 834c05b0a251f38043a7961dab920f20720c1144 Mon Sep 17 00:00:00 2001 From: Ulrich-Matthias Schäfer Date: Thu, 8 Nov 2018 11:12:26 +0100 Subject: get rid of the fixmes and todos --- src/elements/Rect.js | 16 ++++------------ src/elements/Text.js | 1 - 2 files changed, 4 insertions(+), 13 deletions(-) (limited to 'src/elements') diff --git a/src/elements/Rect.js b/src/elements/Rect.js index 9d6163c..fa66fc3 100644 --- a/src/elements/Rect.js +++ b/src/elements/Rect.js @@ -1,5 +1,6 @@ -import { nodeOrNew, register } from '../utils/adopter.js' +import { extend, nodeOrNew, register } from '../utils/adopter.js' import { registerMethods } from '../utils/methods.js' +import { rx, ry } from '../modules/core/circled.js' import Shape from './Shape.js' export default class Rect extends Shape { @@ -7,19 +8,10 @@ export default class Rect extends Shape { constructor (node) { super(nodeOrNew('rect', node), Rect) } - - // FIXME: unify with circle - // Radius x value - rx (rx) { - return this.attr('rx', rx) - } - - // Radius y value - ry (ry) { - return this.attr('ry', ry) - } } +extend(Rect, { rx, ry }) + registerMethods({ Container: { // Create a rect element diff --git a/src/elements/Text.js b/src/elements/Text.js index 58d50a3..f1aa402 100644 --- a/src/elements/Text.js +++ b/src/elements/Text.js @@ -55,7 +55,6 @@ export default class Text extends Shape { text (text) { // act as getter if (text === undefined) { - // FIXME use children() or each() var children = this.node.childNodes var firstLine = 0 text = '' -- cgit v1.2.3