From 99e176f76332b47a6c026dbd9dcf7742191b8b29 Mon Sep 17 00:00:00 2001 From: Ulrich-Matthias Schäfer Date: Sun, 27 Sep 2020 13:35:47 +1000 Subject: fix `clone()` to return the correct instance (#1154) --- src/elements/Dom.js | 2 +- src/utils/adopter.js | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/elements/Dom.js b/src/elements/Dom.js index eb59418..7c36078 100644 --- a/src/elements/Dom.js +++ b/src/elements/Dom.js @@ -72,7 +72,7 @@ export default class Dom extends EventTarget { this.writeDataToDom() // clone element and assign new id - return assignNewId(this.node.cloneNode(deep)) + return new this.constructor(assignNewId(this.node.cloneNode(deep))) } // Iterates over all children and invokes a given block diff --git a/src/utils/adopter.js b/src/utils/adopter.js index 2de1b27..a440e4c 100644 --- a/src/utils/adopter.js +++ b/src/utils/adopter.js @@ -107,10 +107,11 @@ export function assignNewId (node) { } if (node.id) { - return adopt(node).id(eid(node.nodeName)) + node.id = eid(node.nodeName) + return node } - return adopt(node) + return node } // Method for extending objects -- cgit v1.2.3