| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
These functions act only on the input parameters, so let's make them
static to more clearly indicate that they do not act upon any object.
|
|
|
|
|
| |
Store the name in a std::string to make things less complex as we don't
need to be as careful about making sure the data is free():d.
|
|
|
|
|
| |
Remove redundant arguments where the method already has access to the
relevant variable as an object attribute.
|
|
|
|
|
|
|
|
|
| |
These are often more readable as they avoid a lot of the boilerplate of
iterating over fixed arrays or STL containers.
Note that this change is very conservative to avoid noise in "git
blame". Only loops where this is a clear improvement have been
converted.
|
|
|
|
|
|
|
| |
Clients cannot remove themselves from the list as we are iterating, so
we don't need this complexity. If a client encounters a problem, it will
only mark it self as closed and will be removed from the list at a later
time.
|
|
|
|
|
| |
Let's avoid reimplementing something basic that's available in the
standard library. It also makes the code easier to read.
|
| |
|
|
|
|
| |
Make sure developers don't miss marking methods correctly.
|
|
|
|
|
| |
Use the new "override" keyword to properly differentiate between new
virtual methods, and existing virtual methods being overridden.
|
|
|
|
|
| |
The compiler can help out in making sure we are consistent in our use of
nullptr rather than NULL.
|
|
|
|
|
|
| |
We use the pointer to just store an identifier for the menu, but this is
enough for gcc to think we are using 0 instead of nullptr and complain.
Even an explicit cast isn't enough to silence it here for some reason.
|
|
|
|
|
| |
It's more readable than 0, and a bit safer than NULL, so let's try to
follow modern norms.
|
|
|
|
|
|
| |
It's rare we use a compiler that has anything older as a default, but it
does happen sometimes. So make sure to guarantee this so we can start
using more modern constructs.
|
|
|
|
|
| |
Make sure the dependencies point to the correct files, even if an out of
tree build is used.
|
|\
| |
| | |
Updates for package builds
|
| | |
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | | |
These are no longer used in the versions of Xorg currently in use.
|
| | |
| | |
| | |
| | |
| | | |
No current distribution uses anything older, so let's make things easier
for us to maintain.
|
| | |
| | |
| | |
| | |
| | | |
Ubuntu 18.04 has been EOL for almost a year, so remove those packages so
we can ease our maintenance burden.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Things do not need to be this complicated. We can make sure the VNC
extension is always included in a much cleaner way, at least since Xorg
1.16.
|
| | |
| | |
| | |
| | | |
This hasn't been needed since Xorg 1.16.
|
| | |
| | |
| | |
| | |
| | | |
Unclear why this was ever needed. libX11 is for X11 clients, and we're
building a server.
|
| | |
| | |
| | |
| | |
| | | |
Make things a bit easier to maintain. This style is also more in line
with what is being done for other DDX.
|
| | |
| | |
| | |
| | | |
This has never actually been used, as far as I can tell.
|
| | |
| | |
| | |
| | |
| | | |
Rather than disabling this, make sure the build can find the relevant
file.
|
| | |
| | |
| | |
| | |
| | | |
VENDOR_RELEASE has been available as a #define since Xorg 1.7, so let's
use that and remove all of our custom magic.
|
|\| |
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Run the frame clock at a slow 1 Hz if there are no clients connected.
This is similar to what a normal X server does when the screen is
blanked, and should keep applications waiting for the frame tick happy.
Note that we still only keep the frame clock running if there is any
application that are interested in it. Otherwise we still stop it
completely.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If there is something interested in synchronizing to a frame tick, then
keep the frame clock running, even if there are no updates.
This is need mainly when something starts rendering, but also when
something renders much slower than the frame clock (so it is essentially
constantly "starting"). Such an application will not draw anything until
it gets a new frame tick, which it won't get as the frame clock is
waiting for something to start drawing.
|
| |
| |
| |
| |
| |
| | |
This marks the timer as started again, before we call out to various
external places that might be confused by the frame timer reporting that
it is stopped.
|
| |
| |
| |
| |
| |
| |
| | |
This makes it possible for applications to synchronize their updates to
the updates sent out to clients. This avoids tearing, and could in the
future also help with rate limiting applications to what the client can
actually show.
|
| | |
|
| |
| |
| |
| |
| | |
Let's avoid requring these as a desktop implementation can now set up
everything in the init() method.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The desktop isn't completely paused just because there are no clients,
so it might still need some support from the server object.
This is primarily an issue for headless servers, where they need to
continue emulating things even without clients. A scraping server can
generally go completely passive if there are no clients.
|
| | |
|
| |
| |
| |
| |
| |
| | |
One-shot timers are more common, so let's change the API a bit to make
that use case simpler. This API also makes it more clear what is
happening.
|
| |
| |
| |
| | |
They were badly formatted, way longer than the normal 72 columns.
|
| |
| |
| |
| |
| |
| | |
It currently won't ever be called with an empty list of timers, but it
is a public function so that might happen in the future. Make sure this
case is handled without crashes.
|
| |
| |
| |
| |
| | |
It is much more sane to treat "0" as "a timer is ready NOW", so let's
change to using -1 as the invalid timeout value.
|
| |
| |
| |
| | |
This should have been done in a4308c9.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Repeating a timer can be done in two ways:
* Returning true from the handler
* Calling start() again in the handler
The latter is useful if you want to change the timer interval.
If both are used, then it becomes ambiguous when the timer should fire
again.
Detect this case and warn about it. Current implementation will respect
the new interval given to start(), rather than the interval set before
running the handler.
|
| | |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Avoid duplicating this complexity in too many places.
At the same time make the interface more identical to regular mkdir(),
for familiarity.
|
| | |
| | |
| | |
| | |
| | | |
This is an often changed database, so it is better suited for
$XDG_STATE_HOME rather than the more static $XDG_DATA_HOME.
|
| | |
| | |
| | |
| | |
| | | |
This is only needed because of an historical type change of the legacy
directory, so avoid doing it anywhere else.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The syslog file descriptor will be closed when we are cleaning up in
preparation for running the vncserver script, so we need to explicitly
reopen things in case we need to log errors.
At the same time, try to be polite and explicitly close the log when
appropriate.
|
| | |
| | |
| | |
| | |
| | | |
E.g. pam_env.so might modify this variable, so we should see what we get
out of PAM when building a log file path.
|